Allow default None for optional bools #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slots of type
:bool
now support a default ofNone
in the Python messages. Specifically, when a slot has both:type :bool
and:required nil
, and does not have an explicit:default
the resulting Python message will look something likeslot: Optional[bool] = None
. This allows when to differentiate between whether a false-y value was provided (False
) or no value was providedNone
.Todo