-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for nested filters (extId, selectedNumbers, selectedCompanys, selectedIco) #48
base: master
Are you sure you want to change the base?
Conversation
rasstislav
commented
Sep 25, 2024
hi @rasstislav - sorry to respond so late to this. could you please add that example you provided to tests? |
@segy done :-) |
@@ -189,7 +189,21 @@ protected function _addRefElement(\SimpleXMLElement $xml, string $name, $value, | |||
} | |||
|
|||
foreach ($value as $key => $value) { | |||
$node->addChild('typ:' . $key, $this->_sanitize($value), $this->_namespace('typ')); | |||
if (\is_array($value)) { | |||
if (array_is_list($value)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nema backward compatibility
if (\is_array($value)) { | ||
if (array_is_list($value)) { | ||
foreach ($value as $value) { | ||
$node->addChild($namespace . ':' . $key, $this->_sanitize($value), $this->_namespace($namespace)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toto je dost na mieru toho filtra na to, ze je to umiestnene v Agende. ja by som pravdupovediac idealne tuto cast kodu vobec nechytal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pozri ako je urobeny napr. https://github.com/riesenia/pohoda/blob/master/src/Pohoda/PrintRequest/PrinterSettings.php