hwi: add async-trait #308
Merged
hwi: add async-trait #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouardparis
force-pushed
the
hwi-async-trait
branch
6 times, most recently
from
e10c87a to
2a013ca
Compare
edouardparis
force-pushed
the
hwi-async-trait
branch
3 times, most recently
from
c7c2a2a to
9b8bd8d
Compare
|
utACK 9b8bd8d - code looks really good to me, but I didn't test :) |
Makes the app and the app context unlinked of the list of supported hardware wallets.
edouardparis
force-pushed
the
hwi-async-trait
branch
from
9b8bd8d to
b639623
Compare
|
utACK b639623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #309