[RFC] Introduce checkpatch action #474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I like not having to distribute our own version of [1] An addition would be to consolidate the various checks into a make target. |
Fixes: 12345 ("Mistaken fixes")
Signed-off-by: Paolo Valerio <[email protected]>
vlrpl
force-pushed
the
checkpatch
branch
7 times, most recently
from
298d82b to
b19d2a5
Compare
The project, as stated in CONTRIBUTING have a strong preference for the Linux kernel coding style. This patch enforces it by adding automatic checks in the CI for bpf sources. The patch uses and import the current checkpatch.pl and its requirement spelling.txt. Signed-off-by: Paolo Valerio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing an existing GH action doesn't seem bad, but Cirrus would be fairly simple.
If Cirrus or in general we reach a consensus around not reusing the action used here, we have to decide whether we have to redistribute
checkpatch.pl(andspelling.txt)Included a couple of patches that intentionally introduce some coding style issues to show the pros and cons of the action.
Configs have been left intentionally loose, feel free to propose what you think could make sense.