Improve README syntax highlight example #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
remcohaszing
approved these changes
Apr 5, 2023
| @@ -354,14 +354,14 @@ ReactDom.render( | |||
| const match = /language-(\w+)/.exec(className || '') | |||
| return !inline && match ? ( | |||
| <SyntaxHighlighter | |||
| {...props} | |||
There was a problem hiding this comment.
It might be better to not even pass spread props at all.
Anyway, I'm not necessarily against it.
There was a problem hiding this comment.
I think there was something about SyntaxHighlighter passing all other props through on the div or so:
spread props pass arbitrary props to pre tag wrapping code.
— https://github.com/react-syntax-highlighter/react-syntax-highlighter/tree/efc3f7b7537d1729193b7a472067bcbe6cbecaf1#props
Could be removed too, okay with me. But that can be a different PR!
| /> | ||
| ) : ( | ||
| <code className={className} {...props}> | ||
| <code {...props} className={className}> |
There was a problem hiding this comment.
The order doesn't matter here.
There was a problem hiding this comment.
true, but its not bad to be consistent with the other example!
ChristianMurphy
approved these changes
Apr 6, 2023
wooorm
approved these changes
Apr 6, 2023
This comment has been minimized.
This comment has been minimized.
diegohaz
referenced
this pull request
in ariakit/ariakit
Apr 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-markdown](https://togithub.com/remarkjs/react-markdown) | [`8.0.6` -> `8.0.7`](https://renovatebot.com/diffs/npm/react-markdown/8.0.6/8.0.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>remarkjs/react-markdown</summary> ### [`v8.0.7`](https://togithub.com/remarkjs/react-markdown/releases/tag/8.0.7) [Compare Source](https://togithub.com/remarkjs/react-markdown/compare/8.0.6...8.0.7) ##### Perf - [`c289176`](https://togithub.com/remarkjs/react-markdown/commit/c289176) Fix performance for keys by [@​wooorm](https://togithub.com/wooorm) in [https://github.com/remarkjs/react-markdown/pull/738](https://togithub.com/remarkjs/react-markdown/pull/738) ##### Docs - [`9034dbd`](https://togithub.com/remarkjs/react-markdown/commit/9034dbd) Fix types in syntax highlight example by [@​dlqqq](https://togithub.com/dlqqq) in [https://github.com/remarkjs/react-markdown/pull/736](https://togithub.com/remarkjs/react-markdown/pull/736) **Full Changelog**: remarkjs/react-markdown@8.0.6...8.0.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
tompluess
referenced
this pull request
in tompluess/tompluess-gatsby
Apr 14, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [core-js](https://togithub.com/zloirock/core-js) | [`3.30.0` -> `3.30.1`](https://renovatebot.com/diffs/npm/core-js/3.30.0/3.30.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [react-markdown](https://togithub.com/remarkjs/react-markdown) | [`8.0.6` -> `8.0.7`](https://renovatebot.com/diffs/npm/react-markdown/8.0.6/8.0.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>zloirock/core-js</summary> ### [`v3.30.1`](https://togithub.com/zloirock/core-js/blob/HEAD/CHANGELOG.md#​3301---20230414-httpsgithubcomzloirockcore-jsreleasestagv3301) [Compare Source](https://togithub.com/zloirock/core-js/compare/v3.30.0...v3.30.1) - Added a fix for a NodeJS 19.9.0 `URL.canParse` [bug](https://togithub.com/nodejs/node/issues/47505) - Compat data improvements: - [`JSON.parse` source text access proposal](https://togithub.com/tc39/proposal-json-parse-with-source) features marked as [supported](https://chromestatus.com/feature/5121582673428480) from V8 ~ Chrome 114 - [`ArrayBuffer.prototype.transfer` and friends proposal](https://togithub.com/tc39/proposal-arraybuffer-transfer) features marked as [supported](https://chromestatus.com/feature/5073244152922112) from V8 ~ Chrome 114 - [`URLSearchParams.prototype.size`](https://togithub.com/whatwg/url/pull/734) marked as supported from V8 ~ Chrome 113 </details> <details> <summary>remarkjs/react-markdown</summary> ### [`v8.0.7`](https://togithub.com/remarkjs/react-markdown/releases/tag/8.0.7) [Compare Source](https://togithub.com/remarkjs/react-markdown/compare/8.0.6...8.0.7) ##### Perf - [`c289176`](https://togithub.com/remarkjs/react-markdown/commit/c289176) Fix performance for keys by [@​wooorm](https://togithub.com/wooorm) in [https://github.com/remarkjs/react-markdown/pull/738](https://togithub.com/remarkjs/react-markdown/pull/738) ##### Docs - [`9034dbd`](https://togithub.com/remarkjs/react-markdown/commit/9034dbd) Fix types in syntax highlight example by [@​dlqqq](https://togithub.com/dlqqq) in [https://github.com/remarkjs/react-markdown/pull/736](https://togithub.com/remarkjs/react-markdown/pull/736) **Full Changelog**: remarkjs/react-markdown@8.0.6...8.0.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/tompluess/tompluess). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9-->
renovate bot
referenced
this pull request
in Unleash/unleash
Apr 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-markdown](https://togithub.com/remarkjs/react-markdown) | [`8.0.4` -> `8.0.7`](https://renovatebot.com/diffs/npm/react-markdown/8.0.4/8.0.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>remarkjs/react-markdown</summary> ### [`v8.0.7`](https://togithub.com/remarkjs/react-markdown/releases/tag/8.0.7) [Compare Source](https://togithub.com/remarkjs/react-markdown/compare/8.0.6...8.0.7) ##### Perf - [`c289176`](https://togithub.com/remarkjs/react-markdown/commit/c289176) Fix performance for keys by [@​wooorm](https://togithub.com/wooorm) in [https://github.com/remarkjs/react-markdown/pull/738](https://togithub.com/remarkjs/react-markdown/pull/738) ##### Docs - [`9034dbd`](https://togithub.com/remarkjs/react-markdown/commit/9034dbd) Fix types in syntax highlight example by [@​dlqqq](https://togithub.com/dlqqq) in [https://github.com/remarkjs/react-markdown/pull/736](https://togithub.com/remarkjs/react-markdown/pull/736) **Full Changelog**: remarkjs/react-markdown@8.0.6...8.0.7 ### [`v8.0.6`](https://togithub.com/remarkjs/react-markdown/blob/HEAD/changelog.md#​806---2023-03-20) [Compare Source](https://togithub.com/remarkjs/react-markdown/compare/8.0.5...8.0.6) - [`33ab015`](https://togithub.com/remarkjs/react-markdown/commit/33ab015) Update to TS 5\ by [**@​Methuselah96**](https://togithub.com/Methuselah96) in [#​734](https://togithub.com/remarkjs/react-markdown/issues/734) ### [`v8.0.5`](https://togithub.com/remarkjs/react-markdown/blob/HEAD/changelog.md#​805---2023-01-17) [Compare Source](https://togithub.com/remarkjs/react-markdown/compare/8.0.4...8.0.5) - [`d640d40`](https://togithub.com/remarkjs/react-markdown/commit/d640d40) Update to use `node16` module resolution in `tsconfig.json`\ by [**@​ChristianMurphy**](https://togithub.com/ChristianMurphy) in [#​723](https://togithub.com/remarkjs/react-markdown/pull/723) - [`402fea3`](https://togithub.com/remarkjs/react-markdown/commit/402fea3) Fix typo in `plugins` deprecation message\ by [**@​marc2332**](https://togithub.com/marc2332) in [#​719](https://togithub.com/remarkjs/react-markdown/pull/719) - [`4f98f73`](https://togithub.com/remarkjs/react-markdown/commit/4f98f73) Remove deprecated and unneeded `defaultProps`\ by [**@​Lepozepo**](https://togithub.com/Lepozepo) in [#​718](https://togithub.com/remarkjs/react-markdown/pull/718) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTYuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Improves README syntax highlighting example. The current example produces a TypeScript error by default. See here: react-syntax-highlighter/react-syntax-highlighter#479 (comment)