Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic filter tags #113

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Generic filter tags #113

merged 2 commits into from
Feb 25, 2025

Conversation

leo-lox
Copy link
Contributor

@leo-lox leo-lox commented Feb 15, 2025

fixes #73
fixes #118

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.83%. Comparing base (d925e77) to head (81d7ea9).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   72.49%   72.83%   +0.34%     
==========================================
  Files         106      106              
  Lines        3537     3545       +8     
==========================================
+ Hits         2564     2582      +18     
+ Misses        973      963      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@v0l v0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be merged soon? I need this feature

@v0l v0l mentioned this pull request Feb 24, 2025
@frnandu frnandu marked this pull request as ready for review February 24, 2025 22:50
@frnandu frnandu changed the title proposal: arbitraryTags Generic filter tags Feb 24, 2025
@frnandu frnandu merged commit a6f003e into master Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add K tag support Rethink Filter tags implementation
3 participants