Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts #109

Merged
merged 9 commits into from
Feb 10, 2025
Merged

Accounts #109

merged 9 commits into from
Feb 10, 2025

Conversation

frnandu
Copy link
Collaborator

@frnandu frnandu commented Feb 8, 2025

fixes #106

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 35.65217% with 74 lines in your changes missing coverage. Please review.

Project coverage is 57.13%. Comparing base (ba6d96b) to head (36a5a88).

Files with missing lines Patch % Lines
...k/lib/domain_layer/usecases/accounts/accounts.dart 34.04% 31 Missing ⚠️
...ges/ndk/lib/domain_layer/usecases/lists/lists.dart 0.00% 20 Missing ⚠️
...er/usecases/user_relay_lists/user_relay_lists.dart 0.00% 6 Missing ⚠️
...s/ndk/lib/domain_layer/usecases/files/blossom.dart 69.23% 4 Missing ⚠️
...layer/usecases/files/blossom_user_server_list.dart 0.00% 4 Missing ⚠️
...lib/domain_layer/usecases/metadatas/metadatas.dart 0.00% 4 Missing ⚠️
...ndk/lib/domain_layer/usecases/follows/follows.dart 0.00% 3 Missing ⚠️
...lib/domain_layer/usecases/broadcast/broadcast.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   57.43%   57.13%   -0.31%     
==========================================
  Files         109      111       +2     
  Lines        3597     3653      +56     
==========================================
+ Hits         2066     2087      +21     
- Misses       1531     1566      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frnandu frnandu marked this pull request as ready for review February 9, 2025 10:41
@frnandu frnandu requested a review from leo-lox February 9, 2025 10:41
Copy link
Contributor

@leo-lox leo-lox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I like the pubkey in accounts, so we dont need to call .getPublickKey() on the signer all the time
  • maybe something for the future, persist accounts. Dont know if its possible with external signers. But we should mention in the docs that its only for the current session

@leo-lox
Copy link
Contributor

leo-lox commented Feb 10, 2025

organized and exposed the api, if you are fine with this we can merge

@frnandu frnandu merged commit 43cb434 into master Feb 10, 2025
1 check passed
@frnandu frnandu added this to the 0.3 milestone Feb 10, 2025
@frnandu frnandu deleted the feat-accounts branch February 12, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign signer and reconfigure
2 participants