Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrap the uint! macro to allow usage without needing uint import #351

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

DaniPopes
Copy link
Contributor

Motivation

Closes #307

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 93.90244% with 5 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@5574ebb). Click here to learn what that means.

Files Patch % Lines
ruint-macro/src/lib.rs 92.64% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage        ?   79.25%           
=======================================
  Files           ?       55           
  Lines           ?     5572           
  Branches        ?        0           
=======================================
  Hits            ?     4416           
  Misses          ?     1156           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaniPopes
Copy link
Contributor Author

Remaining failures addressed in #350

Comment on lines +186 to +188
fn new(ruint_crate: Option<TokenStream>) -> Self {
Self {
ruint_crate: ruint_crate.unwrap_or_else(|| "::ruint".parse().unwrap()),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@prestwich prestwich merged commit 4f2b31d into recmo:main Feb 25, 2024
20 checks passed
@DaniPopes DaniPopes deleted the macro-dollar-crate branch February 26, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current macro definition is not easily re-exportable
3 participants