Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use_native_modules! warns and skips dependencies without a podspec #507

Merged
merged 2 commits into from
Jul 9, 2019
Merged

fix: use_native_modules! warns and skips dependencies without a podspec #507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae82c6
fix: use_native_modules! displays a descriptive warning and then skip…
Jul 8, 2019
465af30
fix: use_native_modules! includes a suggested action to disable autol…
Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/platform-ios/native_modules.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,18 @@ def use_native_modules!(root = "..", packages = nil)
next unless package_config = package["platforms"]["ios"]

podspec_path = package_config["podspecPath"]

# Add a warning to the queue and continue to the next dependency if the podspec_path is nil/empty
if podspec_path.nil? || podspec_path.empty?
Pod::UI.warn("use_native_modules! skipped the react-native dependency '#{package["name"]}'. No podspec file was found.",
[
"Check to see if there is an updated version that contains the necessary podspec file",
"Contact the library maintainers or send them a PR to add a podspec. The react-native-webview podspec is a good example of a package.json driven podspec. See https://github.com/react-native-community/react-native-webview/blob/master/react-native-webview.podspec",
"If necessary, you can disable autolinking for the dependency and link it manually. See https://github.com/react-native-community/cli/blob/master/docs/autolinking.md#how-can-i-disable-autolinking-for-unsupported-library"
])
end
next if podspec_path.nil? || podspec_path.empty?

spec = Pod::Specification.from_file(podspec_path)

# We want to do a look up inside the current CocoaPods target
Expand Down