feat: replace ios-deploy with devicectl #2614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
ios-deploy
with Apple's supportedxcrun devicectl
:#2610
Test Plan
We will be testing two cli commands:
doctor
andrun-ios
.Setup
First, check out the
feature/remove-ios-deploy
from the fork and link the packages.In your react native project, link the packages. Here's how I did it:
Testing
cd /my/new/react-native/project/
✅ The ios-deploy check no longer appears in the diagnostic output.
Run the command twice, once for a simulator and then a device.
✅ The app installs and launches successfully.
Tear down
cd /my/new/react-native/project/ yarn unlink @react-native-community/cli-platform-apple yarn unlink @react-native-community/cli-doctor yarn install --force
Console snippet for installing and launching on device
Launching on a device works even on WiFI!
Checklist
react-native
checkout (instructions).