breaking: Replace launchEditor implementation #2587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replace the custom implementation of
launchEditor
in thecli-tools
package with a call to launch-editor.Why launch-editor?
Test Plan:
yarn build
.@react-native-community/cli-tools
and@react-native-community/cli-server-api
into a local checkout ofreact-native
viayarn link
.Screen.Recording.2025-01-29.at.13.01.33.mov
✅ RedBox is rendered with stack trace
✅ Tapping item in component stack opens in my active editor (VS Code)
✅ Assert new code is called with temp console log
Checklist