Add support for Quart #25
Conversation
|
@rayluo For your review. Happy to add docs/tests as needed. Would like this for Build sample. |
|
Could also make a base class for Flask/Quart. |
There was a problem hiding this comment.
Thank you very much for taking the first cut, @pamelafox ! It is amazing to see it took minimal effort to have one more framework supported!
Could also make a base class for Flask/Quart.
In this particular case, it seems only the constructor and the logout() helper can be put into a base class, yet the majority of the logic are duplicated. In general, I do not know a satisfied way to maintain a similar sync and async code base with minimal code duplication. Please enlighten me how you are going to approach this.
Happy to add docs/tests as needed. Would like this for Build sample.
I can keep this PR for a couple more days if you plan to add docs/tests. Alternatively, it is totally fine to merge this as-is to meet your deadline, and we can add docs afterwards in the near future. Just let me know.
|
I have added tests and docs, please take a look. |
|
Changes addressed |
|
Woot! Thanks for the speedy review and merge. |
Quart is the async version of Flask. This PR adds support by cloning the Flask file, adding async/await as needed, and changing the required extra. Notably Quart-Session doesnt support filesystem, so I'm using redis. This is working in my test sample.