Updated core to 1.0.0-beta.14 (fixes number parsing and issue #245) #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bianchimro
requested review from
giorgiouboldi,
iosonosempreio,
mikima and
uf0
mikima
requested changes
Mar 2, 2021
There was a problem hiding this comment.
sorry for the duplicate comment.
Decimal separator is working, but not thousands separator, see the screenshoot.
Furthermore, since by default the cell separator is comma AND the default thousand separator is comma it creates unexpected behaviuors.
Below the screenshoot and test dataset.
test_us
10.44
76.33
2,923
1,045,442.22
1,23
|
hi @mikima i updated the pull request with thousands separator = "," the last number should not be parsed (we need 3 digits after thousands separator) |
|
@bianchimro yes the last one was intentionally an error to check how errors are handled. i'll test asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issues with number parsing (with specified separators and parsing options)