Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Address and ens names cut off in send flow on Android #6461

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Feb 19, 2025

Fixes APP-2323

What changed (plus any additional context for devs)

Fixes a few row height issues and a few text spacing issues I noticed on Android. Nothing major

Screen recordings / screenshots

Screenshot_20250219-134651
Screenshot_20250219-134659
Screenshot_20250220-112425
Screenshot_20250220-112429

What to test

n/a

@walmat walmat requested review from derHowie and maxbbb February 19, 2025 18:51
Copy link

linear bot commented Feb 19, 2025

@brunobar79
Copy link
Member

Launch in simulator or device for c100d2c

@brunobar79
Copy link
Member

Launch in simulator or device for 79a33a8

@ibrahimtaveras00 ibrahimtaveras00 self-requested a review February 20, 2025 18:25
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on my Google Pixel 5 and all looks good, QA Passed 👍🏽

@walmat walmat merged commit fd24487 into develop Feb 28, 2025
8 checks passed
@walmat walmat deleted the @matthew/APP-2323 branch February 28, 2025 20:45
BrodyHughes pushed a commit that referenced this pull request Mar 3, 2025
* fix spacing on android text and adjust row height

* couple more text alignment fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants