Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet error alert to swaps flow #6398

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Add wallet error alert to swaps flow #6398

merged 1 commit into from
Jan 14, 2025

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Jan 13, 2025

Fixes APP-2254

What changed (plus any additional context for devs)

1. Swap Provider Enhancement

Error Handling

  • Added showWalletErrorAlert helper function import
  • Implemented wallet error alert when wallet is not available during swap
  • Maintained existing error feedback (haptic notification)

Code Organization

  • Added error handling in swap provider's wallet check
  • Integrated with existing haptics feedback system
  • Improved user feedback for wallet-related errors

2. Support Helper Integration

Alert Implementation

  • Utilized centralized showWalletErrorAlert from support helpers
  • Standardized wallet error messaging across the app
  • Improved error handling consistency

User Experience

  • Added clear error messaging for wallet-related issues
  • Maintained haptic feedback for error states
  • Improved user guidance during error scenarios

3. Code Structure Improvements

Dependencies

  • Added new import for support helper
  • Maintained existing haptics implementation
  • Integrated with existing swap provider logic

This PR improves error handling in the swap flow by adding standardized wallet error alerts, providing better user feedback while maintaining existing error handling patterns.

Screen recordings / screenshots

n/a

What to test

damaged wallet state trying to swap

@walmat walmat requested review from derHowie and maxbbb January 13, 2025 16:41
@brunobar79
Copy link
Member

Launch in simulator or device for cbf8005

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed your commit message. Had this been overwritten recently? Might be good to highlight if we're creating extra work for you 😓

@walmat walmat merged commit 95cb25e into develop Jan 14, 2025
8 checks passed
@walmat walmat deleted the @matthew/APP-2254 branch January 14, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants