Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid use of NextMethod() in .DollarNames.R6() #299

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Avoid use of NextMethod() in .DollarNames.R6() #299

merged 3 commits into from
Feb 14, 2025
+37 −2

Conversation

wch
Copy link
Member

@wch wch commented Feb 14, 2025

Fixes #298.

In the RStudio IDE prior to this PR, it essentially called .DollarNames.R6 directly, and so the call to NextMethod() would throw an error.

This PR makes it so we avoid NextMethod() entirely.

@wch wch requested a review from gaborcsardi as a code owner February 14, 2025 20:56
@wch wch requested review from hadley and kevinushey February 14, 2025 20:57
@wch wch mentioned this pull request Feb 14, 2025
Merged
4 tasks
hadley
hadley approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add a couple of tests?

@wch wch merged commit 4c9ddd4 into main Feb 14, 2025
1 check passed
@wch wch deleted the fix-dollarnames-rstudio branch February 14, 2025 21:12
@maciekbanas maciekbanas mentioned this pull request Feb 18, 2025
Closed
@wch wch mentioned this pull request Mar 10, 2025
Closed
@vladimirobucina vladimirobucina mentioned this pull request Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

@gaborcsardi gaborcsardi Awaiting requested review from gaborcsardi gaborcsardi is a code owner

@kevinushey kevinushey Awaiting requested review from kevinushey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in NextMethod() : generic function not specified
2 participants
@wch @hadley