Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove requires-python from build-system table #105

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

wheelsandmetal
Copy link
Contributor

This key belongs in the project table which isn't defined.

https://packaging.python.org/en/latest/specifications/pyproject-toml/#declaring-project-metadata-the-project-table

Was running into

    - Installing qcore (1.10.1): Failed

  BuildSystemTableValidationError

  Failed to validate `build-system` in pyproject.toml: Unknown properties: requires-python

  at /opt/homebrew/Cellar/poetry/1.8.3_2/libexec/lib/python3.12/site-packages/build/_builder.py:113 in _parse_build_system_table
      109│
      110│     unknown_props = build_system_table.keys() - {'requires', 'build-backend', 'backend-path'}
      111│     if unknown_props:
      112│         msg = f'Unknown properties: {", ".join(unknown_props)}'
    → 113│         raise BuildSystemTableValidationError(msg)
      114│
      115│     return build_system_table
      116│
      117│

Cannot install qcore.

when installing pyanalyze with poetry.

@JelleZijlstra
Copy link
Contributor

Thanks, could you move it to a new [project] table instead?

Having `requires-paython` in the build-system table creates errors on install
@wheelsandmetal wheelsandmetal force-pushed the pyproject-python-requires branch from 3ec0420 to 8d8c9b5 Compare August 27, 2024 09:04
@JelleZijlstra JelleZijlstra merged commit 7e5b841 into quora:master Aug 27, 2024
9 of 10 checks passed
@wheelsandmetal wheelsandmetal deleted the pyproject-python-requires branch August 28, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants