Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of discovery errors #24

Merged
merged 8 commits into from
Dec 3, 2017
Merged

Fix handling of discovery errors #24

merged 8 commits into from
Dec 3, 2017

Conversation

SpComb
Copy link
Member

@SpComb SpComb commented Dec 3, 2017

See #22

  • Change discovery:Discovery.receiver to just log Packet.unpack errors caused by invalid response packets, instead of shutting down the entire discovery with an error

  • Improve the discovery:Packet.unpack error reporting

    2017/12/03 16:46:43 Discovery.receiver: received invalid packet from 127.0.0.1:40961: Invalid field: []byte{0x66, 0x6f, 0x6f}
    
  • Add tests for the discovery package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant