-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change project style disabling from being a project load flag to a new project "capability" #49266
Conversation
Ping @dmarteau -- can you test if this fixes your server performance regression please? |
Thanks @nyalldawson @dmarteau will test it |
Hi, thx for the fix, I'm trying to test the branch but I cannot figure how to pass '0' in python as capabilities value. I'm stuck with the error |
@dmarteau use the flags constructor
|
@nyalldawson Tests are now ok, From simple loading test I benchmarked approx 200ms for initialising Benchmarks on other server tests have improved with the same ratio. Thanks for the job ! |
to a new project "capability" This avoids the unwanted cost of initialising a blank style database whenever QgsProject::clear is called and project styles are not required (eg. for server)
b2e7e62
to
fa7d424
Compare
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_26 release-3_26
# Navigate to the new working tree
cd .worktrees/backport-release-3_26
# Create a new branch
git switch --create backport-49266-to-release-3_26
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick fa7d424e692de536426caf719591692bb9ab769f
# Push it to GitHub
git push --set-upstream origin backport-49266-to-release-3_26
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_26 Then, create a pull request where the |
This avoids the unwanted cost of initialising a blank style database
whenever QgsProject::clear is called and project styles are not
required (eg. for server)
Hopefully fixes regression in server project load times