Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in vrf_verify_extra #2412

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Fix panic in vrf_verify_extra #2412

merged 4 commits into from
Mar 21, 2025

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Mar 21, 2025

Referenced issues

https://github.com/qdrvm/KAGOME-audit/issues/48#issuecomment-2740590573
Should be merged after qdrvm/kagome-crates#9

Description of the Change

  • Updates kagome-crates with version where sr25519_vrf_verify_extra does not panic when invalid public key is provided
  • Adds test with garbage signature that is not panicking anymore

Possible Drawbacks

None

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

@kamilsa kamilsa marked this pull request as ready for review March 21, 2025 11:41
@kamilsa kamilsa requested review from iceseer and turuslan March 21, 2025 11:45
@kamilsa kamilsa enabled auto-merge (squash) March 21, 2025 12:00
@kamilsa kamilsa merged commit 74ce10b into master Mar 21, 2025
13 checks passed
@kamilsa kamilsa deleted the fix/panic-vrf-verify-extra branch March 21, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants