Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure joblogs storage (PR #34) #48

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

vlerkin
Copy link
Collaborator

@vlerkin vlerkin commented Jan 23, 2025

adjust k8s yaml to provide a path for logs file generated by the jobogs feature; create an fsGroup to allow writing to the provided directory, adjust PVC manifest; alter cofig.md file by deleting a clause about /tmp dir since we have an appropriate security context now

…ogs feature; create an fsGroup to allow writing to the provided directory, adjust PVC manifest; alter cofig.md file by deleting a clause about /tmp dir since we have an appropriate security context now
@vlerkin vlerkin requested a review from wvengen January 24, 2025 08:17
Copy link
Member

@wvengen wvengen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Some small notes, great to see that it was that simple.

… PVC is enough to mount a PV; adjusted config.md to contain info about securityContext
@wvengen wvengen merged commit ad8f7bc into q-m:main Jan 24, 2025
5 checks passed
@wvengen wvengen mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants