Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

668 joblogs #41

Merged
merged 11 commits into from
Nov 28, 2024
Merged

668 joblogs #41

merged 11 commits into from
Nov 28, 2024

Conversation

vlerkin
Copy link
Collaborator

@vlerkin vlerkin commented Nov 26, 2024 •
edited
Loading

Minor changes for the observer:

  1. Adjusted timeout_seconds parameter (used to establish long-lived connection to the k8s api) to 300 sec instead of 0 so it resets the connection every 300 sec instead of keeping it alive constantly, this behavior can trigger proxies to close idle connections after a certain timeout they have.
  2. Add thread safety for subscribe, unsubscribe and notify_subscribers methods to avoid race conditions.

@vlerkin vlerkin requested a review from wvengen November 26, 2024 10:01
@wvengen
Copy link
Member

wvengen commented Nov 26, 2024

Great! Can you please rebase this on main? Then ready to merge.

vlerkin and others added 10 commits November 26, 2024 11:30
@vlerkin
remove limited reconnection attempts; cap backoff time with 15 min; c…
dfc939b 
…onfigure logs in a separate file logging_config.py that is imported to the __main__.py to trigger logs configuration before other modules inheret it; add debug logs to the watcher to better monitor each step
@vlerkin
refactor code to make config import and logging configuration separat…
f472580 
…e modules; implement logging to be configured globally but keep separate logger for each module; add level for logging to be configurable in the config file
@vlerkin
change level to INFO in config instead of DEBUG to make it less confu…
19bfc19 
…sing for users
@vlerkin
remove lines to configure the logging level
4761f26
@vlerkin
add logging.getLevelName() method to be used instead of creating a di…
8792063 
…ct with all available logging level to validate user input from the config file
@vlerkin
move logging configuration to the api.py; move config loading to the …
7609bb6 
…api.py; keep logging_config file
@vlerkin
rename logging_level to log_level
4e0405c
@vlerkin
remove redundant check of the log_level in the logging_config.py
82c55e2
@wvengen @vlerkin
Small changes
d47c9e8
@vlerkin
change timeout_seconds parameter for k8s api connection from 0 to 300…
d274cac 
… to reset the connection periodically; add lock for events like subscibe, unsubscribe and event dispatching
@wvengen wvengen merged commit a857ae5 into q-m:main Nov 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvengen wvengen wvengen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlerkin @wvengen