Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28 persistent logs #35

Merged
merged 13 commits into from
Nov 4, 2024
Merged

28 persistent logs #35

merged 13 commits into from
Nov 4, 2024

Conversation

vlerkin
Copy link
Collaborator

@vlerkin vlerkin commented Nov 4, 2024

Changed object_exists method to check if at least one object with partial name (job id) exists in the object storage instead of matching the whole name (which is problematic due to a random variable part of the file name.

@wvengen
Copy link
Member

wvengen commented Nov 4, 2024

Thanks for your PR!
Can you please describe what case this solves? Why does this need to be changed?

@vlerkin
Copy link
Collaborator Author

vlerkin commented Nov 4, 2024

The situation: names of the log files were changed to random, the new format is jobID_logs_randomComponent. The problem with the random file names is that part of the logic that checks if a file was already uploaded to the object storage does not work properly for this situation, so the new logic that accommodates variable component in the file name was implemented. The new logic inside object_exists method checks if a list of objects with a particular partly name (job ID) exists in the storage.

@wvengen
Copy link
Member

wvengen commented Nov 4, 2024

Thanks for explaining 👍
(it's helpful if changes are not only understandable to those currently working on the code, but also in retrospect by others)

@wvengen wvengen merged commit 5f91165 into q-m:main Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants