-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
28 persistent logs #35
Conversation
…ting instance of the Config class
… not work for docker; refactored code to address minor changes
…otes in all logging statements; refactor to single False statement in object exists
Thanks for your PR! |
The situation: names of the log files were changed to random, the new format is jobID_logs_randomComponent. The problem with the random file names is that part of the logic that checks if a file was already uploaded to the object storage does not work properly for this situation, so the new logic that accommodates variable component in the file name was implemented. The new logic inside object_exists method checks if a list of objects with a particular partly name (job ID) exists in the storage. |
Thanks for explaining 👍 |
Changed object_exists method to check if at least one object with partial name (job id) exists in the object storage instead of matching the whole name (which is problematic due to a random variable part of the file name.