refactored /daemonstatus #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of pending, running and finished jobs, tested that it shows the actual load
wvengen
reviewed
Sep 17, 2024
…ved node_name to the return statement
|
Not sure why the test is failing now, but would be good to look into. |
|
Restarted the test, and is fine. Hope this happens too often 👍 |
|
Ah, good one, about the iterator! Didn't realise it either when reading ⭕ |
|
Ah, please mention the issue number when opening a PR :) #23 here (And as a sidenote, we could also make a list of just the state, not requiring the whole objects in memory; but I'm not sure if that improves the code (readability), I was happy to merge it as it is.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored /daemonstatus to contain node_name, status and the number of pending, running and finished jobs, tested that it shows the actual load