-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Tree make node fix #2839
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2839
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 27 PendingAs of commit 10981d4 with merge base 73c7b0a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @kurtamohler
@rolo you just need to run the linter |
Done. Apologies. I did see them flagged, but as they were in unrelated files I thought I should leave them. |
(cherry picked from commit ba8be9c)
(cherry picked from commit ba8be9c)
Description
Calling Tree.make_node was resulting in
TypeError: Tree.__init__() got an unexpected keyword argument 'node'.
It looks as though it's because of a kwarg being passed as "node" instead of "node_data" at the end of the function so I renamed it. I added some tests to show this but it seemed a bit over the top to keep 3 separate tests for such a small thing so I combined them afterwards.
Types of changes
Checklist
Thanks :)