Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Tree make node fix #2839

Merged
merged 4 commits into from
Mar 7, 2025
Merged

[BugFix] Tree make node fix #2839

merged 4 commits into from
Mar 7, 2025

Conversation

rolo
Copy link
Contributor

@rolo rolo commented Mar 7, 2025

Description

Calling Tree.make_node was resulting in TypeError: Tree.__init__() got an unexpected keyword argument 'node'.

It looks as though it's because of a kwarg being passed as "node" instead of "node_data" at the end of the function so I renamed it. I added some tests to show this but it seemed a bit over the top to keep 3 separate tests for such a small thing so I combined them afterwards.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Thanks :)

Copy link

pytorch-bot bot commented Mar 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2839

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 27 Pending

As of commit 10981d4 with merge base 73c7b0a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@vmoens vmoens added the bug Something isn't working label Mar 7, 2025
@vmoens vmoens changed the title Tree make node fix [BugFix] Tree make node fix Mar 7, 2025
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc @kurtamohler

@vmoens
Copy link
Contributor

vmoens commented Mar 7, 2025

@rolo
Copy link
Contributor Author

rolo commented Mar 7, 2025

@rolo you just need to run the linter https://github.com/pytorch/rl/blob/main/CONTRIBUTING.md

Done.

Apologies. I did see them flagged, but as they were in unrelated files I thought I should leave them.

@vmoens vmoens merged commit ba8be9c into pytorch:main Mar 7, 2025
56 of 62 checks passed
vmoens pushed a commit that referenced this pull request Mar 8, 2025
(cherry picked from commit ba8be9c)
vmoens pushed a commit that referenced this pull request Mar 10, 2025
(cherry picked from commit ba8be9c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants