Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix collector with no buffers and devices #2809

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 24, 2025

[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 24, 2025
ghstack-source-id: 89bc0dfa175079c88045408dc173a55488b606c6
Pull Request resolved: #2809
Copy link

pytorch-bot bot commented Feb 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2809

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Unrelated Failures

As of commit 720f8fb with merge base 3acf491 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 24, 2025
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 24, 2025
ghstack-source-id: d289abe123434f6ba6c088ae98d7e7c7d8df9a1c
Pull Request resolved: #2809
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 24, 2025
ghstack-source-id: 593002ddcb8532e719210e06e89d83a815f395d2
Pull Request resolved: #2809
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 24, 2025
ghstack-source-id: 968212ab7271a9d17cd978e6eba7011b5dcb6d6f
Pull Request resolved: #2809
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Feb 24, 2025
ghstack-source-id: 5367df9fcfdf549108be852476b049a0b978e348
Pull Request resolved: #2809
@vmoens vmoens merged commit 720f8fb into gh/vmoens/92/base Feb 24, 2025
71 of 76 checks passed
@vmoens vmoens deleted the gh/vmoens/92/head branch February 24, 2025 20:59
@vmoens vmoens added the bug Something isn't working label Feb 24, 2025
vmoens added a commit that referenced this pull request Mar 8, 2025
ghstack-source-id: 5367df9fcfdf549108be852476b049a0b978e348
Pull Request resolved: #2809

(cherry picked from commit d4f8846)
vmoens added a commit that referenced this pull request Mar 10, 2025
ghstack-source-id: 5367df9fcfdf549108be852476b049a0b978e348
Pull Request resolved: #2809

(cherry picked from commit d4f8846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants