[Feature] Consistent Dropout #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2399
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 8 Unrelated FailuresAs of commit 3231780 with merge base 6aa4b53 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vmoens
force-pushed
the
consistent-dropout
branch
from
da6c42e to
c1847be
Compare
|
I need to make a second pass over this but here's what I got running: from torchrl.modules import ConsistentDropoutModule, get_primers_from_module
from tensordict.nn import TensorDictModule as Mod, TensorDictSequential as Seq
import torch
from torchrl.envs import GymEnv
from tensordict import TensorDict
m = Seq(
Mod(torch.nn.Linear(3, 4), in_keys=["observation"], out_keys=["intermediate"]),
ConsistentDropoutModule(p=0.5, input_shape=(4,), in_keys="intermediate"),
Mod(torch.nn.Linear(4, 1), in_keys=["intermediate"], out_keys=["action"]),
)
primer = get_primers_from_module(m)
env = GymEnv("Pendulum-v1").append_transform(primer)
r = env.reset()
env.rollout(32, m)["next", "mask_13266468624"]With this you generate your mask during reset, such that it stays the same during execution. This works, but as you can see we need to change the size of the primer, which means that we won't be able to use the same primer with different envs: from torchrl.modules import ConsistentDropoutModule, get_primers_from_module
from tensordict.nn import TensorDictModule as Mod, TensorDictSequential as Seq
import torch
from torchrl.envs import GymEnv, SerialEnv, StepCounter
from tensordict import TensorDict
m = Seq(
Mod(torch.nn.Linear(3, 4), in_keys=["observation"], out_keys=["intermediate"]),
ConsistentDropoutModule(p=0.5, input_shape=(2, 4,), in_keys="intermediate"),
Mod(torch.nn.Linear(4, 1), in_keys=["intermediate"], out_keys=["action"]),
)
primer = get_primers_from_module(m)
env0 = GymEnv("Pendulum-v1").append_transform(StepCounter(5))
env1 = GymEnv("Pendulum-v1").append_transform(StepCounter(6))
env = SerialEnv(2, [lambda env=env0: env, lambda env=env1: env])
env = env.append_transform(primer)
r = env.reset()There should be a way to solve this though! |
…tent-dropout # Conflicts: # test/test_exploration.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces Consistent Dropout (Hausknecht & Wagener, 2022) to TorchRL.
Consists of the following changes:
ConsistentDropoutPyTorch moduleTensorDictModule:ConsistentDropoutModuleConsistentDropoutModuleMotivation and Context
Addresses a feature request.
Fleshes out a PR draft #1587.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!