Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix vecnorm state-dicts #2158

Merged
merged 3 commits into from
May 10, 2024
Merged

[BugFix] Fix vecnorm state-dicts #2158

merged 3 commits into from
May 10, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented May 10, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2158

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 6 Unrelated Failures

As of commit e1f3f30 with merge base 7befddc (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2024
@vmoens vmoens added the bug Something isn't working label May 10, 2024
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 53.9090ms 53.5898ms 18.6603 Ops/s 18.5993 Ops/s $\color{#35bf28}+0.33\%$
test_sync 46.7053ms 34.6744ms 28.8397 Ops/s 32.1275 Ops/s $\textbf{\color{#d91a1a}-10.23\%}$
test_async 51.4645ms 27.8027ms 35.9677 Ops/s 35.1418 Ops/s $\color{#35bf28}+2.35\%$
test_simple 0.3961s 0.3459s 2.8912 Ops/s 2.9445 Ops/s $\color{#d91a1a}-1.81\%$
test_transformed 0.5387s 0.4912s 2.0359 Ops/s 2.0457 Ops/s $\color{#d91a1a}-0.48\%$
test_serial 1.2561s 1.2076s 0.8281 Ops/s 0.8224 Ops/s $\color{#35bf28}+0.69\%$
test_parallel 1.0605s 1.0156s 0.9847 Ops/s 0.9891 Ops/s $\color{#d91a1a}-0.45\%$
test_step_mdp_speed[True-True-True-True-True] 70.0960μs 22.0891μs 45.2712 KOps/s 45.6389 KOps/s $\color{#d91a1a}-0.81\%$
test_step_mdp_speed[True-True-True-True-False] 36.0680μs 13.6192μs 73.4260 KOps/s 75.7007 KOps/s $\color{#d91a1a}-3.00\%$
test_step_mdp_speed[True-True-True-False-True] 33.4730μs 12.8802μs 77.6387 KOps/s 79.0509 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[True-True-True-False-False] 22.0010μs 7.9111μs 126.4040 KOps/s 130.2375 KOps/s $\color{#d91a1a}-2.94\%$
test_step_mdp_speed[True-True-False-True-True] 47.4290μs 23.5544μs 42.4550 KOps/s 43.6596 KOps/s $\color{#d91a1a}-2.76\%$
test_step_mdp_speed[True-True-False-True-False] 36.4790μs 14.8591μs 67.2987 KOps/s 68.7615 KOps/s $\color{#d91a1a}-2.13\%$
test_step_mdp_speed[True-True-False-False-True] 33.0620μs 14.2405μs 70.2223 KOps/s 72.4791 KOps/s $\color{#d91a1a}-3.11\%$
test_step_mdp_speed[True-True-False-False-False] 31.0280μs 9.1206μs 109.6422 KOps/s 111.5129 KOps/s $\color{#d91a1a}-1.68\%$
test_step_mdp_speed[True-False-True-True-True] 52.1580μs 24.7028μs 40.4812 KOps/s 41.2920 KOps/s $\color{#d91a1a}-1.96\%$
test_step_mdp_speed[True-False-True-True-False] 36.2080μs 16.2595μs 61.5025 KOps/s 62.6083 KOps/s $\color{#d91a1a}-1.77\%$
test_step_mdp_speed[True-False-True-False-True] 33.6430μs 14.2769μs 70.0432 KOps/s 72.3666 KOps/s $\color{#d91a1a}-3.21\%$
test_step_mdp_speed[True-False-True-False-False] 33.5230μs 9.2671μs 107.9091 KOps/s 112.2990 KOps/s $\color{#d91a1a}-3.91\%$
test_step_mdp_speed[True-False-False-True-True] 54.1610μs 25.9524μs 38.5321 KOps/s 39.1157 KOps/s $\color{#d91a1a}-1.49\%$
test_step_mdp_speed[True-False-False-True-False] 38.6020μs 17.3382μs 57.6762 KOps/s 58.9211 KOps/s $\color{#d91a1a}-2.11\%$
test_step_mdp_speed[True-False-False-False-True] 55.7150μs 15.4862μs 64.5736 KOps/s 66.3788 KOps/s $\color{#d91a1a}-2.72\%$
test_step_mdp_speed[True-False-False-False-False] 32.0100μs 10.4261μs 95.9128 KOps/s 98.2420 KOps/s $\color{#d91a1a}-2.37\%$
test_step_mdp_speed[False-True-True-True-True] 59.0310μs 24.7127μs 40.4650 KOps/s 41.3977 KOps/s $\color{#d91a1a}-2.25\%$
test_step_mdp_speed[False-True-True-True-False] 52.9190μs 16.3798μs 61.0507 KOps/s 62.7597 KOps/s $\color{#d91a1a}-2.72\%$
test_step_mdp_speed[False-True-True-False-True] 46.1960μs 16.5177μs 60.5410 KOps/s 62.3705 KOps/s $\color{#d91a1a}-2.93\%$
test_step_mdp_speed[False-True-True-False-False] 32.0700μs 10.5299μs 94.9680 KOps/s 98.4989 KOps/s $\color{#d91a1a}-3.58\%$
test_step_mdp_speed[False-True-False-True-True] 54.7420μs 26.1040μs 38.3084 KOps/s 39.3389 KOps/s $\color{#d91a1a}-2.62\%$
test_step_mdp_speed[False-True-False-True-False] 54.1610μs 17.4249μs 57.3891 KOps/s 58.9601 KOps/s $\color{#d91a1a}-2.66\%$
test_step_mdp_speed[False-True-False-False-True] 47.4290μs 17.6627μs 56.6166 KOps/s 58.0024 KOps/s $\color{#d91a1a}-2.39\%$
test_step_mdp_speed[False-True-False-False-False] 34.0550μs 11.6783μs 85.6290 KOps/s 89.0283 KOps/s $\color{#d91a1a}-3.82\%$
test_step_mdp_speed[False-False-True-True-True] 64.3910μs 27.6837μs 36.1224 KOps/s 37.1681 KOps/s $\color{#d91a1a}-2.81\%$
test_step_mdp_speed[False-False-True-True-False] 45.1950μs 18.7366μs 53.3714 KOps/s 54.5870 KOps/s $\color{#d91a1a}-2.23\%$
test_step_mdp_speed[False-False-True-False-True] 39.9950μs 17.8535μs 56.0113 KOps/s 58.4958 KOps/s $\color{#d91a1a}-4.25\%$
test_step_mdp_speed[False-False-True-False-False] 34.3540μs 11.7279μs 85.2666 KOps/s 89.3180 KOps/s $\color{#d91a1a}-4.54\%$
test_step_mdp_speed[False-False-False-True-True] 49.5130μs 28.9191μs 34.5792 KOps/s 35.8114 KOps/s $\color{#d91a1a}-3.44\%$
test_step_mdp_speed[False-False-False-True-False] 41.4580μs 20.0054μs 49.9864 KOps/s 51.9234 KOps/s $\color{#d91a1a}-3.73\%$
test_step_mdp_speed[False-False-False-False-True] 44.8840μs 18.7814μs 53.2441 KOps/s 54.7767 KOps/s $\color{#d91a1a}-2.80\%$
test_step_mdp_speed[False-False-False-False-False] 35.2260μs 12.7930μs 78.1680 KOps/s 80.3699 KOps/s $\color{#d91a1a}-2.74\%$
test_values[generalized_advantage_estimate-True-True] 10.9219ms 9.2311ms 108.3290 Ops/s 107.6290 Ops/s $\color{#35bf28}+0.65\%$
test_values[vec_generalized_advantage_estimate-True-True] 38.0030ms 35.2066ms 28.4037 Ops/s 30.2770 Ops/s $\textbf{\color{#d91a1a}-6.19\%}$
test_values[td0_return_estimate-False-False] 0.2226ms 0.1638ms 6.1053 KOps/s 5.9989 KOps/s $\color{#35bf28}+1.77\%$
test_values[td1_return_estimate-False-False] 25.9926ms 23.0158ms 43.4484 Ops/s 43.2325 Ops/s $\color{#35bf28}+0.50\%$
test_values[vec_td1_return_estimate-False-False] 38.0394ms 35.3176ms 28.3145 Ops/s 30.1928 Ops/s $\textbf{\color{#d91a1a}-6.22\%}$
test_values[td_lambda_return_estimate-True-False] 36.2957ms 33.5761ms 29.7831 Ops/s 29.5686 Ops/s $\color{#35bf28}+0.73\%$
test_values[vec_td_lambda_return_estimate-True-False] 38.1130ms 35.4192ms 28.2333 Ops/s 30.2422 Ops/s $\textbf{\color{#d91a1a}-6.64\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.3024ms 8.1847ms 122.1792 Ops/s 123.7250 Ops/s $\color{#d91a1a}-1.25\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.9388ms 1.8198ms 549.5161 Ops/s 497.9587 Ops/s $\textbf{\color{#35bf28}+10.35\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6414ms 0.3535ms 2.8286 KOps/s 2.8438 KOps/s $\color{#d91a1a}-0.53\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 51.4325ms 47.2771ms 21.1519 Ops/s 23.8385 Ops/s $\textbf{\color{#d91a1a}-11.27\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7130ms 3.0101ms 332.2149 Ops/s 330.3917 Ops/s $\color{#35bf28}+0.55\%$
test_dqn_speed 7.2219ms 1.3609ms 734.7955 Ops/s 741.9551 Ops/s $\color{#d91a1a}-0.96\%$
test_ddpg_speed 3.5590ms 2.8762ms 347.6855 Ops/s 347.6142 Ops/s $\color{#35bf28}+0.02\%$
test_sac_speed 9.6134ms 8.5062ms 117.5608 Ops/s 118.0649 Ops/s $\color{#d91a1a}-0.43\%$
test_redq_speed 14.3527ms 12.8928ms 77.5628 Ops/s 72.0833 Ops/s $\textbf{\color{#35bf28}+7.60\%}$
test_redq_deprec_speed 14.7019ms 13.1369ms 76.1214 Ops/s 76.1948 Ops/s $\color{#d91a1a}-0.10\%$
test_td3_speed 16.1376ms 8.4478ms 118.3744 Ops/s 118.4197 Ops/s $\color{#d91a1a}-0.04\%$
test_cql_speed 36.6580ms 36.0158ms 27.7656 Ops/s 27.4445 Ops/s $\color{#35bf28}+1.17\%$
test_a2c_speed 9.6706ms 7.6044ms 131.5032 Ops/s 134.9324 Ops/s $\color{#d91a1a}-2.54\%$
test_ppo_speed 8.9345ms 7.6075ms 131.4499 Ops/s 130.6174 Ops/s $\color{#35bf28}+0.64\%$
test_reinforce_speed 7.5042ms 6.5786ms 152.0071 Ops/s 151.2159 Ops/s $\color{#35bf28}+0.52\%$
test_iql_speed 33.9764ms 32.4513ms 30.8154 Ops/s 30.5752 Ops/s $\color{#35bf28}+0.79\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3468ms 2.0743ms 482.0836 Ops/s 481.6337 Ops/s $\color{#35bf28}+0.09\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5857ms 0.4915ms 2.0345 KOps/s 2.0131 KOps/s $\color{#35bf28}+1.06\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.5061ms 0.4710ms 2.1230 KOps/s 2.1188 KOps/s $\color{#35bf28}+0.20\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.4361ms 2.0773ms 481.3901 Ops/s 496.6177 Ops/s $\color{#d91a1a}-3.07\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8164ms 0.4875ms 2.0511 KOps/s 2.0485 KOps/s $\color{#35bf28}+0.13\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6659ms 0.4625ms 2.1623 KOps/s 2.1485 KOps/s $\color{#35bf28}+0.64\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.1030ms 1.2268ms 815.1097 Ops/s 806.4400 Ops/s $\color{#35bf28}+1.08\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.3387ms 1.1564ms 864.7660 Ops/s 855.3949 Ops/s $\color{#35bf28}+1.10\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2210ms 2.1843ms 457.8187 Ops/s 454.7406 Ops/s $\color{#35bf28}+0.68\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8615ms 0.6116ms 1.6351 KOps/s 1.6406 KOps/s $\color{#d91a1a}-0.33\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.7210ms 0.5888ms 1.6982 KOps/s 1.7102 KOps/s $\color{#d91a1a}-0.70\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3157ms 2.0770ms 481.4564 Ops/s 484.1780 Ops/s $\color{#d91a1a}-0.56\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5867ms 0.4934ms 2.0268 KOps/s 2.0053 KOps/s $\color{#35bf28}+1.07\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 3.3568ms 0.4741ms 2.1091 KOps/s 2.0850 KOps/s $\color{#35bf28}+1.16\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.3193ms 2.0563ms 486.3026 Ops/s 485.9841 Ops/s $\color{#35bf28}+0.07\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.1598ms 0.4906ms 2.0382 KOps/s 2.0388 KOps/s $\color{#d91a1a}-0.03\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6468ms 0.4637ms 2.1564 KOps/s 2.0987 KOps/s $\color{#35bf28}+2.75\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2645ms 2.1868ms 457.2945 Ops/s 460.7892 Ops/s $\color{#d91a1a}-0.76\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7720ms 0.6113ms 1.6358 KOps/s 1.6167 KOps/s $\color{#35bf28}+1.18\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 3.5968ms 0.5919ms 1.6895 KOps/s 1.7015 KOps/s $\color{#d91a1a}-0.70\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1078s 7.5613ms 132.2516 Ops/s 133.3863 Ops/s $\color{#d91a1a}-0.85\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.4406ms 12.2281ms 81.7788 Ops/s 79.6360 Ops/s $\color{#35bf28}+2.69\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.7083ms 1.0447ms 957.1709 Ops/s 911.3294 Ops/s $\textbf{\color{#35bf28}+5.03\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 98.1835ms 5.5027ms 181.7283 Ops/s 179.3745 Ops/s $\color{#35bf28}+1.31\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.3738ms 12.3406ms 81.0332 Ops/s 79.9487 Ops/s $\color{#35bf28}+1.36\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 3.4434ms 1.0860ms 920.7841 Ops/s 907.8852 Ops/s $\color{#35bf28}+1.42\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 99.9341ms 7.7025ms 129.8284 Ops/s 130.0783 Ops/s $\color{#d91a1a}-0.19\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 14.7068ms 12.5423ms 79.7299 Ops/s 77.4238 Ops/s $\color{#35bf28}+2.98\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.8291ms 1.3608ms 734.8469 Ops/s 688.2011 Ops/s $\textbf{\color{#35bf28}+6.78\%}$

@vmoens vmoens merged commit e77f0dd into main May 10, 2024
45 of 57 checks passed
@vmoens vmoens deleted the fix-vecnorm branch May 10, 2024 19:29
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}2$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1147s 0.1136s 8.8043 Ops/s 8.6548 Ops/s $\color{#35bf28}+1.73\%$
test_sync 99.9741ms 98.3240ms 10.1705 Ops/s 9.6968 Ops/s $\color{#35bf28}+4.88\%$
test_async 0.1957s 96.4748ms 10.3654 Ops/s 10.7585 Ops/s $\color{#d91a1a}-3.65\%$
test_single_pixels 0.1266s 0.1260s 7.9396 Ops/s 7.9676 Ops/s $\color{#d91a1a}-0.35\%$
test_sync_pixels 83.8222ms 80.0510ms 12.4920 Ops/s 12.0106 Ops/s $\color{#35bf28}+4.01\%$
test_async_pixels 0.1497s 77.2440ms 12.9460 Ops/s 12.7764 Ops/s $\color{#35bf28}+1.33\%$
test_simple 0.8227s 0.7653s 1.3067 Ops/s 1.3062 Ops/s $\color{#35bf28}+0.04\%$
test_transformed 1.0697s 1.0111s 0.9890 Ops/s 0.9870 Ops/s $\color{#35bf28}+0.21\%$
test_serial 2.4624s 2.4087s 0.4152 Ops/s 0.4127 Ops/s $\color{#35bf28}+0.60\%$
test_parallel 2.3514s 2.2946s 0.4358 Ops/s 0.4354 Ops/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[True-True-True-True-True] 0.1059ms 32.2716μs 30.9870 KOps/s 30.6848 KOps/s $\color{#35bf28}+0.98\%$
test_step_mdp_speed[True-True-True-True-False] 39.9610μs 19.3522μs 51.6738 KOps/s 50.6429 KOps/s $\color{#35bf28}+2.04\%$
test_step_mdp_speed[True-True-True-False-True] 43.1310μs 18.2183μs 54.8900 KOps/s 54.2170 KOps/s $\color{#35bf28}+1.24\%$
test_step_mdp_speed[True-True-True-False-False] 25.5100μs 10.9202μs 91.5732 KOps/s 89.9715 KOps/s $\color{#35bf28}+1.78\%$
test_step_mdp_speed[True-True-False-True-True] 60.0410μs 33.8791μs 29.5168 KOps/s 28.9785 KOps/s $\color{#35bf28}+1.86\%$
test_step_mdp_speed[True-True-False-True-False] 34.6220μs 20.8504μs 47.9607 KOps/s 47.7282 KOps/s $\color{#35bf28}+0.49\%$
test_step_mdp_speed[True-True-False-False-True] 39.5010μs 19.8984μs 50.2553 KOps/s 50.0712 KOps/s $\color{#35bf28}+0.37\%$
test_step_mdp_speed[True-True-False-False-False] 31.4510μs 12.8753μs 77.6678 KOps/s 78.2199 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[True-False-True-True-True] 53.7210μs 36.2348μs 27.5978 KOps/s 28.2271 KOps/s $\color{#d91a1a}-2.23\%$
test_step_mdp_speed[True-False-True-True-False] 47.6310μs 23.2117μs 43.0818 KOps/s 43.6290 KOps/s $\color{#d91a1a}-1.25\%$
test_step_mdp_speed[True-False-True-False-True] 37.3320μs 20.1473μs 49.6344 KOps/s 50.1717 KOps/s $\color{#d91a1a}-1.07\%$
test_step_mdp_speed[True-False-True-False-False] 28.7410μs 12.7010μs 78.7339 KOps/s 78.1113 KOps/s $\color{#35bf28}+0.80\%$
test_step_mdp_speed[True-False-False-True-True] 60.1900μs 37.1777μs 26.8978 KOps/s 26.6877 KOps/s $\color{#35bf28}+0.79\%$
test_step_mdp_speed[True-False-False-True-False] 44.6610μs 24.6261μs 40.6074 KOps/s 40.6812 KOps/s $\color{#d91a1a}-0.18\%$
test_step_mdp_speed[True-False-False-False-True] 70.9420μs 21.5536μs 46.3959 KOps/s 45.5287 KOps/s $\color{#35bf28}+1.90\%$
test_step_mdp_speed[True-False-False-False-False] 38.0500μs 14.7093μs 67.9841 KOps/s 67.8412 KOps/s $\color{#35bf28}+0.21\%$
test_step_mdp_speed[False-True-True-True-True] 57.1000μs 35.5377μs 28.1391 KOps/s 27.6437 KOps/s $\color{#35bf28}+1.79\%$
test_step_mdp_speed[False-True-True-True-False] 45.2910μs 23.2114μs 43.0822 KOps/s 43.4156 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[False-True-True-False-True] 50.5200μs 23.6036μs 42.3664 KOps/s 41.8817 KOps/s $\color{#35bf28}+1.16\%$
test_step_mdp_speed[False-True-True-False-False] 29.4100μs 14.6675μs 68.1779 KOps/s 68.5751 KOps/s $\color{#d91a1a}-0.58\%$
test_step_mdp_speed[False-True-False-True-True] 69.2720μs 37.3918μs 26.7439 KOps/s 26.5236 KOps/s $\color{#35bf28}+0.83\%$
test_step_mdp_speed[False-True-False-True-False] 48.8710μs 24.5202μs 40.7827 KOps/s 39.3698 KOps/s $\color{#35bf28}+3.59\%$
test_step_mdp_speed[False-True-False-False-True] 47.0300μs 25.1963μs 39.6883 KOps/s 38.9360 KOps/s $\color{#35bf28}+1.93\%$
test_step_mdp_speed[False-True-False-False-False] 31.5800μs 16.1752μs 61.8229 KOps/s 60.3112 KOps/s $\color{#35bf28}+2.51\%$
test_step_mdp_speed[False-False-True-True-True] 62.1800μs 39.2998μs 25.4454 KOps/s 25.2450 KOps/s $\color{#35bf28}+0.79\%$
test_step_mdp_speed[False-False-True-True-False] 44.1610μs 26.4735μs 37.7736 KOps/s 37.1436 KOps/s $\color{#35bf28}+1.70\%$
test_step_mdp_speed[False-False-True-False-True] 50.1110μs 25.0899μs 39.8567 KOps/s 39.0977 KOps/s $\color{#35bf28}+1.94\%$
test_step_mdp_speed[False-False-True-False-False] 31.9000μs 16.2583μs 61.5069 KOps/s 60.9196 KOps/s $\color{#35bf28}+0.96\%$
test_step_mdp_speed[False-False-False-True-True] 54.4010μs 42.1104μs 23.7471 KOps/s 23.5889 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[False-False-False-True-False] 52.7100μs 28.5817μs 34.9874 KOps/s 34.0994 KOps/s $\color{#35bf28}+2.60\%$
test_step_mdp_speed[False-False-False-False-True] 45.3410μs 27.0260μs 37.0014 KOps/s 36.6182 KOps/s $\color{#35bf28}+1.05\%$
test_step_mdp_speed[False-False-False-False-False] 32.7010μs 18.4017μs 54.3428 KOps/s 54.0442 KOps/s $\color{#35bf28}+0.55\%$
test_values[generalized_advantage_estimate-True-True] 25.5882ms 25.0541ms 39.9137 Ops/s 40.0823 Ops/s $\color{#d91a1a}-0.42\%$
test_values[vec_generalized_advantage_estimate-True-True] 81.5204ms 3.1977ms 312.7221 Ops/s 311.7304 Ops/s $\color{#35bf28}+0.32\%$
test_values[td0_return_estimate-False-False] 89.5820μs 63.7526μs 15.6856 KOps/s 15.5158 KOps/s $\color{#35bf28}+1.09\%$
test_values[td1_return_estimate-False-False] 53.8041ms 53.3596ms 18.7408 Ops/s 18.5426 Ops/s $\color{#35bf28}+1.07\%$
test_values[vec_td1_return_estimate-False-False] 2.0402ms 1.7597ms 568.2679 Ops/s 566.6309 Ops/s $\color{#35bf28}+0.29\%$
test_values[td_lambda_return_estimate-True-False] 86.8227ms 85.3680ms 11.7140 Ops/s 11.6259 Ops/s $\color{#35bf28}+0.76\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.1061ms 1.7563ms 569.3795 Ops/s 568.4973 Ops/s $\color{#35bf28}+0.16\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.5289ms 23.3601ms 42.8080 Ops/s 42.1627 Ops/s $\color{#35bf28}+1.53\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8844ms 0.6978ms 1.4332 KOps/s 1.4337 KOps/s $\color{#d91a1a}-0.04\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6927ms 0.6472ms 1.5452 KOps/s 1.5257 KOps/s $\color{#35bf28}+1.28\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5445ms 1.4476ms 690.7880 Ops/s 689.7308 Ops/s $\color{#35bf28}+0.15\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9354ms 0.6690ms 1.4947 KOps/s 1.4940 KOps/s $\color{#35bf28}+0.05\%$
test_dqn_speed 1.8355ms 1.4434ms 692.8175 Ops/s 692.5585 Ops/s $\color{#35bf28}+0.04\%$
test_ddpg_speed 3.0474ms 2.9278ms 341.5498 Ops/s 339.7839 Ops/s $\color{#35bf28}+0.52\%$
test_sac_speed 8.7428ms 8.4039ms 118.9926 Ops/s 117.8715 Ops/s $\color{#35bf28}+0.95\%$
test_redq_speed 11.1882ms 10.2156ms 97.8898 Ops/s 95.7379 Ops/s $\color{#35bf28}+2.25\%$
test_redq_deprec_speed 12.0235ms 11.5385ms 86.6667 Ops/s 85.9294 Ops/s $\color{#35bf28}+0.86\%$
test_td3_speed 17.2030ms 8.4486ms 118.3628 Ops/s 119.2143 Ops/s $\color{#d91a1a}-0.71\%$
test_cql_speed 27.3153ms 25.8841ms 38.6338 Ops/s 38.4957 Ops/s $\color{#35bf28}+0.36\%$
test_a2c_speed 6.2785ms 5.7177ms 174.8955 Ops/s 175.4147 Ops/s $\color{#d91a1a}-0.30\%$
test_ppo_speed 6.5765ms 5.9308ms 168.6108 Ops/s 166.8463 Ops/s $\color{#35bf28}+1.06\%$
test_reinforce_speed 4.9552ms 4.6903ms 213.2047 Ops/s 214.1269 Ops/s $\color{#d91a1a}-0.43\%$
test_iql_speed 20.4466ms 19.9606ms 50.0988 Ops/s 50.0697 Ops/s $\color{#35bf28}+0.06\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.8472ms 2.7471ms 364.0222 Ops/s 362.3666 Ops/s $\color{#35bf28}+0.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8301ms 0.5962ms 1.6773 KOps/s 1.6678 KOps/s $\color{#35bf28}+0.57\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7067ms 0.5794ms 1.7260 KOps/s 1.7090 KOps/s $\color{#35bf28}+0.99\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9472ms 2.7714ms 360.8335 Ops/s 362.1440 Ops/s $\color{#d91a1a}-0.36\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7205ms 0.5880ms 1.7006 KOps/s 1.6928 KOps/s $\color{#35bf28}+0.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 4.5077ms 0.5757ms 1.7370 KOps/s 1.7253 KOps/s $\color{#35bf28}+0.68\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7315ms 1.5515ms 644.5275 Ops/s 640.1004 Ops/s $\color{#35bf28}+0.69\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6331ms 1.4841ms 673.8284 Ops/s 665.6592 Ops/s $\color{#35bf28}+1.23\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0237ms 2.8885ms 346.2056 Ops/s 347.5348 Ops/s $\color{#d91a1a}-0.38\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.1132s 0.8304ms 1.2042 KOps/s 1.3759 KOps/s $\textbf{\color{#d91a1a}-12.48\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8494ms 0.7020ms 1.4245 KOps/s 1.4059 KOps/s $\color{#35bf28}+1.32\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.8326ms 2.7541ms 363.0961 Ops/s 363.8513 Ops/s $\color{#d91a1a}-0.21\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7553ms 0.5963ms 1.6769 KOps/s 1.6651 KOps/s $\color{#35bf28}+0.71\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7063ms 0.5837ms 1.7131 KOps/s 1.7050 KOps/s $\color{#35bf28}+0.48\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9477ms 2.7717ms 360.7941 Ops/s 362.1530 Ops/s $\color{#d91a1a}-0.38\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7010ms 0.5912ms 1.6916 KOps/s 1.6791 KOps/s $\color{#35bf28}+0.75\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7210ms 0.5727ms 1.7461 KOps/s 1.7380 KOps/s $\color{#35bf28}+0.47\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.9798ms 2.8951ms 345.4144 Ops/s 348.0354 Ops/s $\color{#d91a1a}-0.75\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8509ms 0.7268ms 1.3759 KOps/s 1.3697 KOps/s $\color{#35bf28}+0.45\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.6734ms 0.7150ms 1.3985 KOps/s 1.4013 KOps/s $\color{#d91a1a}-0.20\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1316s 7.3588ms 135.8915 Ops/s 104.1875 Ops/s $\textbf{\color{#35bf28}+30.43\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.4890ms 14.9483ms 66.8973 Ops/s 67.0431 Ops/s $\color{#d91a1a}-0.22\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.3834ms 1.2461ms 802.5179 Ops/s 842.1972 Ops/s $\color{#d91a1a}-4.71\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1149s 9.2241ms 108.4120 Ops/s 140.2299 Ops/s $\textbf{\color{#d91a1a}-22.69\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.9642ms 14.9716ms 66.7933 Ops/s 67.6912 Ops/s $\color{#d91a1a}-1.33\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.1792ms 1.2116ms 825.3772 Ops/s 840.3385 Ops/s $\color{#d91a1a}-1.78\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1151s 7.3865ms 135.3827 Ops/s 134.2288 Ops/s $\color{#35bf28}+0.86\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.2007ms 15.4726ms 64.6302 Ops/s 64.8802 Ops/s $\color{#d91a1a}-0.39\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.7235ms 1.5993ms 625.2766 Ops/s 596.2151 Ops/s $\color{#35bf28}+4.87\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot