Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix vmas stacks #2105

Merged
merged 3 commits into from
Apr 24, 2024
Merged

[BugFix] Fix vmas stacks #2105

merged 3 commits into from
Apr 24, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Apr 24, 2024

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2105

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 55be007 with merge base 09c934d (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 24, 2024
@vmoens vmoens added bug Something isn't working Environments Adds or modifies an environment wrapper Data Data-related PR, will launch data-related jobs labels Apr 24, 2024
@vmoens vmoens changed the title [BugFix] FIx vmas stacks [BugFix] Fix vmas stacks Apr 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}9$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 52.3262ms 51.5975ms 19.3808 Ops/s 17.9128 Ops/s $\textbf{\color{#35bf28}+8.19\%}$
test_sync 34.8798ms 28.8365ms 34.6782 Ops/s 34.1254 Ops/s $\color{#35bf28}+1.62\%$
test_async 53.8430ms 25.9976ms 38.4651 Ops/s 37.9045 Ops/s $\color{#35bf28}+1.48\%$
test_simple 0.3836s 0.3338s 2.9957 Ops/s 2.9958 Ops/s $-0.00\%$
test_transformed 0.4617s 0.4596s 2.1757 Ops/s 2.0216 Ops/s $\textbf{\color{#35bf28}+7.62\%}$
test_serial 1.2123s 1.1672s 0.8568 Ops/s 0.8327 Ops/s $\color{#35bf28}+2.89\%$
test_parallel 1.0397s 1.0003s 0.9997 Ops/s 0.9947 Ops/s $\color{#35bf28}+0.50\%$
test_step_mdp_speed[True-True-True-True-True] 0.1435ms 20.9802μs 47.6640 KOps/s 47.1966 KOps/s $\color{#35bf28}+0.99\%$
test_step_mdp_speed[True-True-True-True-False] 48.8310μs 12.8276μs 77.9568 KOps/s 77.6066 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[True-True-True-False-True] 34.9750μs 12.2856μs 81.3964 KOps/s 81.2093 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[True-True-True-False-False] 28.6040μs 7.5475μs 132.4947 KOps/s 132.5481 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[True-True-False-True-True] 52.0970μs 22.4796μs 44.4848 KOps/s 44.4441 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-True-False-True-False] 63.5380μs 14.0222μs 71.3157 KOps/s 70.0057 KOps/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[True-True-False-False-True] 44.9240μs 13.4294μs 74.4632 KOps/s 73.2373 KOps/s $\color{#35bf28}+1.67\%$
test_step_mdp_speed[True-True-False-False-False] 28.1830μs 8.6617μs 115.4505 KOps/s 113.5458 KOps/s $\color{#35bf28}+1.68\%$
test_step_mdp_speed[True-False-True-True-True] 66.4030μs 23.6962μs 42.2008 KOps/s 42.0090 KOps/s $\color{#35bf28}+0.46\%$
test_step_mdp_speed[True-False-True-True-False] 38.7530μs 15.4385μs 64.7729 KOps/s 65.2487 KOps/s $\color{#d91a1a}-0.73\%$
test_step_mdp_speed[True-False-True-False-True] 49.5520μs 13.6648μs 73.1809 KOps/s 73.1666 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[True-False-True-False-False] 38.8030μs 8.6254μs 115.9366 KOps/s 114.4552 KOps/s $\color{#35bf28}+1.29\%$
test_step_mdp_speed[True-False-False-True-True] 75.6810μs 24.7879μs 40.3422 KOps/s 40.0820 KOps/s $\color{#35bf28}+0.65\%$
test_step_mdp_speed[True-False-False-True-False] 39.8040μs 16.5312μs 60.4917 KOps/s 59.4271 KOps/s $\color{#35bf28}+1.79\%$
test_step_mdp_speed[True-False-False-False-True] 37.8610μs 14.6753μs 68.1418 KOps/s 67.9910 KOps/s $\color{#35bf28}+0.22\%$
test_step_mdp_speed[True-False-False-False-False] 30.3860μs 9.8884μs 101.1284 KOps/s 101.3797 KOps/s $\color{#d91a1a}-0.25\%$
test_step_mdp_speed[False-True-True-True-True] 57.4170μs 23.6653μs 42.2559 KOps/s 42.0865 KOps/s $\color{#35bf28}+0.40\%$
test_step_mdp_speed[False-True-True-True-False] 48.5300μs 15.4137μs 64.8772 KOps/s 64.5983 KOps/s $\color{#35bf28}+0.43\%$
test_step_mdp_speed[False-True-True-False-True] 40.2340μs 15.9825μs 62.5683 KOps/s 63.0175 KOps/s $\color{#d91a1a}-0.71\%$
test_step_mdp_speed[False-True-True-False-False] 33.3310μs 10.0688μs 99.3171 KOps/s 99.9136 KOps/s $\color{#d91a1a}-0.60\%$
test_step_mdp_speed[False-True-False-True-True] 53.9610μs 25.5413μs 39.1523 KOps/s 39.5507 KOps/s $\color{#d91a1a}-1.01\%$
test_step_mdp_speed[False-True-False-True-False] 45.4140μs 16.6610μs 60.0203 KOps/s 60.5805 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[False-True-False-False-True] 45.5550μs 17.1263μs 58.3899 KOps/s 59.6337 KOps/s $\color{#d91a1a}-2.09\%$
test_step_mdp_speed[False-True-False-False-False] 54.4110μs 11.2036μs 89.2574 KOps/s 90.2472 KOps/s $\color{#d91a1a}-1.10\%$
test_step_mdp_speed[False-False-True-True-True] 61.3240μs 26.4242μs 37.8441 KOps/s 38.0209 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[False-False-True-True-False] 41.3370μs 17.9538μs 55.6985 KOps/s 56.1436 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[False-False-True-False-True] 48.7300μs 16.9514μs 58.9923 KOps/s 59.0532 KOps/s $\color{#d91a1a}-0.10\%$
test_step_mdp_speed[False-False-True-False-False] 31.9590μs 11.1536μs 89.6575 KOps/s 89.5668 KOps/s $\color{#35bf28}+0.10\%$
test_step_mdp_speed[False-False-False-True-True] 64.0790μs 27.3032μs 36.6258 KOps/s 37.0221 KOps/s $\color{#d91a1a}-1.07\%$
test_step_mdp_speed[False-False-False-True-False] 41.5770μs 19.1329μs 52.2659 KOps/s 52.9606 KOps/s $\color{#d91a1a}-1.31\%$
test_step_mdp_speed[False-False-False-False-True] 52.2570μs 18.0986μs 55.2528 KOps/s 55.4753 KOps/s $\color{#d91a1a}-0.40\%$
test_step_mdp_speed[False-False-False-False-False] 36.5780μs 12.1700μs 82.1695 KOps/s 81.5560 KOps/s $\color{#35bf28}+0.75\%$
test_values[generalized_advantage_estimate-True-True] 10.4805ms 9.0439ms 110.5718 Ops/s 107.8084 Ops/s $\color{#35bf28}+2.56\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.8450ms 35.4917ms 28.1756 Ops/s 30.3125 Ops/s $\textbf{\color{#d91a1a}-7.05\%}$
test_values[td0_return_estimate-False-False] 0.1996ms 0.1725ms 5.7965 KOps/s 5.9254 KOps/s $\color{#d91a1a}-2.18\%$
test_values[td1_return_estimate-False-False] 24.5917ms 22.5532ms 44.3396 Ops/s 42.7664 Ops/s $\color{#35bf28}+3.68\%$
test_values[vec_td1_return_estimate-False-False] 41.3205ms 35.6341ms 28.0630 Ops/s 30.1519 Ops/s $\textbf{\color{#d91a1a}-6.93\%}$
test_values[td_lambda_return_estimate-True-False] 47.0240ms 33.2494ms 30.0757 Ops/s 29.2471 Ops/s $\color{#35bf28}+2.83\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.3381ms 35.2102ms 28.4009 Ops/s 30.2749 Ops/s $\textbf{\color{#d91a1a}-6.19\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.4134ms 7.9273ms 126.1458 Ops/s 120.9646 Ops/s $\color{#35bf28}+4.28\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.1332ms 1.8749ms 533.3666 Ops/s 509.2931 Ops/s $\color{#35bf28}+4.73\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.8464ms 0.3451ms 2.8975 KOps/s 2.8453 KOps/s $\color{#35bf28}+1.83\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 55.3229ms 47.2287ms 21.1736 Ops/s 24.9062 Ops/s $\textbf{\color{#d91a1a}-14.99\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.6953ms 3.0207ms 331.0478 Ops/s 332.2598 Ops/s $\color{#d91a1a}-0.36\%$
test_dqn_speed 1.7571ms 1.3244ms 755.0720 Ops/s 729.4795 Ops/s $\color{#35bf28}+3.51\%$
test_ddpg_speed 3.0879ms 2.6582ms 376.2003 Ops/s 372.3962 Ops/s $\color{#35bf28}+1.02\%$
test_sac_speed 9.2145ms 8.1414ms 122.8295 Ops/s 112.8344 Ops/s $\textbf{\color{#35bf28}+8.86\%}$
test_redq_speed 14.6256ms 13.1169ms 76.2374 Ops/s 76.5349 Ops/s $\color{#d91a1a}-0.39\%$
test_redq_deprec_speed 20.4840ms 13.7087ms 72.9465 Ops/s 76.3566 Ops/s $\color{#d91a1a}-4.47\%$
test_td3_speed 16.3018ms 8.0897ms 123.6135 Ops/s 122.2804 Ops/s $\color{#35bf28}+1.09\%$
test_cql_speed 39.3913ms 36.8592ms 27.1303 Ops/s 27.6262 Ops/s $\color{#d91a1a}-1.80\%$
test_a2c_speed 8.7846ms 7.3481ms 136.0887 Ops/s 136.4987 Ops/s $\color{#d91a1a}-0.30\%$
test_ppo_speed 8.3423ms 7.5827ms 131.8795 Ops/s 130.5607 Ops/s $\color{#35bf28}+1.01\%$
test_reinforce_speed 7.5637ms 6.5079ms 153.6597 Ops/s 153.6558 Ops/s $+0.00\%$
test_iql_speed 35.9179ms 32.6901ms 30.5903 Ops/s 30.5752 Ops/s $\color{#35bf28}+0.05\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.6496ms 2.4529ms 407.6883 Ops/s 459.5950 Ops/s $\textbf{\color{#d91a1a}-11.29\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 96.1765ms 0.5792ms 1.7265 KOps/s 2.0095 KOps/s $\textbf{\color{#d91a1a}-14.08\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7012ms 0.4867ms 2.0547 KOps/s 2.1045 KOps/s $\color{#d91a1a}-2.37\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.5719ms 2.3726ms 421.4872 Ops/s 472.6872 Ops/s $\textbf{\color{#d91a1a}-10.83\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8952ms 0.5038ms 1.9849 KOps/s 2.0391 KOps/s $\color{#d91a1a}-2.66\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9012ms 0.4792ms 2.0867 KOps/s 2.1630 KOps/s $\color{#d91a1a}-3.53\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.4600ms 1.2088ms 827.2756 Ops/s 812.3040 Ops/s $\color{#35bf28}+1.84\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6618ms 1.1381ms 878.6263 Ops/s 857.1999 Ops/s $\color{#35bf28}+2.50\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2195ms 2.3600ms 423.7227 Ops/s 436.4248 Ops/s $\color{#d91a1a}-2.91\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.1466ms 0.6148ms 1.6266 KOps/s 1.5904 KOps/s $\color{#35bf28}+2.28\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9109ms 0.5911ms 1.6917 KOps/s 1.6626 KOps/s $\color{#35bf28}+1.75\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3763ms 2.0811ms 480.5111 Ops/s 449.0378 Ops/s $\textbf{\color{#35bf28}+7.01\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.0027ms 0.4936ms 2.0260 KOps/s 1.9713 KOps/s $\color{#35bf28}+2.77\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8148ms 0.4811ms 2.0785 KOps/s 2.0441 KOps/s $\color{#35bf28}+1.69\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9313ms 2.2283ms 448.7787 Ops/s 458.3759 Ops/s $\color{#d91a1a}-2.09\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6019ms 0.4945ms 2.0223 KOps/s 2.0141 KOps/s $\color{#35bf28}+0.41\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.5783ms 0.4785ms 2.0900 KOps/s 2.1550 KOps/s $\color{#d91a1a}-3.02\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.6391ms 2.3790ms 420.3425 Ops/s 459.3831 Ops/s $\textbf{\color{#d91a1a}-8.50\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.2037ms 0.6204ms 1.6119 KOps/s 1.6128 KOps/s $\color{#d91a1a}-0.06\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 1.0153ms 0.6025ms 1.6598 KOps/s 1.6992 KOps/s $\color{#d91a1a}-2.32\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1184s 7.9640ms 125.5650 Ops/s 131.1608 Ops/s $\color{#d91a1a}-4.27\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.2138ms 11.8675ms 84.2636 Ops/s 83.1499 Ops/s $\color{#35bf28}+1.34\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.9923ms 1.1384ms 878.4423 Ops/s 940.6205 Ops/s $\textbf{\color{#d91a1a}-6.61\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1020s 5.5599ms 179.8608 Ops/s 182.0541 Ops/s $\color{#d91a1a}-1.20\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 0.1128s 13.9756ms 71.5535 Ops/s 71.2727 Ops/s $\color{#35bf28}+0.39\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 4.3872ms 1.1487ms 870.5165 Ops/s 892.8399 Ops/s $\color{#d91a1a}-2.50\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1046s 5.9810ms 167.1971 Ops/s 167.5930 Ops/s $\color{#d91a1a}-0.24\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 14.8118ms 12.1929ms 82.0148 Ops/s 80.9724 Ops/s $\color{#35bf28}+1.29\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.6792ms 1.4437ms 692.6532 Ops/s 728.6824 Ops/s $\color{#d91a1a}-4.94\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}4$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1027s 0.1024s 9.7617 Ops/s 9.2010 Ops/s $\textbf{\color{#35bf28}+6.09\%}$
test_sync 91.7190ms 89.6138ms 11.1590 Ops/s 11.3514 Ops/s $\color{#d91a1a}-1.69\%$
test_async 0.1645s 72.4586ms 13.8010 Ops/s 13.9630 Ops/s $\color{#d91a1a}-1.16\%$
test_single_pixels 0.1140s 0.1131s 8.8437 Ops/s 9.0105 Ops/s $\color{#d91a1a}-1.85\%$
test_sync_pixels 69.5092ms 67.8109ms 14.7469 Ops/s 14.7589 Ops/s $\color{#d91a1a}-0.08\%$
test_async_pixels 73.0043ms 62.8645ms 15.9072 Ops/s 16.0043 Ops/s $\color{#d91a1a}-0.61\%$
test_simple 0.6878s 0.6871s 1.4555 Ops/s 1.4320 Ops/s $\color{#35bf28}+1.64\%$
test_transformed 0.9174s 0.9166s 1.0910 Ops/s 1.0908 Ops/s $\color{#35bf28}+0.01\%$
test_serial 2.2001s 2.1428s 0.4667 Ops/s 0.4722 Ops/s $\color{#d91a1a}-1.16\%$
test_parallel 1.8232s 1.7543s 0.5700 Ops/s 0.5597 Ops/s $\color{#35bf28}+1.85\%$
test_step_mdp_speed[True-True-True-True-True] 0.1077ms 33.5786μs 29.7809 KOps/s 31.0157 KOps/s $\color{#d91a1a}-3.98\%$
test_step_mdp_speed[True-True-True-True-False] 98.0510μs 20.1187μs 49.7050 KOps/s 50.1743 KOps/s $\color{#d91a1a}-0.94\%$
test_step_mdp_speed[True-True-True-False-True] 41.6100μs 19.2809μs 51.8648 KOps/s 53.1518 KOps/s $\color{#d91a1a}-2.42\%$
test_step_mdp_speed[True-True-True-False-False] 27.4200μs 11.4566μs 87.2863 KOps/s 87.7301 KOps/s $\color{#d91a1a}-0.51\%$
test_step_mdp_speed[True-True-False-True-True] 57.8500μs 35.7066μs 28.0060 KOps/s 28.6227 KOps/s $\color{#d91a1a}-2.15\%$
test_step_mdp_speed[True-True-False-True-False] 44.1410μs 21.9179μs 45.6248 KOps/s 46.0082 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[True-True-False-False-True] 38.4000μs 20.9767μs 47.6720 KOps/s 48.3314 KOps/s $\color{#d91a1a}-1.36\%$
test_step_mdp_speed[True-True-False-False-False] 37.7610μs 13.3331μs 75.0016 KOps/s 74.9950 KOps/s $+0.01\%$
test_step_mdp_speed[True-False-True-True-True] 58.6300μs 38.0020μs 26.3144 KOps/s 27.1444 KOps/s $\color{#d91a1a}-3.06\%$
test_step_mdp_speed[True-False-True-True-False] 49.2610μs 24.0386μs 41.5998 KOps/s 41.9208 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[True-False-True-False-True] 43.8200μs 21.3966μs 46.7364 KOps/s 48.6285 KOps/s $\color{#d91a1a}-3.89\%$
test_step_mdp_speed[True-False-True-False-False] 32.8500μs 13.2330μs 75.5684 KOps/s 75.4459 KOps/s $\color{#35bf28}+0.16\%$
test_step_mdp_speed[True-False-False-True-True] 0.1057ms 38.7984μs 25.7742 KOps/s 25.8782 KOps/s $\color{#d91a1a}-0.40\%$
test_step_mdp_speed[True-False-False-True-False] 46.2610μs 25.8748μs 38.6476 KOps/s 39.4557 KOps/s $\color{#d91a1a}-2.05\%$
test_step_mdp_speed[True-False-False-False-True] 43.2600μs 22.6734μs 44.1045 KOps/s 44.8402 KOps/s $\color{#d91a1a}-1.64\%$
test_step_mdp_speed[True-False-False-False-False] 38.3600μs 15.1982μs 65.7971 KOps/s 66.7552 KOps/s $\color{#d91a1a}-1.44\%$
test_step_mdp_speed[False-True-True-True-True] 63.0210μs 37.6387μs 26.5684 KOps/s 27.0989 KOps/s $\color{#d91a1a}-1.96\%$
test_step_mdp_speed[False-True-True-True-False] 43.9400μs 23.9978μs 41.6705 KOps/s 42.5890 KOps/s $\color{#d91a1a}-2.16\%$
test_step_mdp_speed[False-True-True-False-True] 51.6810μs 25.1087μs 39.8269 KOps/s 41.0244 KOps/s $\color{#d91a1a}-2.92\%$
test_step_mdp_speed[False-True-True-False-False] 64.0210μs 15.1154μs 66.1576 KOps/s 66.1589 KOps/s $-0.00\%$
test_step_mdp_speed[False-True-False-True-True] 51.8400μs 40.0913μs 24.9430 KOps/s 25.3966 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[False-True-False-True-False] 53.0110μs 25.9971μs 38.4658 KOps/s 38.8851 KOps/s $\color{#d91a1a}-1.08\%$
test_step_mdp_speed[False-True-False-False-True] 49.9910μs 26.5575μs 37.6541 KOps/s 38.5100 KOps/s $\color{#d91a1a}-2.22\%$
test_step_mdp_speed[False-True-False-False-False] 33.9110μs 17.0380μs 58.6922 KOps/s 59.4035 KOps/s $\color{#d91a1a}-1.20\%$
test_step_mdp_speed[False-False-True-True-True] 66.9600μs 41.7369μs 23.9596 KOps/s 25.1204 KOps/s $\color{#d91a1a}-4.62\%$
test_step_mdp_speed[False-False-True-True-False] 51.8810μs 28.0507μs 35.6497 KOps/s 36.6453 KOps/s $\color{#d91a1a}-2.72\%$
test_step_mdp_speed[False-False-True-False-True] 44.0100μs 27.1358μs 36.8517 KOps/s 38.3529 KOps/s $\color{#d91a1a}-3.91\%$
test_step_mdp_speed[False-False-True-False-False] 35.2900μs 17.2070μs 58.1157 KOps/s 58.5159 KOps/s $\color{#d91a1a}-0.68\%$
test_step_mdp_speed[False-False-False-True-True] 69.2010μs 43.0942μs 23.2050 KOps/s 24.0308 KOps/s $\color{#d91a1a}-3.44\%$
test_step_mdp_speed[False-False-False-True-False] 56.0510μs 29.5654μs 33.8234 KOps/s 34.0898 KOps/s $\color{#d91a1a}-0.78\%$
test_step_mdp_speed[False-False-False-False-True] 54.1800μs 28.7369μs 34.7985 KOps/s 36.8409 KOps/s $\textbf{\color{#d91a1a}-5.54\%}$
test_step_mdp_speed[False-False-False-False-False] 82.5310μs 18.8284μs 53.1114 KOps/s 54.1630 KOps/s $\color{#d91a1a}-1.94\%$
test_values[generalized_advantage_estimate-True-True] 26.5071ms 25.9323ms 38.5620 Ops/s 39.4964 Ops/s $\color{#d91a1a}-2.37\%$
test_values[vec_generalized_advantage_estimate-True-True] 83.6699ms 3.2501ms 307.6840 Ops/s 306.0295 Ops/s $\color{#35bf28}+0.54\%$
test_values[td0_return_estimate-False-False] 93.3510μs 66.9141μs 14.9445 KOps/s 15.0240 KOps/s $\color{#d91a1a}-0.53\%$
test_values[td1_return_estimate-False-False] 56.0154ms 54.3706ms 18.3923 Ops/s 18.5727 Ops/s $\color{#d91a1a}-0.97\%$
test_values[vec_td1_return_estimate-False-False] 2.1612ms 1.7800ms 561.7859 Ops/s 564.2890 Ops/s $\color{#d91a1a}-0.44\%$
test_values[td_lambda_return_estimate-True-False] 89.2990ms 86.5270ms 11.5571 Ops/s 11.6458 Ops/s $\color{#d91a1a}-0.76\%$
test_values[vec_td_lambda_return_estimate-True-False] 2.1344ms 1.7793ms 562.0148 Ops/s 564.3344 Ops/s $\color{#d91a1a}-0.41\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 25.1980ms 24.9628ms 40.0596 Ops/s 41.8846 Ops/s $\color{#d91a1a}-4.36\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8862ms 0.7099ms 1.4087 KOps/s 1.4158 KOps/s $\color{#d91a1a}-0.50\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7210ms 0.6569ms 1.5222 KOps/s 1.5252 KOps/s $\color{#d91a1a}-0.20\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5475ms 1.4601ms 684.8742 Ops/s 687.2376 Ops/s $\color{#d91a1a}-0.34\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9441ms 0.6713ms 1.4896 KOps/s 1.4753 KOps/s $\color{#35bf28}+0.97\%$
test_dqn_speed 7.7366ms 1.4660ms 682.1321 Ops/s 693.1709 Ops/s $\color{#d91a1a}-1.59\%$
test_ddpg_speed 3.0965ms 2.7690ms 361.1418 Ops/s 367.3106 Ops/s $\color{#d91a1a}-1.68\%$
test_sac_speed 8.6191ms 8.2470ms 121.2565 Ops/s 121.1530 Ops/s $\color{#35bf28}+0.09\%$
test_redq_speed 96.9781ms 11.2374ms 88.9889 Ops/s 97.3498 Ops/s $\textbf{\color{#d91a1a}-8.59\%}$
test_redq_deprec_speed 11.7082ms 11.2396ms 88.9709 Ops/s 90.5208 Ops/s $\color{#d91a1a}-1.71\%$
test_td3_speed 8.2043ms 8.1358ms 122.9137 Ops/s 125.0248 Ops/s $\color{#d91a1a}-1.69\%$
test_cql_speed 26.5920ms 25.5446ms 39.1472 Ops/s 39.3893 Ops/s $\color{#d91a1a}-0.61\%$
test_a2c_speed 8.2067ms 5.4990ms 181.8498 Ops/s 180.8517 Ops/s $\color{#35bf28}+0.55\%$
test_ppo_speed 5.9040ms 5.7791ms 173.0361 Ops/s 170.3968 Ops/s $\color{#35bf28}+1.55\%$
test_reinforce_speed 5.2570ms 4.4660ms 223.9131 Ops/s 220.8494 Ops/s $\color{#35bf28}+1.39\%$
test_iql_speed 20.2038ms 19.3338ms 51.7229 Ops/s 51.7512 Ops/s $\color{#d91a1a}-0.05\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.9107ms 2.7920ms 358.1600 Ops/s 363.3810 Ops/s $\color{#d91a1a}-1.44\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.1013s 0.6142ms 1.6282 KOps/s 1.8645 KOps/s $\textbf{\color{#d91a1a}-12.67\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6885ms 0.5110ms 1.9570 KOps/s 1.9584 KOps/s $\color{#d91a1a}-0.07\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9313ms 2.8022ms 356.8638 Ops/s 360.6649 Ops/s $\color{#d91a1a}-1.05\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3673ms 0.5310ms 1.8833 KOps/s 1.8927 KOps/s $\color{#d91a1a}-0.50\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7005ms 0.5047ms 1.9814 KOps/s 1.9827 KOps/s $\color{#d91a1a}-0.07\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.5151ms 1.4221ms 703.1991 Ops/s 583.2195 Ops/s $\textbf{\color{#35bf28}+20.57\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5357ms 1.3549ms 738.0760 Ops/s 741.7580 Ops/s $\color{#d91a1a}-0.50\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.9980ms 2.9110ms 343.5277 Ops/s 344.1670 Ops/s $\color{#d91a1a}-0.19\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7872ms 0.6643ms 1.5054 KOps/s 1.5276 KOps/s $\color{#d91a1a}-1.46\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.7798ms 0.6439ms 1.5530 KOps/s 1.5787 KOps/s $\color{#d91a1a}-1.63\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.8727ms 2.7912ms 358.2630 Ops/s 361.0410 Ops/s $\color{#d91a1a}-0.77\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6813ms 0.5352ms 1.8685 KOps/s 1.8698 KOps/s $\color{#d91a1a}-0.07\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 4.6530ms 0.5163ms 1.9367 KOps/s 1.9432 KOps/s $\color{#d91a1a}-0.34\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9846ms 2.8254ms 353.9369 Ops/s 357.1872 Ops/s $\color{#d91a1a}-0.91\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.3515ms 0.5323ms 1.8787 KOps/s 1.8881 KOps/s $\color{#d91a1a}-0.50\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6536ms 0.5086ms 1.9661 KOps/s 1.9909 KOps/s $\color{#d91a1a}-1.24\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0316ms 2.9263ms 341.7303 Ops/s 343.9980 Ops/s $\color{#d91a1a}-0.66\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7984ms 0.6654ms 1.5028 KOps/s 1.5177 KOps/s $\color{#d91a1a}-0.99\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 4.8607ms 0.6451ms 1.5501 KOps/s 1.5653 KOps/s $\color{#d91a1a}-0.97\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1322s 9.6842ms 103.2611 Ops/s 133.5109 Ops/s $\textbf{\color{#d91a1a}-22.66\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 17.0491ms 14.8297ms 67.4322 Ops/s 69.5472 Ops/s $\color{#d91a1a}-3.04\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.1757ms 1.1331ms 882.5009 Ops/s 899.1520 Ops/s $\color{#d91a1a}-1.85\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1140s 7.0277ms 142.2936 Ops/s 139.6939 Ops/s $\color{#35bf28}+1.86\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.8310ms 14.7867ms 67.6281 Ops/s 70.2896 Ops/s $\color{#d91a1a}-3.79\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.1118ms 1.1246ms 889.2159 Ops/s 895.0884 Ops/s $\color{#d91a1a}-0.66\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1149s 7.4632ms 133.9911 Ops/s 102.0676 Ops/s $\textbf{\color{#35bf28}+31.28\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.2747ms 15.1857ms 65.8514 Ops/s 67.9867 Ops/s $\color{#d91a1a}-3.14\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.6352ms 1.4990ms 667.1086 Ops/s 692.6239 Ops/s $\color{#d91a1a}-3.68\%$

@vmoens vmoens merged commit d1b0e2b into main Apr 24, 2024
64 of 68 checks passed
@vmoens vmoens deleted the fix-vmas branch April 24, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Data Data-related PR, will launch data-related jobs Environments Adds or modifies an environment wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot