Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix CQL/IQL pbar update #2020

Merged
merged 1 commit into from
Mar 18, 2024
Merged

[BugFix] Fix CQL/IQL pbar update #2020

merged 1 commit into from
Mar 18, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Mar 18, 2024 •
edited
Loading

cc @BY571

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2020

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 13 Unrelated Failures

As of commit 7d770f8 with merge base c29c345 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2024
@vmoens vmoens added the bug Something isn't working label Mar 18, 2024
@vmoens vmoens linked an issue Mar 18, 2024 that may be closed by this pull request
[BUG] Very minor: Progress bar in CQL is broken #2019
Closed
3 tasks
@vmoens vmoens merged commit 9747170 into main Mar 18, 2024
35 of 52 checks passed
@vmoens vmoens deleted the fix-updates-cql-iql branch March 18, 2024 21:15
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 94. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}5$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1084s 0.1070s 9.3453 Ops/s 9.6870 Ops/s $\color{#d91a1a}-3.53\%$
test_sync 92.5934ms 90.1783ms 11.0891 Ops/s 10.8400 Ops/s $\color{#35bf28}+2.30\%$
test_async 0.1734s 87.3474ms 11.4485 Ops/s 11.4087 Ops/s $\color{#35bf28}+0.35\%$
test_single_pixels 0.1151s 0.1139s 8.7798 Ops/s 8.8059 Ops/s $\color{#d91a1a}-0.30\%$
test_sync_pixels 69.1224ms 67.1080ms 14.9014 Ops/s 14.8267 Ops/s $\color{#35bf28}+0.50\%$
test_async_pixels 0.1206s 56.1213ms 17.8185 Ops/s 17.4381 Ops/s $\color{#35bf28}+2.18\%$
test_simple 0.6786s 0.6760s 1.4793 Ops/s 1.4255 Ops/s $\color{#35bf28}+3.77\%$
test_transformed 0.8932s 0.8920s 1.1211 Ops/s 1.0931 Ops/s $\color{#35bf28}+2.56\%$
test_serial 2.2205s 2.1618s 0.4626 Ops/s 0.4555 Ops/s $\color{#35bf28}+1.55\%$
test_parallel 1.8804s 1.8157s 0.5508 Ops/s 0.5456 Ops/s $\color{#35bf28}+0.95\%$
test_step_mdp_speed[True-True-True-True-True] 66.0510μs 33.0905μs 30.2202 KOps/s 30.0703 KOps/s $\color{#35bf28}+0.50\%$
test_step_mdp_speed[True-True-True-True-False] 43.0010μs 19.6822μs 50.8074 KOps/s 49.3260 KOps/s $\color{#35bf28}+3.00\%$
test_step_mdp_speed[True-True-True-False-True] 47.0610μs 18.5445μs 53.9244 KOps/s 52.1224 KOps/s $\color{#35bf28}+3.46\%$
test_step_mdp_speed[True-True-True-False-False] 30.9200μs 11.0388μs 90.5892 KOps/s 86.9485 KOps/s $\color{#35bf28}+4.19\%$
test_step_mdp_speed[True-True-False-True-True] 62.1410μs 34.1142μs 29.3133 KOps/s 28.1465 KOps/s $\color{#35bf28}+4.15\%$
test_step_mdp_speed[True-True-False-True-False] 36.5800μs 21.3161μs 46.9129 KOps/s 45.5919 KOps/s $\color{#35bf28}+2.90\%$
test_step_mdp_speed[True-True-False-False-True] 90.6020μs 20.2885μs 49.2889 KOps/s 47.6251 KOps/s $\color{#35bf28}+3.49\%$
test_step_mdp_speed[True-True-False-False-False] 29.0600μs 12.8510μs 77.8152 KOps/s 74.5254 KOps/s $\color{#35bf28}+4.41\%$
test_step_mdp_speed[True-False-True-True-True] 62.4510μs 35.7511μs 27.9711 KOps/s 26.8361 KOps/s $\color{#35bf28}+4.23\%$
test_step_mdp_speed[True-False-True-True-False] 49.5810μs 23.2914μs 42.9343 KOps/s 41.3876 KOps/s $\color{#35bf28}+3.74\%$
test_step_mdp_speed[True-False-True-False-True] 40.9410μs 20.3588μs 49.1188 KOps/s 47.8034 KOps/s $\color{#35bf28}+2.75\%$
test_step_mdp_speed[True-False-True-False-False] 47.4510μs 13.0282μs 76.7566 KOps/s 74.7995 KOps/s $\color{#35bf28}+2.62\%$
test_step_mdp_speed[True-False-False-True-True] 65.1410μs 37.8023μs 26.4534 KOps/s 25.7825 KOps/s $\color{#35bf28}+2.60\%$
test_step_mdp_speed[True-False-False-True-False] 55.8810μs 24.9872μs 40.0205 KOps/s 38.2470 KOps/s $\color{#35bf28}+4.64\%$
test_step_mdp_speed[True-False-False-False-True] 44.3500μs 21.8330μs 45.8023 KOps/s 44.4257 KOps/s $\color{#35bf28}+3.10\%$
test_step_mdp_speed[True-False-False-False-False] 33.8900μs 14.6959μs 68.0463 KOps/s 65.8739 KOps/s $\color{#35bf28}+3.30\%$
test_step_mdp_speed[False-True-True-True-True] 54.0410μs 36.0122μs 27.7683 KOps/s 26.8464 KOps/s $\color{#35bf28}+3.43\%$
test_step_mdp_speed[False-True-True-True-False] 42.0710μs 23.2233μs 43.0602 KOps/s 41.4112 KOps/s $\color{#35bf28}+3.98\%$
test_step_mdp_speed[False-True-True-False-True] 49.1010μs 23.8211μs 41.9796 KOps/s 40.5587 KOps/s $\color{#35bf28}+3.50\%$
test_step_mdp_speed[False-True-True-False-False] 32.0310μs 14.6175μs 68.4109 KOps/s 66.5079 KOps/s $\color{#35bf28}+2.86\%$
test_step_mdp_speed[False-True-False-True-True] 62.1310μs 37.7239μs 26.5084 KOps/s 25.3213 KOps/s $\color{#35bf28}+4.69\%$
test_step_mdp_speed[False-True-False-True-False] 45.9000μs 25.2956μs 39.5326 KOps/s 38.2696 KOps/s $\color{#35bf28}+3.30\%$
test_step_mdp_speed[False-True-False-False-True] 77.2110μs 25.8577μs 38.6733 KOps/s 37.1309 KOps/s $\color{#35bf28}+4.15\%$
test_step_mdp_speed[False-True-False-False-False] 36.0110μs 16.5236μs 60.5194 KOps/s 58.8267 KOps/s $\color{#35bf28}+2.88\%$
test_step_mdp_speed[False-False-True-True-True] 68.1420μs 39.8917μs 25.0679 KOps/s 23.9548 KOps/s $\color{#35bf28}+4.65\%$
test_step_mdp_speed[False-False-True-True-False] 46.4610μs 27.1998μs 36.7649 KOps/s 35.9840 KOps/s $\color{#35bf28}+2.17\%$
test_step_mdp_speed[False-False-True-False-True] 47.1710μs 25.7739μs 38.7989 KOps/s 38.0499 KOps/s $\color{#35bf28}+1.97\%$
test_step_mdp_speed[False-False-True-False-False] 37.8000μs 16.5583μs 60.3928 KOps/s 58.7329 KOps/s $\color{#35bf28}+2.83\%$
test_step_mdp_speed[False-False-False-True-True] 58.0710μs 41.4770μs 24.1097 KOps/s 23.4613 KOps/s $\color{#35bf28}+2.76\%$
test_step_mdp_speed[False-False-False-True-False] 46.4610μs 28.9579μs 34.5329 KOps/s 34.1403 KOps/s $\color{#35bf28}+1.15\%$
test_step_mdp_speed[False-False-False-False-True] 54.5910μs 27.2525μs 36.6938 KOps/s 35.5353 KOps/s $\color{#35bf28}+3.26\%$
test_step_mdp_speed[False-False-False-False-False] 35.6310μs 18.1596μs 55.0672 KOps/s 52.8301 KOps/s $\color{#35bf28}+4.23\%$
test_values[generalized_advantage_estimate-True-True] 25.9737ms 25.4294ms 39.3245 Ops/s 40.0990 Ops/s $\color{#d91a1a}-1.93\%$
test_values[vec_generalized_advantage_estimate-True-True] 83.8095ms 3.2469ms 307.9825 Ops/s 305.7608 Ops/s $\color{#35bf28}+0.73\%$
test_values[td0_return_estimate-False-False] 99.4920μs 65.6523μs 15.2318 KOps/s 15.4092 KOps/s $\color{#d91a1a}-1.15\%$
test_values[td1_return_estimate-False-False] 57.9313ms 55.0337ms 18.1707 Ops/s 18.7223 Ops/s $\color{#d91a1a}-2.95\%$
test_values[vec_td1_return_estimate-False-False] 2.1455ms 1.7851ms 560.2047 Ops/s 566.7626 Ops/s $\color{#d91a1a}-1.16\%$
test_values[td_lambda_return_estimate-True-False] 92.2949ms 90.8146ms 11.0114 Ops/s 11.7510 Ops/s $\textbf{\color{#d91a1a}-6.29\%}$
test_values[vec_td_lambda_return_estimate-True-False] 2.1481ms 1.7787ms 562.2240 Ops/s 567.1852 Ops/s $\color{#d91a1a}-0.87\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 26.0746ms 25.4642ms 39.2709 Ops/s 43.1781 Ops/s $\textbf{\color{#d91a1a}-9.05\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9539ms 0.7221ms 1.3848 KOps/s 1.4108 KOps/s $\color{#d91a1a}-1.85\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7416ms 0.6863ms 1.4571 KOps/s 1.5428 KOps/s $\textbf{\color{#d91a1a}-5.56\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.5107ms 1.4623ms 683.8393 Ops/s 687.1249 Ops/s $\color{#d91a1a}-0.48\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9448ms 0.6809ms 1.4685 KOps/s 1.4839 KOps/s $\color{#d91a1a}-1.04\%$
test_dqn_speed 8.7403ms 1.4803ms 675.5417 Ops/s 681.0738 Ops/s $\color{#d91a1a}-0.81\%$
test_ddpg_speed 3.0905ms 2.7946ms 357.8375 Ops/s 361.8927 Ops/s $\color{#d91a1a}-1.12\%$
test_sac_speed 8.7773ms 8.2696ms 120.9252 Ops/s 122.2071 Ops/s $\color{#d91a1a}-1.05\%$
test_redq_speed 13.1389ms 10.9576ms 91.2608 Ops/s 93.8193 Ops/s $\color{#d91a1a}-2.73\%$
test_redq_deprec_speed 17.2878ms 11.5694ms 86.4351 Ops/s 90.5931 Ops/s $\color{#d91a1a}-4.59\%$
test_td3_speed 8.5158ms 8.1908ms 122.0876 Ops/s 122.4883 Ops/s $\color{#d91a1a}-0.33\%$
test_cql_speed 28.4814ms 26.4563ms 37.7982 Ops/s 37.5949 Ops/s $\color{#35bf28}+0.54\%$
test_a2c_speed 6.0166ms 5.7773ms 173.0907 Ops/s 177.2338 Ops/s $\color{#d91a1a}-2.34\%$
test_ppo_speed 7.1331ms 6.1281ms 163.1819 Ops/s 165.6774 Ops/s $\color{#d91a1a}-1.51\%$
test_reinforce_speed 5.0058ms 4.6564ms 214.7582 Ops/s 220.1697 Ops/s $\color{#d91a1a}-2.46\%$
test_iql_speed 20.9891ms 20.1703ms 49.5777 Ops/s 50.5723 Ops/s $\color{#d91a1a}-1.97\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.1456ms 2.9496ms 339.0329 Ops/s 342.3422 Ops/s $\color{#d91a1a}-0.97\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6949ms 0.5570ms 1.7953 KOps/s 1.7862 KOps/s $\color{#35bf28}+0.51\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7580ms 0.5321ms 1.8792 KOps/s 1.8485 KOps/s $\color{#35bf28}+1.66\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.2982ms 2.9623ms 337.5714 Ops/s 337.5893 Ops/s $-0.01\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6576ms 0.5455ms 1.8331 KOps/s 1.8218 KOps/s $\color{#35bf28}+0.62\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.1136s 0.6368ms 1.5704 KOps/s 1.8655 KOps/s $\textbf{\color{#d91a1a}-15.82\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.7212ms 1.5764ms 634.3547 Ops/s 630.4050 Ops/s $\color{#35bf28}+0.63\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.6905ms 1.5108ms 661.8862 Ops/s 662.0365 Ops/s $\color{#d91a1a}-0.02\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2339ms 3.0594ms 326.8664 Ops/s 331.1774 Ops/s $\color{#d91a1a}-1.30\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.4107ms 0.6856ms 1.4585 KOps/s 1.2970 KOps/s $\textbf{\color{#35bf28}+12.45\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8304ms 0.6649ms 1.5040 KOps/s 1.5193 KOps/s $\color{#d91a1a}-1.01\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.0939ms 2.9802ms 335.5519 Ops/s 340.8401 Ops/s $\color{#d91a1a}-1.55\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6995ms 0.5550ms 1.8019 KOps/s 1.8201 KOps/s $\color{#d91a1a}-1.00\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 5.2461ms 0.5395ms 1.8535 KOps/s 1.8652 KOps/s $\color{#d91a1a}-0.63\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.2594ms 2.9939ms 334.0177 Ops/s 336.9611 Ops/s $\color{#d91a1a}-0.87\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6490ms 0.5463ms 1.8304 KOps/s 1.8282 KOps/s $\color{#35bf28}+0.12\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7055ms 0.5215ms 1.9177 KOps/s 1.9118 KOps/s $\color{#35bf28}+0.30\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2214ms 3.0923ms 323.3824 Ops/s 325.5507 Ops/s $\color{#d91a1a}-0.67\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7744ms 0.6831ms 1.4639 KOps/s 1.4761 KOps/s $\color{#d91a1a}-0.83\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7992ms 0.6643ms 1.5053 KOps/s 1.5156 KOps/s $\color{#d91a1a}-0.68\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1235s 7.2588ms 137.7645 Ops/s 104.6641 Ops/s $\textbf{\color{#35bf28}+31.63\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 21.9521ms 15.0982ms 66.2330 Ops/s 67.3921 Ops/s $\color{#d91a1a}-1.72\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.3108ms 1.1522ms 867.9329 Ops/s 881.9173 Ops/s $\color{#d91a1a}-1.59\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1077s 8.8832ms 112.5725 Ops/s 144.3901 Ops/s $\textbf{\color{#d91a1a}-22.04\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 17.3213ms 15.0477ms 66.4552 Ops/s 66.4772 Ops/s $\color{#d91a1a}-0.03\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 2.2068ms 1.1172ms 895.0864 Ops/s 874.5540 Ops/s $\color{#35bf28}+2.35\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1052s 7.2446ms 138.0346 Ops/s 105.2085 Ops/s $\textbf{\color{#35bf28}+31.20\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 17.7174ms 15.2133ms 65.7318 Ops/s 64.2868 Ops/s $\color{#35bf28}+2.25\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.5791ms 1.4854ms 673.2060 Ops/s 667.7749 Ops/s $\color{#35bf28}+0.81\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 91. Improved: $\large\color{#35bf28}7$. Worsened: $\large\color{#d91a1a}9$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 54.3325ms 53.9144ms 18.5479 Ops/s 17.9056 Ops/s $\color{#35bf28}+3.59\%$
test_sync 35.0961ms 29.4733ms 33.9290 Ops/s 32.9175 Ops/s $\color{#35bf28}+3.07\%$
test_async 50.3925ms 27.0478ms 36.9716 Ops/s 35.6329 Ops/s $\color{#35bf28}+3.76\%$
test_simple 0.3949s 0.3456s 2.8932 Ops/s 3.0821 Ops/s $\textbf{\color{#d91a1a}-6.13\%}$
test_transformed 0.5170s 0.4694s 2.1302 Ops/s 2.1233 Ops/s $\color{#35bf28}+0.32\%$
test_serial 1.2387s 1.1891s 0.8409 Ops/s 0.8483 Ops/s $\color{#d91a1a}-0.86\%$
test_parallel 1.0891s 1.0466s 0.9554 Ops/s 0.9750 Ops/s $\color{#d91a1a}-2.00\%$
test_step_mdp_speed[True-True-True-True-True] 0.1412ms 21.2884μs 46.9740 KOps/s 46.4891 KOps/s $\color{#35bf28}+1.04\%$
test_step_mdp_speed[True-True-True-True-False] 45.5540μs 12.9262μs 77.3620 KOps/s 76.7140 KOps/s $\color{#35bf28}+0.84\%$
test_step_mdp_speed[True-True-True-False-True] 51.5160μs 12.6493μs 79.0561 KOps/s 80.1397 KOps/s $\color{#d91a1a}-1.35\%$
test_step_mdp_speed[True-True-True-False-False] 30.4970μs 7.5446μs 132.5450 KOps/s 131.7553 KOps/s $\color{#35bf28}+0.60\%$
test_step_mdp_speed[True-True-False-True-True] 49.2520μs 22.8436μs 43.7760 KOps/s 43.9015 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[True-True-False-True-False] 40.3750μs 14.2889μs 69.9845 KOps/s 69.8240 KOps/s $\color{#35bf28}+0.23\%$
test_step_mdp_speed[True-True-False-False-True] 39.5730μs 13.8541μs 72.1807 KOps/s 73.1977 KOps/s $\color{#d91a1a}-1.39\%$
test_step_mdp_speed[True-True-False-False-False] 30.4160μs 8.8949μs 112.4243 KOps/s 113.4414 KOps/s $\color{#d91a1a}-0.90\%$
test_step_mdp_speed[True-False-True-True-True] 70.5910μs 24.0698μs 41.5459 KOps/s 41.7937 KOps/s $\color{#d91a1a}-0.59\%$
test_step_mdp_speed[True-False-True-True-False] 36.1180μs 15.5939μs 64.1275 KOps/s 64.6374 KOps/s $\color{#d91a1a}-0.79\%$
test_step_mdp_speed[True-False-True-False-True] 47.6790μs 13.7605μs 72.6718 KOps/s 73.0368 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[True-False-True-False-False] 27.2010μs 8.8371μs 113.1598 KOps/s 113.2002 KOps/s $\color{#d91a1a}-0.04\%$
test_step_mdp_speed[True-False-False-True-True] 53.9700μs 25.4915μs 39.2287 KOps/s 39.5941 KOps/s $\color{#d91a1a}-0.92\%$
test_step_mdp_speed[True-False-False-True-False] 45.9160μs 16.8811μs 59.2379 KOps/s 59.2275 KOps/s $\color{#35bf28}+0.02\%$
test_step_mdp_speed[True-False-False-False-True] 39.8840μs 14.9324μs 66.9686 KOps/s 67.2323 KOps/s $\color{#d91a1a}-0.39\%$
test_step_mdp_speed[True-False-False-False-False] 30.9480μs 10.0970μs 99.0390 KOps/s 100.4958 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[False-True-True-True-True] 50.7750μs 24.0425μs 41.5931 KOps/s 41.8002 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[False-True-True-True-False] 45.3450μs 15.6782μs 63.7827 KOps/s 63.7086 KOps/s $\color{#35bf28}+0.12\%$
test_step_mdp_speed[False-True-True-False-True] 57.3570μs 16.1458μs 61.9354 KOps/s 62.3646 KOps/s $\color{#d91a1a}-0.69\%$
test_step_mdp_speed[False-True-True-False-False] 42.7000μs 10.1176μs 98.8372 KOps/s 99.2417 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[False-True-False-True-True] 41.6370μs 25.6444μs 38.9948 KOps/s 39.7831 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[False-True-False-True-False] 43.8520μs 16.7862μs 59.5728 KOps/s 59.2579 KOps/s $\color{#35bf28}+0.53\%$
test_step_mdp_speed[False-True-False-False-True] 38.7830μs 17.0986μs 58.4842 KOps/s 58.1253 KOps/s $\color{#35bf28}+0.62\%$
test_step_mdp_speed[False-True-False-False-False] 30.5970μs 11.2236μs 89.0980 KOps/s 89.1815 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[False-False-True-True-True] 78.8370μs 26.5225μs 37.7038 KOps/s 38.0814 KOps/s $\color{#d91a1a}-0.99\%$
test_step_mdp_speed[False-False-True-True-False] 51.6660μs 18.2105μs 54.9133 KOps/s 55.2241 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[False-False-True-False-True] 44.5530μs 17.2685μs 57.9089 KOps/s 58.6492 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[False-False-True-False-False] 33.3620μs 11.3290μs 88.2688 KOps/s 89.4220 KOps/s $\color{#d91a1a}-1.29\%$
test_step_mdp_speed[False-False-False-True-True] 66.4140μs 27.5494μs 36.2984 KOps/s 36.5101 KOps/s $\color{#d91a1a}-0.58\%$
test_step_mdp_speed[False-False-False-True-False] 76.1020μs 19.4040μs 51.5357 KOps/s 52.3634 KOps/s $\color{#d91a1a}-1.58\%$
test_step_mdp_speed[False-False-False-False-True] 51.2160μs 18.3108μs 54.6125 KOps/s 55.6078 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[False-False-False-False-False] 39.6640μs 12.5196μs 79.8745 KOps/s 81.4577 KOps/s $\color{#d91a1a}-1.94\%$
test_values[generalized_advantage_estimate-True-True] 9.4000ms 9.0277ms 110.7707 Ops/s 109.5606 Ops/s $\color{#35bf28}+1.10\%$
test_values[vec_generalized_advantage_estimate-True-True] 36.7626ms 35.1972ms 28.4113 Ops/s 30.3987 Ops/s $\textbf{\color{#d91a1a}-6.54\%}$
test_values[td0_return_estimate-False-False] 0.2398ms 0.1639ms 6.0995 KOps/s 6.0996 KOps/s $-0.00\%$
test_values[td1_return_estimate-False-False] 24.7338ms 22.6297ms 44.1898 Ops/s 44.3219 Ops/s $\color{#d91a1a}-0.30\%$
test_values[vec_td1_return_estimate-False-False] 38.0664ms 35.4253ms 28.2284 Ops/s 30.3232 Ops/s $\textbf{\color{#d91a1a}-6.91\%}$
test_values[td_lambda_return_estimate-True-False] 35.6918ms 32.7643ms 30.5211 Ops/s 30.3384 Ops/s $\color{#35bf28}+0.60\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.5252ms 35.3763ms 28.2675 Ops/s 30.2935 Ops/s $\textbf{\color{#d91a1a}-6.69\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.6507ms 8.1638ms 122.4924 Ops/s 123.2963 Ops/s $\color{#d91a1a}-0.65\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3026ms 1.7900ms 558.6690 Ops/s 494.5399 Ops/s $\textbf{\color{#35bf28}+12.97\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4278ms 0.3532ms 2.8312 KOps/s 2.8690 KOps/s $\color{#d91a1a}-1.32\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 49.1494ms 47.3878ms 21.1025 Ops/s 25.2182 Ops/s $\textbf{\color{#d91a1a}-16.32\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7483ms 3.0119ms 332.0168 Ops/s 331.5458 Ops/s $\color{#35bf28}+0.14\%$
test_dqn_speed 3.4934ms 1.3231ms 755.8222 Ops/s 748.4819 Ops/s $\color{#35bf28}+0.98\%$
test_ddpg_speed 2.9712ms 2.6375ms 379.1440 Ops/s 378.7417 Ops/s $\color{#35bf28}+0.11\%$
test_sac_speed 9.1414ms 8.0880ms 123.6392 Ops/s 120.9459 Ops/s $\color{#35bf28}+2.23\%$
test_redq_speed 14.4908ms 12.9860ms 77.0062 Ops/s 78.9240 Ops/s $\color{#d91a1a}-2.43\%$
test_redq_deprec_speed 14.0712ms 12.7873ms 78.2024 Ops/s 78.6478 Ops/s $\color{#d91a1a}-0.57\%$
test_td3_speed 8.1903ms 8.0044ms 124.9316 Ops/s 123.8769 Ops/s $\color{#35bf28}+0.85\%$
test_cql_speed 0.1031s 38.7694ms 25.7935 Ops/s 27.4817 Ops/s $\textbf{\color{#d91a1a}-6.14\%}$
test_a2c_speed 8.4040ms 7.2779ms 137.4026 Ops/s 135.4756 Ops/s $\color{#35bf28}+1.42\%$
test_ppo_speed 8.4475ms 7.5461ms 132.5180 Ops/s 132.1706 Ops/s $\color{#35bf28}+0.26\%$
test_reinforce_speed 7.8342ms 6.5107ms 153.5941 Ops/s 153.6102 Ops/s $\color{#d91a1a}-0.01\%$
test_iql_speed 32.3863ms 31.9923ms 31.2575 Ops/s 31.3698 Ops/s $\color{#d91a1a}-0.36\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.3240ms 2.0865ms 479.2706 Ops/s 444.3975 Ops/s $\textbf{\color{#35bf28}+7.85\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1017ms 0.4942ms 2.0235 KOps/s 1.9674 KOps/s $\color{#35bf28}+2.85\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.8249ms 0.4671ms 2.1408 KOps/s 2.0768 KOps/s $\color{#35bf28}+3.08\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 2.9869ms 2.0963ms 477.0270 Ops/s 424.6537 Ops/s $\textbf{\color{#35bf28}+12.33\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6839ms 0.4848ms 2.0627 KOps/s 2.0186 KOps/s $\color{#35bf28}+2.19\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 3.6349ms 0.4611ms 2.1688 KOps/s 2.1840 KOps/s $\color{#d91a1a}-0.70\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 2.2519ms 1.2962ms 771.4770 Ops/s 768.7107 Ops/s $\color{#35bf28}+0.36\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 4.2946ms 1.2243ms 816.8102 Ops/s 816.2744 Ops/s $\color{#35bf28}+0.07\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 2.4369ms 2.2129ms 451.8960 Ops/s 442.6284 Ops/s $\color{#35bf28}+2.09\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.2656ms 0.6062ms 1.6497 KOps/s 1.6400 KOps/s $\color{#35bf28}+0.59\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 89.6066ms 0.6500ms 1.5385 KOps/s 1.7039 KOps/s $\textbf{\color{#d91a1a}-9.71\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 2.2057ms 2.0976ms 476.7390 Ops/s 463.8406 Ops/s $\color{#35bf28}+2.78\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.1234ms 0.4984ms 2.0064 KOps/s 2.0165 KOps/s $\color{#d91a1a}-0.50\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6314ms 0.4677ms 2.1383 KOps/s 2.1125 KOps/s $\color{#35bf28}+1.22\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1079ms 2.1471ms 465.7474 Ops/s 467.7473 Ops/s $\color{#d91a1a}-0.43\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9930ms 0.4860ms 2.0575 KOps/s 2.0337 KOps/s $\color{#35bf28}+1.17\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 93.7145ms 0.5762ms 1.7354 KOps/s 2.1529 KOps/s $\textbf{\color{#d91a1a}-19.39\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.2841ms 2.2207ms 450.2996 Ops/s 426.5069 Ops/s $\textbf{\color{#35bf28}+5.58\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.6996ms 0.6052ms 1.6525 KOps/s 1.5379 KOps/s $\textbf{\color{#35bf28}+7.45\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9323ms 0.5912ms 1.6915 KOps/s 1.7048 KOps/s $\color{#d91a1a}-0.78\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 85.0806ms 6.9568ms 143.7447 Ops/s 135.1984 Ops/s $\textbf{\color{#35bf28}+6.32\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 14.8155ms 11.9843ms 83.4422 Ops/s 84.2427 Ops/s $\color{#d91a1a}-0.95\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 1.0636ms 1.0099ms 990.2141 Ops/s 949.8751 Ops/s $\color{#35bf28}+4.25\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 87.0311ms 5.3847ms 185.7106 Ops/s 140.9893 Ops/s $\textbf{\color{#35bf28}+31.72\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 90.4216ms 13.9468ms 71.7010 Ops/s 84.3988 Ops/s $\textbf{\color{#d91a1a}-15.04\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 1.7829ms 1.0748ms 930.3727 Ops/s 941.4407 Ops/s $\color{#d91a1a}-1.18\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 87.7076ms 5.7250ms 174.6719 Ops/s 175.1270 Ops/s $\color{#d91a1a}-0.26\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 14.6187ms 12.2435ms 81.6757 Ops/s 81.5473 Ops/s $\color{#35bf28}+0.16\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 2.1286ms 1.3689ms 730.4969 Ops/s 739.3492 Ops/s $\color{#d91a1a}-1.20\%$

vmoens added a commit that referenced this pull request Mar 25, 2024
@vmoens
[BugFix] Fix CQL/IQL pbar update (#2020)
47c1e1c 
(cherry picked from commit 9747170)
vmoens added a commit that referenced this pull request Apr 7, 2024
@vmoens
[BugFix] Fix CQL/IQL pbar update (#2020)
55b3d99 
(cherry picked from commit 9747170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Very minor: Progress bar in CQL is broken
2 participants
@vmoens @facebook-github-bot