Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix, Performance] Fewer imports at root #1930

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[BugFix, Performance] Fewer imports at root #1930

merged 1 commit into from
Feb 19, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Feb 19, 2024 •
edited
Loading

cc @teopir

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1930

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit ccc03c1 with merge base d68a900 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2024
@vmoens vmoens added bug Something isn't working performance Performance issue or suggestion for improvement Suitable for minor Suitable to be integrated in minor release (no new feature) labels Feb 19, 2024
@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}3$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 77.1813ms 62.4426ms 16.0147 Ops/s 16.1548 Ops/s $\color{#d91a1a}-0.87\%$
test_sync 39.6551ms 33.1034ms 30.2083 Ops/s 28.4855 Ops/s $\textbf{\color{#35bf28}+6.05\%}$
test_async 0.1339s 32.3365ms 30.9248 Ops/s 30.6020 Ops/s $\color{#35bf28}+1.05\%$
test_simple 0.4989s 0.4337s 2.3057 Ops/s 2.2635 Ops/s $\color{#35bf28}+1.87\%$
test_transformed 0.6460s 0.5829s 1.7157 Ops/s 1.7005 Ops/s $\color{#35bf28}+0.89\%$
test_serial 1.4580s 1.3998s 0.7144 Ops/s 0.7024 Ops/s $\color{#35bf28}+1.70\%$
test_parallel 1.4640s 1.4015s 0.7135 Ops/s 0.6985 Ops/s $\color{#35bf28}+2.15\%$
test_step_mdp_speed[True-True-True-True-True] 0.1424ms 21.1662μs 47.2451 KOps/s 47.0958 KOps/s $\color{#35bf28}+0.32\%$
test_step_mdp_speed[True-True-True-True-False] 59.4610μs 13.2491μs 75.4768 KOps/s 78.0930 KOps/s $\color{#d91a1a}-3.35\%$
test_step_mdp_speed[True-True-True-False-True] 37.8500μs 12.4414μs 80.3770 KOps/s 81.1608 KOps/s $\color{#d91a1a}-0.97\%$
test_step_mdp_speed[True-True-True-False-False] 49.8630μs 7.5898μs 131.7558 KOps/s 132.7473 KOps/s $\color{#d91a1a}-0.75\%$
test_step_mdp_speed[True-True-False-True-True] 52.4980μs 22.5289μs 44.3875 KOps/s 44.4574 KOps/s $\color{#d91a1a}-0.16\%$
test_step_mdp_speed[True-True-False-True-False] 70.6220μs 14.3177μs 69.8435 KOps/s 70.2174 KOps/s $\color{#d91a1a}-0.53\%$
test_step_mdp_speed[True-True-False-False-True] 40.8060μs 13.5620μs 73.7354 KOps/s 72.6372 KOps/s $\color{#35bf28}+1.51\%$
test_step_mdp_speed[True-True-False-False-False] 50.0530μs 8.7557μs 114.2116 KOps/s 115.1665 KOps/s $\color{#d91a1a}-0.83\%$
test_step_mdp_speed[True-False-True-True-True] 64.9110μs 23.9570μs 41.7415 KOps/s 42.0008 KOps/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[True-False-True-True-False] 56.4350μs 15.5891μs 64.1474 KOps/s 64.5061 KOps/s $\color{#d91a1a}-0.56\%$
test_step_mdp_speed[True-False-True-False-True] 59.6410μs 13.6241μs 73.3995 KOps/s 73.3355 KOps/s $\color{#35bf28}+0.09\%$
test_step_mdp_speed[True-False-True-False-False] 50.4950μs 8.7663μs 114.0726 KOps/s 114.1090 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[True-False-False-True-True] 56.1250μs 24.8613μs 40.2232 KOps/s 40.3872 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[True-False-False-True-False] 58.3490μs 16.8935μs 59.1942 KOps/s 60.2731 KOps/s $\color{#d91a1a}-1.79\%$
test_step_mdp_speed[True-False-False-False-True] 69.6680μs 14.4378μs 69.2625 KOps/s 68.0549 KOps/s $\color{#35bf28}+1.77\%$
test_step_mdp_speed[True-False-False-False-False] 36.9490μs 9.9417μs 100.5861 KOps/s 100.6724 KOps/s $\color{#d91a1a}-0.09\%$
test_step_mdp_speed[False-True-True-True-True] 69.4200μs 23.9510μs 41.7519 KOps/s 42.0791 KOps/s $\color{#d91a1a}-0.78\%$
test_step_mdp_speed[False-True-True-True-False] 39.3740μs 15.6178μs 64.0296 KOps/s 64.8516 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[False-True-True-False-True] 67.0650μs 15.7602μs 63.4511 KOps/s 63.7146 KOps/s $\color{#d91a1a}-0.41\%$
test_step_mdp_speed[False-True-True-False-False] 37.6700μs 10.0282μs 99.7185 KOps/s 100.9999 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[False-True-False-True-True] 50.6740μs 25.2055μs 39.6739 KOps/s 39.7207 KOps/s $\color{#d91a1a}-0.12\%$
test_step_mdp_speed[False-True-False-True-False] 63.2780μs 16.8952μs 59.1884 KOps/s 60.3834 KOps/s $\color{#d91a1a}-1.98\%$
test_step_mdp_speed[False-True-False-False-True] 48.9020μs 17.0122μs 58.7812 KOps/s 58.5203 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[False-True-False-False-False] 60.2220μs 11.1645μs 89.5696 KOps/s 89.8546 KOps/s $\color{#d91a1a}-0.32\%$
test_step_mdp_speed[False-False-True-True-True] 60.1030μs 26.1903μs 38.1820 KOps/s 37.9176 KOps/s $\color{#35bf28}+0.70\%$
test_step_mdp_speed[False-False-True-True-False] 64.4200μs 18.1929μs 54.9663 KOps/s 56.1913 KOps/s $\color{#d91a1a}-2.18\%$
test_step_mdp_speed[False-False-True-False-True] 72.5150μs 17.0559μs 58.6307 KOps/s 58.7074 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[False-False-True-False-False] 55.2340μs 11.2448μs 88.9302 KOps/s 89.3177 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[False-False-False-True-True] 79.9300μs 27.1444μs 36.8400 KOps/s 36.5689 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-False-False-True-False] 41.8980μs 19.3210μs 51.7571 KOps/s 52.3542 KOps/s $\color{#d91a1a}-1.14\%$
test_step_mdp_speed[False-False-False-False-True] 71.1030μs 17.9725μs 55.6406 KOps/s 55.2717 KOps/s $\color{#35bf28}+0.67\%$
test_step_mdp_speed[False-False-False-False-False] 35.4150μs 12.3457μs 80.9997 KOps/s 82.5424 KOps/s $\color{#d91a1a}-1.87\%$
test_values[generalized_advantage_estimate-True-True] 9.5775ms 9.2487ms 108.1237 Ops/s 105.2936 Ops/s $\color{#35bf28}+2.69\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.0660ms 35.5342ms 28.1419 Ops/s 29.9139 Ops/s $\textbf{\color{#d91a1a}-5.92\%}$
test_values[td0_return_estimate-False-False] 0.2321ms 0.1716ms 5.8276 KOps/s 5.6299 KOps/s $\color{#35bf28}+3.51\%$
test_values[td1_return_estimate-False-False] 23.4620ms 23.0142ms 43.4515 Ops/s 42.7454 Ops/s $\color{#35bf28}+1.65\%$
test_values[vec_td1_return_estimate-False-False] 37.8747ms 35.5686ms 28.1147 Ops/s 29.9232 Ops/s $\textbf{\color{#d91a1a}-6.04\%}$
test_values[td_lambda_return_estimate-True-False] 34.6660ms 33.1716ms 30.1463 Ops/s 29.3220 Ops/s $\color{#35bf28}+2.81\%$
test_values[vec_td_lambda_return_estimate-True-False] 40.1336ms 35.6392ms 28.0590 Ops/s 29.9046 Ops/s $\textbf{\color{#d91a1a}-6.17\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.5222ms 7.9399ms 125.9454 Ops/s 124.1059 Ops/s $\color{#35bf28}+1.48\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.3900ms 2.0115ms 497.1459 Ops/s 557.9026 Ops/s $\textbf{\color{#d91a1a}-10.89\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4818ms 0.3454ms 2.8956 KOps/s 2.7841 KOps/s $\color{#35bf28}+4.00\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 47.6408ms 46.5997ms 21.4594 Ops/s 24.4879 Ops/s $\textbf{\color{#d91a1a}-12.37\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.7543ms 3.0369ms 329.2800 Ops/s 328.8888 Ops/s $\color{#35bf28}+0.12\%$
test_dqn_speed 7.7664ms 1.3537ms 738.7043 Ops/s 728.9566 Ops/s $\color{#35bf28}+1.34\%$
test_ddpg_speed 81.9793ms 2.9402ms 340.1092 Ops/s 365.7825 Ops/s $\textbf{\color{#d91a1a}-7.02\%}$
test_sac_speed 9.2225ms 8.5204ms 117.3656 Ops/s 115.6117 Ops/s $\color{#35bf28}+1.52\%$
test_redq_speed 14.4565ms 13.3810ms 74.7326 Ops/s 73.4909 Ops/s $\color{#35bf28}+1.69\%$
test_redq_deprec_speed 15.5736ms 13.7575ms 72.6875 Ops/s 70.4498 Ops/s $\color{#35bf28}+3.18\%$
test_td3_speed 9.2516ms 8.5773ms 116.5871 Ops/s 114.1938 Ops/s $\color{#35bf28}+2.10\%$
test_cql_speed 38.2346ms 36.9213ms 27.0847 Ops/s 26.6514 Ops/s $\color{#35bf28}+1.63\%$
test_a2c_speed 8.0301ms 7.4890ms 133.5284 Ops/s 132.8407 Ops/s $\color{#35bf28}+0.52\%$
test_ppo_speed 9.1317ms 7.8193ms 127.8892 Ops/s 127.9296 Ops/s $\color{#d91a1a}-0.03\%$
test_reinforce_speed 7.4579ms 6.6319ms 150.7858 Ops/s 148.6348 Ops/s $\color{#35bf28}+1.45\%$
test_iql_speed 34.5330ms 33.3300ms 30.0030 Ops/s 29.7064 Ops/s $\color{#35bf28}+1.00\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.5189ms 2.9253ms 341.8396 Ops/s 349.4497 Ops/s $\color{#d91a1a}-2.18\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8243ms 0.5183ms 1.9293 KOps/s 1.9187 KOps/s $\color{#35bf28}+0.55\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7485ms 0.4907ms 2.0378 KOps/s 2.0162 KOps/s $\color{#35bf28}+1.07\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.2828ms 2.9767ms 335.9455 Ops/s 336.5426 Ops/s $\color{#d91a1a}-0.18\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8514ms 0.5107ms 1.9583 KOps/s 1.8928 KOps/s $\color{#35bf28}+3.46\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.9192ms 0.4871ms 2.0530 KOps/s 2.0166 KOps/s $\color{#35bf28}+1.80\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.5578ms 3.0154ms 331.6305 Ops/s 327.8201 Ops/s $\color{#35bf28}+1.16\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9898ms 0.6369ms 1.5701 KOps/s 1.4908 KOps/s $\textbf{\color{#35bf28}+5.32\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9252ms 0.6112ms 1.6361 KOps/s 1.6303 KOps/s $\color{#35bf28}+0.35\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 4.1570ms 2.8653ms 349.0067 Ops/s 345.0762 Ops/s $\color{#35bf28}+1.14\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6413ms 0.5143ms 1.9446 KOps/s 1.8973 KOps/s $\color{#35bf28}+2.49\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6280ms 0.4925ms 2.0305 KOps/s 2.0044 KOps/s $\color{#35bf28}+1.30\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.3931ms 2.9790ms 335.6870 Ops/s 339.9983 Ops/s $\color{#d91a1a}-1.27\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9970ms 0.5186ms 1.9284 KOps/s 1.9348 KOps/s $\color{#d91a1a}-0.33\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6319ms 0.4956ms 2.0177 KOps/s 2.0133 KOps/s $\color{#35bf28}+0.21\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 4.3846ms 3.0292ms 330.1224 Ops/s 334.1912 Ops/s $\color{#d91a1a}-1.22\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7534ms 0.6373ms 1.5692 KOps/s 1.5516 KOps/s $\color{#35bf28}+1.13\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7457ms 0.6093ms 1.6412 KOps/s 1.6180 KOps/s $\color{#35bf28}+1.43\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1128s 10.2620ms 97.4474 Ops/s 122.8761 Ops/s $\textbf{\color{#d91a1a}-20.69\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.4134ms 13.2660ms 75.3807 Ops/s 75.8188 Ops/s $\color{#d91a1a}-0.58\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 3.8247ms 2.4800ms 403.2275 Ops/s 393.4701 Ops/s $\color{#35bf28}+2.48\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1132s 10.3555ms 96.5675 Ops/s 98.8818 Ops/s $\color{#d91a1a}-2.34\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 16.1835ms 13.3082ms 75.1417 Ops/s 75.4678 Ops/s $\color{#d91a1a}-0.43\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 4.0372ms 2.4835ms 402.6551 Ops/s 391.0128 Ops/s $\color{#35bf28}+2.98\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1047s 8.3566ms 119.6658 Ops/s 114.2926 Ops/s $\color{#35bf28}+4.70\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.6744ms 13.5875ms 73.5969 Ops/s 64.4574 Ops/s $\textbf{\color{#35bf28}+14.18\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.7899ms 2.7964ms 357.5967 Ops/s 360.3766 Ops/s $\color{#d91a1a}-0.77\%$

@github-actions GitHub Actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1861s 0.1221s 8.1867 Ops/s 8.7818 Ops/s $\textbf{\color{#d91a1a}-6.78\%}$
test_sync 95.4211ms 95.1642ms 10.5082 Ops/s 9.7820 Ops/s $\textbf{\color{#35bf28}+7.42\%}$
test_async 0.2482s 91.3767ms 10.9437 Ops/s 10.9225 Ops/s $\color{#35bf28}+0.19\%$
test_single_pixels 0.1277s 0.1252s 7.9896 Ops/s 7.8524 Ops/s $\color{#35bf28}+1.75\%$
test_sync_pixels 81.5859ms 79.8611ms 12.5217 Ops/s 12.3896 Ops/s $\color{#35bf28}+1.07\%$
test_async_pixels 0.1496s 74.4893ms 13.4247 Ops/s 13.6774 Ops/s $\color{#d91a1a}-1.85\%$
test_simple 0.8872s 0.8231s 1.2149 Ops/s 1.2139 Ops/s $\color{#35bf28}+0.08\%$
test_transformed 1.1130s 1.0492s 0.9531 Ops/s 0.9388 Ops/s $\color{#35bf28}+1.52\%$
test_serial 2.4574s 2.3942s 0.4177 Ops/s 0.4091 Ops/s $\color{#35bf28}+2.10\%$
test_parallel 2.1144s 2.0505s 0.4877 Ops/s 0.4742 Ops/s $\color{#35bf28}+2.84\%$
test_step_mdp_speed[True-True-True-True-True] 75.2910μs 33.0756μs 30.2337 KOps/s 29.9354 KOps/s $\color{#35bf28}+1.00\%$
test_step_mdp_speed[True-True-True-True-False] 38.5400μs 20.0057μs 49.9858 KOps/s 50.7256 KOps/s $\color{#d91a1a}-1.46\%$
test_step_mdp_speed[True-True-True-False-True] 35.1900μs 18.7606μs 53.3032 KOps/s 53.1723 KOps/s $\color{#35bf28}+0.25\%$
test_step_mdp_speed[True-True-True-False-False] 34.6210μs 11.3113μs 88.4069 KOps/s 88.5820 KOps/s $\color{#d91a1a}-0.20\%$
test_step_mdp_speed[True-True-False-True-True] 58.5100μs 34.8051μs 28.7315 KOps/s 28.8156 KOps/s $\color{#d91a1a}-0.29\%$
test_step_mdp_speed[True-True-False-True-False] 47.5310μs 21.4473μs 46.6259 KOps/s 46.6798 KOps/s $\color{#d91a1a}-0.12\%$
test_step_mdp_speed[True-True-False-False-True] 37.5300μs 20.2052μs 49.4923 KOps/s 48.9285 KOps/s $\color{#35bf28}+1.15\%$
test_step_mdp_speed[True-True-False-False-False] 35.3110μs 13.0925μs 76.3796 KOps/s 76.3572 KOps/s $\color{#35bf28}+0.03\%$
test_step_mdp_speed[True-False-True-True-True] 61.9610μs 37.3893μs 26.7456 KOps/s 27.0488 KOps/s $\color{#d91a1a}-1.12\%$
test_step_mdp_speed[True-False-True-True-False] 45.0100μs 23.7496μs 42.1059 KOps/s 42.1184 KOps/s $\color{#d91a1a}-0.03\%$
test_step_mdp_speed[True-False-True-False-True] 46.4000μs 20.4482μs 48.9041 KOps/s 48.9767 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[True-False-True-False-False] 41.8300μs 13.1582μs 75.9981 KOps/s 76.3297 KOps/s $\color{#d91a1a}-0.43\%$
test_step_mdp_speed[True-False-False-True-True] 61.5610μs 38.7815μs 25.7855 KOps/s 26.2909 KOps/s $\color{#d91a1a}-1.92\%$
test_step_mdp_speed[True-False-False-True-False] 48.5810μs 25.4790μs 39.2480 KOps/s 39.5654 KOps/s $\color{#d91a1a}-0.80\%$
test_step_mdp_speed[True-False-False-False-True] 37.8000μs 22.3526μs 44.7376 KOps/s 44.7423 KOps/s $\color{#d91a1a}-0.01\%$
test_step_mdp_speed[True-False-False-False-False] 33.8710μs 15.1090μs 66.1858 KOps/s 66.7776 KOps/s $\color{#d91a1a}-0.89\%$
test_step_mdp_speed[False-True-True-True-True] 62.4810μs 36.9795μs 27.0420 KOps/s 27.0385 KOps/s $\color{#35bf28}+0.01\%$
test_step_mdp_speed[False-True-True-True-False] 39.4900μs 23.7787μs 42.0545 KOps/s 42.3972 KOps/s $\color{#d91a1a}-0.81\%$
test_step_mdp_speed[False-True-True-False-True] 42.2510μs 24.2465μs 41.2431 KOps/s 41.0576 KOps/s $\color{#35bf28}+0.45\%$
test_step_mdp_speed[False-True-True-False-False] 35.8600μs 15.4223μs 64.8412 KOps/s 65.6052 KOps/s $\color{#d91a1a}-1.16\%$
test_step_mdp_speed[False-True-False-True-True] 63.5410μs 39.2245μs 25.4943 KOps/s 25.5271 KOps/s $\color{#d91a1a}-0.13\%$
test_step_mdp_speed[False-True-False-True-False] 50.7800μs 25.8223μs 38.7263 KOps/s 38.9399 KOps/s $\color{#d91a1a}-0.55\%$
test_step_mdp_speed[False-True-False-False-True] 50.4800μs 26.6083μs 37.5822 KOps/s 38.1211 KOps/s $\color{#d91a1a}-1.41\%$
test_step_mdp_speed[False-True-False-False-False] 35.0110μs 17.2549μs 57.9546 KOps/s 59.0930 KOps/s $\color{#d91a1a}-1.93\%$
test_step_mdp_speed[False-False-True-True-True] 63.6410μs 40.4309μs 24.7336 KOps/s 24.5258 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[False-False-True-True-False] 52.9720μs 27.3278μs 36.5928 KOps/s 36.2019 KOps/s $\color{#35bf28}+1.08\%$
test_step_mdp_speed[False-False-True-False-True] 48.7010μs 26.2490μs 38.0966 KOps/s 38.5045 KOps/s $\color{#d91a1a}-1.06\%$
test_step_mdp_speed[False-False-True-False-False] 42.5810μs 17.2871μs 57.8467 KOps/s 59.3797 KOps/s $\color{#d91a1a}-2.58\%$
test_step_mdp_speed[False-False-False-True-True] 71.7510μs 42.1991μs 23.6972 KOps/s 23.8423 KOps/s $\color{#d91a1a}-0.61\%$
test_step_mdp_speed[False-False-False-True-False] 55.9720μs 29.6557μs 33.7203 KOps/s 34.2179 KOps/s $\color{#d91a1a}-1.45\%$
test_step_mdp_speed[False-False-False-False-True] 45.3120μs 27.9958μs 35.7196 KOps/s 36.3050 KOps/s $\color{#d91a1a}-1.61\%$
test_step_mdp_speed[False-False-False-False-False] 42.3800μs 18.7901μs 53.2195 KOps/s 53.4100 KOps/s $\color{#d91a1a}-0.36\%$
test_values[generalized_advantage_estimate-True-True] 24.0152ms 23.4366ms 42.6682 Ops/s 41.7843 Ops/s $\color{#35bf28}+2.12\%$
test_values[vec_generalized_advantage_estimate-True-True] 82.0903ms 3.2008ms 312.4194 Ops/s 303.7285 Ops/s $\color{#35bf28}+2.86\%$
test_values[td0_return_estimate-False-False] 0.1154ms 60.6983μs 16.4749 KOps/s 16.4142 KOps/s $\color{#35bf28}+0.37\%$
test_values[td1_return_estimate-False-False] 54.6961ms 52.2565ms 19.1364 Ops/s 19.2494 Ops/s $\color{#d91a1a}-0.59\%$
test_values[vec_td1_return_estimate-False-False] 2.0731ms 1.7491ms 571.7283 Ops/s 570.5295 Ops/s $\color{#35bf28}+0.21\%$
test_values[td_lambda_return_estimate-True-False] 87.6915ms 84.9644ms 11.7696 Ops/s 12.0613 Ops/s $\color{#d91a1a}-2.42\%$
test_values[vec_td_lambda_return_estimate-True-False] 3.9074ms 1.7872ms 559.5214 Ops/s 558.3935 Ops/s $\color{#35bf28}+0.20\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 24.1216ms 23.4588ms 42.6279 Ops/s 43.2290 Ops/s $\color{#d91a1a}-1.39\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.8607ms 0.7125ms 1.4035 KOps/s 1.4375 KOps/s $\color{#d91a1a}-2.37\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.6952ms 0.6372ms 1.5693 KOps/s 1.5536 KOps/s $\color{#35bf28}+1.01\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4728ms 1.4451ms 692.0144 Ops/s 689.7140 Ops/s $\color{#35bf28}+0.33\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9214ms 0.6608ms 1.5133 KOps/s 1.5090 KOps/s $\color{#35bf28}+0.29\%$
test_dqn_speed 8.1023ms 1.4187ms 704.8877 Ops/s 709.5332 Ops/s $\color{#d91a1a}-0.65\%$
test_ddpg_speed 2.9111ms 2.7134ms 368.5368 Ops/s 371.8160 Ops/s $\color{#d91a1a}-0.88\%$
test_sac_speed 8.6881ms 8.2482ms 121.2380 Ops/s 120.2326 Ops/s $\color{#35bf28}+0.84\%$
test_redq_speed 11.1588ms 10.3530ms 96.5903 Ops/s 96.7563 Ops/s $\color{#d91a1a}-0.17\%$
test_redq_deprec_speed 11.9793ms 11.3543ms 88.0720 Ops/s 89.6561 Ops/s $\color{#d91a1a}-1.77\%$
test_td3_speed 8.5484ms 8.3850ms 119.2603 Ops/s 118.0424 Ops/s $\color{#35bf28}+1.03\%$
test_cql_speed 0.1132s 27.7381ms 36.0515 Ops/s 39.5201 Ops/s $\textbf{\color{#d91a1a}-8.78\%}$
test_a2c_speed 5.5665ms 5.3439ms 187.1294 Ops/s 186.7928 Ops/s $\color{#35bf28}+0.18\%$
test_ppo_speed 6.3453ms 5.6952ms 175.5880 Ops/s 176.0730 Ops/s $\color{#d91a1a}-0.28\%$
test_reinforce_speed 4.5828ms 4.3891ms 227.8353 Ops/s 228.1406 Ops/s $\color{#d91a1a}-0.13\%$
test_iql_speed 20.2437ms 19.5555ms 51.1366 Ops/s 50.7733 Ops/s $\color{#35bf28}+0.72\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7395ms 3.6044ms 277.4393 Ops/s 278.3983 Ops/s $\color{#d91a1a}-0.34\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7889ms 0.5659ms 1.7670 KOps/s 1.7575 KOps/s $\color{#35bf28}+0.54\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7668ms 0.5396ms 1.8532 KOps/s 1.8533 KOps/s $-0.00\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8801ms 3.6308ms 275.4194 Ops/s 277.1807 Ops/s $\color{#d91a1a}-0.64\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6970ms 0.5534ms 1.8070 KOps/s 1.7722 KOps/s $\color{#35bf28}+1.96\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6707ms 0.5336ms 1.8742 KOps/s 1.8732 KOps/s $\color{#35bf28}+0.05\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.8928ms 3.7380ms 267.5203 Ops/s 268.5980 Ops/s $\color{#d91a1a}-0.40\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9214ms 0.6863ms 1.4570 KOps/s 1.4318 KOps/s $\color{#35bf28}+1.76\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 99.2610ms 0.7431ms 1.3458 KOps/s 1.4991 KOps/s $\textbf{\color{#d91a1a}-10.23\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.7160ms 3.5924ms 278.3660 Ops/s 277.5692 Ops/s $\color{#35bf28}+0.29\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7040ms 0.5618ms 1.7801 KOps/s 1.7619 KOps/s $\color{#35bf28}+1.03\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6992ms 0.5381ms 1.8584 KOps/s 1.8473 KOps/s $\color{#35bf28}+0.60\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8074ms 3.6111ms 276.9275 Ops/s 275.1671 Ops/s $\color{#35bf28}+0.64\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.6841ms 0.5605ms 1.7841 KOps/s 1.7690 KOps/s $\color{#35bf28}+0.85\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7136ms 0.5328ms 1.8767 KOps/s 1.8590 KOps/s $\color{#35bf28}+0.95\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.9112ms 3.7309ms 268.0321 Ops/s 266.2707 Ops/s $\color{#35bf28}+0.66\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8212ms 0.6893ms 1.4509 KOps/s 1.4466 KOps/s $\color{#35bf28}+0.29\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.7816ms 0.6603ms 1.5146 KOps/s 1.4955 KOps/s $\color{#35bf28}+1.28\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1184s 9.8049ms 101.9902 Ops/s 100.4141 Ops/s $\color{#35bf28}+1.57\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 0.1194s 18.1601ms 55.0657 Ops/s 54.4111 Ops/s $\color{#35bf28}+1.20\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.9033ms 2.9565ms 338.2334 Ops/s 334.6025 Ops/s $\color{#35bf28}+1.09\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1114s 9.6326ms 103.8142 Ops/s 100.7568 Ops/s $\color{#35bf28}+3.03\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.3122ms 16.1589ms 61.8854 Ops/s 61.7668 Ops/s $\color{#35bf28}+0.19\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.4603ms 2.9801ms 335.5635 Ops/s 331.7534 Ops/s $\color{#35bf28}+1.15\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1124s 9.9195ms 100.8111 Ops/s 98.1919 Ops/s $\color{#35bf28}+2.67\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.6220ms 16.3774ms 61.0597 Ops/s 61.1746 Ops/s $\color{#d91a1a}-0.19\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 8.4326ms 3.2897ms 303.9789 Ops/s 301.0140 Ops/s $\color{#35bf28}+0.98\%$

@vmoens vmoens merged commit 4fd0343 into main Feb 19, 2024
60 of 68 checks passed
@vmoens vmoens deleted the hide-tv branch February 27, 2024 00:47
vmoens added a commit that referenced this pull request Feb 28, 2024
@vmoens
[BugFix, Performance] Fewer imports at root (#1930)
5e5c19e
@vmoens vmoens mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. performance Performance issue or suggestion for improvement Suitable for minor Suitable to be integrated in minor release (no new feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmoens @facebook-github-bot