[BugFix] make sure the params of exploration-wrapper is float #1700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we should make sure the params of exploration-wrapper is float, or the params decay maybe abnormal.
Motivation and Context
If the user passes an int into the wrapper (e.g. "1" instead of "1.0", like stupid me), the params will always be
0
and don't change throughout thestep
is called:result is
if we pass a float, the function of wrapper is normal:
result is
the reason of this bug is we use the type of
eps_init
as the type ofself.eps
.Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!