Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] MaxValueWriter cuda compatibility #1689

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

albertbou92
Copy link
Contributor

Description

When calling extend, a new tensor containing the new index values is created but its device was not specified, which caused problem when the data was in GPU. Now it is created in whatever device the data is.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

Copy link

pytorch-bot bot commented Nov 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1689

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 7 Unrelated Failures

As of commit fa3b951 with merge base 8ca7a39 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 9, 2023
@vmoens vmoens added the bug Something isn't working label Nov 9, 2023
@vmoens vmoens changed the title [Fix] fix bug in MaxValueWriter when extend is called and storage is in cuda device [BugFix] fix bug in MaxValueWriter when extend is called and storage is in cuda device Nov 9, 2023
@vmoens vmoens changed the title [BugFix] fix bug in MaxValueWriter when extend is called and storage is in cuda device [BugFix] MaxValueWriter cuda compatibility Nov 9, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@vmoens vmoens merged commit 760f5f1 into pytorch:main Nov 9, 2023
@vmoens vmoens deleted the quickfix_maxvalwriter branch November 9, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants