-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix submitit IP address/node name retrieval #1672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Name | Max | Mean | Ops | Ops on Repo HEAD
|
Change |
---|---|---|---|---|---|
test_single | 61.1055ms | 60.5040ms | 16.5278 Ops/s | 15.6501 Ops/s | |
test_sync | 39.5031ms | 34.2136ms | 29.2282 Ops/s | 26.3832 Ops/s | |
test_async | 61.3755ms | 31.0050ms | 32.2529 Ops/s | 31.7756 Ops/s | |
test_simple | 0.4793s | 0.4406s | 2.2697 Ops/s | 2.2860 Ops/s | |
test_transformed | 0.6309s | 0.5804s | 1.7230 Ops/s | 1.6441 Ops/s | |
test_serial | 1.2721s | 1.2269s | 0.8150 Ops/s | 0.7862 Ops/s | |
test_parallel | 1.2699s | 1.2255s | 0.8160 Ops/s | 0.8131 Ops/s | |
test_step_mdp_speed[True-True-True-True-True] | 0.1397ms | 25.0470μs | 39.9249 KOps/s | 40.2571 KOps/s | |
test_step_mdp_speed[True-True-True-True-False] | 42.3890μs | 14.8258μs | 67.4500 KOps/s | 66.8189 KOps/s | |
test_step_mdp_speed[True-True-True-False-True] | 41.9980μs | 15.3171μs | 65.2864 KOps/s | 64.1660 KOps/s | |
test_step_mdp_speed[True-True-True-False-False] | 28.2330μs | 8.9467μs | 111.7730 KOps/s | 109.3365 KOps/s | |
test_step_mdp_speed[True-True-False-True-True] | 60.4630μs | 26.2849μs | 38.0447 KOps/s | 37.0388 KOps/s | |
test_step_mdp_speed[True-True-False-True-False] | 55.5630μs | 16.1782μs | 61.8117 KOps/s | 60.4593 KOps/s | |
test_step_mdp_speed[True-True-False-False-True] | 51.1560μs | 16.6116μs | 60.1990 KOps/s | 58.4970 KOps/s | |
test_step_mdp_speed[True-True-False-False-False] | 33.2220μs | 10.3613μs | 96.5131 KOps/s | 93.8897 KOps/s | |
test_step_mdp_speed[True-False-True-True-True] | 69.0290μs | 27.7848μs | 35.9909 KOps/s | 35.4784 KOps/s | |
test_step_mdp_speed[True-False-True-True-False] | 48.4000μs | 17.7744μs | 56.2608 KOps/s | 55.2120 KOps/s | |
test_step_mdp_speed[True-False-True-False-True] | 39.6340μs | 16.7139μs | 59.8306 KOps/s | 58.4268 KOps/s | |
test_step_mdp_speed[True-False-True-False-False] | 33.6930μs | 10.4560μs | 95.6387 KOps/s | 94.2482 KOps/s | |
test_step_mdp_speed[True-False-False-True-True] | 61.9360μs | 29.1285μs | 34.3307 KOps/s | 33.8839 KOps/s | |
test_step_mdp_speed[True-False-False-True-False] | 43.2910μs | 19.1336μs | 52.2640 KOps/s | 51.3646 KOps/s | |
test_step_mdp_speed[True-False-False-False-True] | 46.9370μs | 18.2247μs | 54.8705 KOps/s | 54.3646 KOps/s | |
test_step_mdp_speed[True-False-False-False-False] | 36.1670μs | 11.9122μs | 83.9473 KOps/s | 83.2205 KOps/s | |
test_step_mdp_speed[False-True-True-True-True] | 71.0330μs | 27.8445μs | 35.9137 KOps/s | 35.7568 KOps/s | |
test_step_mdp_speed[False-True-True-True-False] | 40.1940μs | 17.8556μs | 56.0047 KOps/s | 55.1728 KOps/s | |
test_step_mdp_speed[False-True-True-False-True] | 64.2200μs | 19.4028μs | 51.5390 KOps/s | 50.7963 KOps/s | |
test_step_mdp_speed[False-True-True-False-False] | 36.6380μs | 11.8928μs | 84.0844 KOps/s | 83.4239 KOps/s | |
test_step_mdp_speed[False-True-False-True-True] | 70.9120μs | 29.4971μs | 33.9017 KOps/s | 34.0544 KOps/s | |
test_step_mdp_speed[False-True-False-True-False] | 42.3490μs | 19.0970μs | 52.3641 KOps/s | 51.3832 KOps/s | |
test_step_mdp_speed[False-True-False-False-True] | 56.0750μs | 20.9086μs | 47.8273 KOps/s | 47.5941 KOps/s | |
test_step_mdp_speed[False-True-False-False-False] | 38.9130μs | 13.1319μs | 76.1505 KOps/s | 74.6890 KOps/s | |
test_step_mdp_speed[False-False-True-True-True] | 62.9570μs | 30.7627μs | 32.5069 KOps/s | 31.9977 KOps/s | |
test_step_mdp_speed[False-False-True-True-False] | 44.0310μs | 20.6781μs | 48.3603 KOps/s | 48.2394 KOps/s | |
test_step_mdp_speed[False-False-True-False-True] | 45.2740μs | 20.7114μs | 48.2825 KOps/s | 46.7414 KOps/s | |
test_step_mdp_speed[False-False-True-False-False] | 48.2500μs | 13.0969μs | 76.3540 KOps/s | 74.9561 KOps/s | |
test_step_mdp_speed[False-False-False-True-True] | 65.6530μs | 31.8284μs | 31.4185 KOps/s | 31.1884 KOps/s | |
test_step_mdp_speed[False-False-False-True-False] | 48.5910μs | 21.9542μs | 45.5493 KOps/s | 45.1235 KOps/s | |
test_step_mdp_speed[False-False-False-False-True] | 56.9960μs | 22.0426μs | 45.3667 KOps/s | 45.2820 KOps/s | |
test_step_mdp_speed[False-False-False-False-False] | 57.0000μs | 14.4529μs | 69.1902 KOps/s | 67.9674 KOps/s | |
test_values[generalized_advantage_estimate-True-True] | 12.2805ms | 11.9656ms | 83.5727 Ops/s | 83.2598 Ops/s | |
test_values[vec_generalized_advantage_estimate-True-True] | 35.8411ms | 27.4981ms | 36.3661 Ops/s | 37.9667 Ops/s | |
test_values[td0_return_estimate-False-False] | 0.3038ms | 0.2019ms | 4.9524 KOps/s | 5.0591 KOps/s | |
test_values[td1_return_estimate-False-False] | 43.2393ms | 26.0624ms | 38.3694 Ops/s | 39.1891 Ops/s | |
test_values[vec_td1_return_estimate-False-False] | 36.2238ms | 27.3441ms | 36.5710 Ops/s | 37.6727 Ops/s | |
test_values[td_lambda_return_estimate-True-False] | 38.1796ms | 35.3343ms | 28.3011 Ops/s | 27.6340 Ops/s | |
test_values[vec_td_lambda_return_estimate-True-False] | 37.1696ms | 27.2832ms | 36.6526 Ops/s | 37.9012 Ops/s | |
test_gae_speed[generalized_advantage_estimate-False-1-512] | 8.3357ms | 8.1652ms | 122.4703 Ops/s | 121.5759 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] | 9.8949ms | 2.0154ms | 496.1828 Ops/s | 518.5728 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] | 42.0145ms | 0.6351ms | 1.5746 KOps/s | 2.3424 KOps/s | |
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] | 41.4568ms | 39.4756ms | 25.3321 Ops/s | 25.7916 Ops/s | |
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] | 10.8306ms | 2.5229ms | 396.3739 Ops/s | 395.8207 Ops/s | |
test_dqn_speed | 9.8810ms | 1.7014ms | 587.7508 Ops/s | 551.4577 Ops/s | |
test_ddpg_speed | 11.6066ms | 3.1233ms | 320.1723 Ops/s | 307.2264 Ops/s | |
test_sac_speed | 16.8908ms | 8.6290ms | 115.8886 Ops/s | 95.2178 Ops/s | |
test_redq_speed | 26.1146ms | 16.0131ms | 62.4487 Ops/s | 58.0596 Ops/s | |
test_redq_deprec_speed | 22.6620ms | 14.1040ms | 70.9020 Ops/s | 67.5739 Ops/s | |
test_td3_speed | 9.7941ms | 8.7413ms | 114.3999 Ops/s | 113.6113 Ops/s | |
test_cql_speed | 43.8997ms | 36.3385ms | 27.5190 Ops/s | 28.0819 Ops/s | |
test_a2c_speed | 19.1181ms | 8.4057ms | 118.9669 Ops/s | 127.3117 Ops/s | |
test_ppo_speed | 18.0665ms | 8.6371ms | 115.7799 Ops/s | 121.7369 Ops/s | |
test_reinforce_speed | 15.7218ms | 7.4704ms | 133.8620 Ops/s | 143.6070 Ops/s | |
test_iql_speed | 41.5299ms | 33.4111ms | 29.9302 Ops/s | 30.9266 Ops/s | |
test_sample_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] | 2.6931ms | 1.8202ms | 549.3846 Ops/s | 540.4843 Ops/s | |
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] | 2.7182ms | 1.9685ms | 508.0005 Ops/s | 511.4274 Ops/s | |
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] | 2.9633ms | 1.9571ms | 510.9582 Ops/s | 511.1536 Ops/s | |
test_sample_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] | 2.9214ms | 1.8320ms | 545.8546 Ops/s | 538.0525 Ops/s | |
test_sample_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] | 0.1251s | 2.1991ms | 454.7299 Ops/s | 492.4756 Ops/s | |
test_sample_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] | 2.8770ms | 1.9423ms | 514.8623 Ops/s | 473.5355 Ops/s | |
test_sample_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] | 2.7285ms | 1.8275ms | 547.2060 Ops/s | 538.3697 Ops/s | |
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] | 2.8880ms | 1.9677ms | 508.1959 Ops/s | 504.5614 Ops/s | |
test_sample_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] | 0.1296s | 2.1992ms | 454.7087 Ops/s | 503.5217 Ops/s | |
test_iterate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] | 2.8060ms | 1.8179ms | 550.0767 Ops/s | 534.8955 Ops/s | |
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] | 2.8886ms | 1.9703ms | 507.5390 Ops/s | 440.0595 Ops/s | |
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] | 2.9261ms | 1.9469ms | 513.6429 Ops/s | 511.9636 Ops/s | |
test_iterate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] | 2.0061ms | 1.8176ms | 550.1791 Ops/s | 522.8175 Ops/s | |
test_iterate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] | 0.1215s | 2.1956ms | 455.4599 Ops/s | 509.7597 Ops/s | |
test_iterate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] | 2.4731ms | 1.9446ms | 514.2530 Ops/s | 507.0198 Ops/s | |
test_iterate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] | 2.7242ms | 1.8255ms | 547.7900 Ops/s | 541.0782 Ops/s | |
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] | 2.9351ms | 1.9179ms | 521.4152 Ops/s | 509.8837 Ops/s | |
test_iterate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] | 0.1232s | 2.1759ms | 459.5876 Ops/s | 518.9081 Ops/s | |
test_populate_rb[TensorDictReplayBuffer-ListStorage-RandomSampler-400] | 0.2404s | 21.5626ms | 46.3766 Ops/s | 44.3286 Ops/s | |
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] | 0.1094s | 20.4640ms | 48.8663 Ops/s | 53.9676 Ops/s | |
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] | 0.1084s | 18.6918ms | 53.4993 Ops/s | 48.6749 Ops/s | |
test_populate_rb[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] | 0.1117s | 20.8078ms | 48.0589 Ops/s | 53.2584 Ops/s | |
test_populate_rb[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] | 0.1155s | 18.9521ms | 52.7645 Ops/s | 48.5141 Ops/s | |
test_populate_rb[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] | 0.1123s | 20.8011ms | 48.0743 Ops/s | 53.3048 Ops/s | |
test_populate_rb[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] | 0.1178s | 19.3776ms | 51.6060 Ops/s | 48.6799 Ops/s | |
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] | 0.1170s | 21.0438ms | 47.5198 Ops/s | 54.7358 Ops/s | |
test_populate_rb[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] | 0.1064s | 18.6342ms | 53.6646 Ops/s | 49.1166 Ops/s |
albertbou92
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.