Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Algorithm] Update DT #1560

Merged
merged 9 commits into from
Oct 5, 2023
Merged

[Algorithm] Update DT #1560

merged 9 commits into from
Oct 5, 2023

Conversation

BY571
Copy link
Contributor

@BY571 BY571 commented Sep 21, 2023

Description

Similar to #1523 a cleanup for logging, comments, and timing

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [X ] I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 21, 2023
@vmoens
Copy link
Contributor

vmoens commented Oct 4, 2023

@BY571 is this ready for review?

@BY571
Copy link
Contributor Author

BY571 commented Oct 4, 2023

@BY571 is this ready for review?

Yes, should be ready for review.

Also, #998 whenever you have time :)

@vmoens vmoens marked this pull request as ready for review October 5, 2023 07:53
@vmoens
Copy link
Contributor

vmoens commented Oct 5, 2023

Wonderful thanks!
Don't hesitate to make the PR ready for review (not draft) and ping me when it's ready!

@vmoens vmoens added the new algo New algorithm request or PR label Oct 5, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!

@vmoens vmoens merged commit f62785b into pytorch:main Oct 5, 2023
vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. new algo New algorithm request or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants