Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Pettingzoo: add multiagent dimension to single agent groups #1550

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

matteobettini
Copy link
Contributor

Prior to this PR, in PettingZoo, groups with one agent only had the multiagent dimension removed.

This PR adds the multiagent dimension to those groups for consistency purposes.

Signed-off-by: Matteo Bettini <[email protected]>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2023
@matteobettini matteobettini changed the title [Feature] Add multiagent dimension to single agent groups [Feature] Pettingzoo: add multiagent dimension to single agent groups Sep 20, 2023
@vmoens vmoens added the enhancement New feature or request label Sep 20, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code is better code

@vmoens vmoens merged commit bf02209 into pytorch:main Sep 20, 2023
@matteobettini matteobettini deleted the pettingzoo_one_agent_group branch September 20, 2023 10:53
vmoens pushed a commit to hyerra/rl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants