-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] D4rl direct download #1430
Conversation
# Conflicts: # torchrl/data/datasets/d4rl.py
… d4rl_direct_download # Conflicts: # torchrl/data/datasets/d4rl.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very happy with these changes @MateuszGuzek thanks a lot!
The main blocker right now is to document how this works in practice.
Being able to download data directly is great but we need to see what that means for environment execution:
The specific use case I would like to cover is:
$ pip install git+https://github.com/Farama-Foundation/d4rl.git
$ pip install gym -U
$ python -c """
# Works with latest gym installed:
from torchrl.data.datasets import D4RLExperienceReplay
data = D4RLExperienceReplay("halfcheetah-medium-v2", batch_size=10, from_env=False)
for batch in data:
print(batch)
break
# Not sure this makes sense if gym version is above 0.24
import d4rl
import gym
gym.make("halfcheetah-medium-v2")
"""
If this cannot be done, I think this PR still makes sense (one should have access to the data, regardless of the gym version)
To be discussed to: do we want to make the D4RL-independent download default? It'll be bc-breaking so I would rather make a progressive change
cc @BY571
Update on this: |
Co-authored-by: Mateusz Guzek <[email protected]> Co-authored-by: vmoens <[email protected]>
Description
Allow for a direct download of D4RL datasets, without installing D4RL.
This PR restores the previous PR: #1376 which was uintentionally closed.
Motivation and Context
TBD, raised during direct discussion with @vmoens