-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] CatFrames used as inverse #1321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also check what happens when we set as_inverse=True
and append it to an environment. This should modify the observation in the input tensordict, which is pretty useless unless it is also part of the input keys.
So either we raise an exception when as_inverse=True
and the transform has a parent or we make it possible but then we need to define what behaviour is expected and what transformation the observation_spec / input_spec should have. I'm more in favour of the first option (raising an exception if it has a parent).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, can you add a simple check in test_transform_as_inverse
where you create the transform and append it to an env, and check that the error is raised appropriately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (final)
Description
Adding the 'as_inverse' option to the CatFrames transform. With this transform we can use the CatFrames transform when adding data to the Replay Buffer. By that, the RB will consist of unfolded sequential samples.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!