Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] CatFrames used as inverse #1321

Merged
merged 7 commits into from
Jun 28, 2023
Merged

Conversation

BY571
Copy link
Contributor

@BY571 BY571 commented Jun 27, 2023

Description

Adding the 'as_inverse' option to the CatFrames transform. With this transform we can use the CatFrames transform when adding data to the Replay Buffer. By that, the RB will consist of unfolded sequential samples.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check what happens when we set as_inverse=True and append it to an environment. This should modify the observation in the input tensordict, which is pretty useless unless it is also part of the input keys.
So either we raise an exception when as_inverse=True and the transform has a parent or we make it possible but then we need to define what behaviour is expected and what transformation the observation_spec / input_spec should have. I'm more in favour of the first option (raising an exception if it has a parent).

@vmoens vmoens changed the title Update CatFrames [Feature] CatFrames used as inverse Jun 27, 2023
@vmoens vmoens added the enhancement New feature or request label Jun 28, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, can you add a simple check in test_transform_as_inverse where you create the transform and append it to an env, and check that the error is raised appropriately?

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (final)

@vmoens vmoens merged commit 788ad58 into pytorch:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants