[Feature] KL Transform for RLHF #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tcbegley
approved these changes
May 30, 2023
| actor, keep_params=False, funs_to_decorate=["forward", "get_dist"] | ||
| ) | ||
| self.functional_actor = deepcopy(actor) | ||
| repopulate_module(actor, params) |
There was a problem hiding this comment.
Why do we repopulate here when below we seem to only call with params=self.frozen_params? Is this so that the caller can continue to use actor having supplied it as an argument to the constructor?
There was a problem hiding this comment.
we don't want users to get an actor without parameters, that's all
there wouldn't be much to train :p
apbard
approved these changes
May 30, 2023
# Conflicts: # torchrl/csrc/utils.h # torchrl/modules/distributions/continuous.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tcbegley @apbard