solve b410 #411
Merged
solve b410 #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like no tests are affected by this. Probably means we need better tests for it. |
jGaboardi
approved these changes
Dec 2, 2023
This was referenced Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #410 means that no capacitated LSCP will ever be solvable through
from_geodataframe(). The check requires that demand weight is less than capacity, but transposes the capacity and demand arrays. So, all cases where capacity is greater than demand have an error raised saying that there is not enough capacity, while all cases where capacity is less than demand proceed to solve and return infeasible.This fixes the transposition.