Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 310 to CI matrix #208

Merged
merged 5 commits into from
Dec 24, 2021
Merged

add 310 to CI matrix #208

merged 5 commits into from
Dec 24, 2021

Conversation

jGaboardi
Copy link
Member

The PR adds Python 3.10 to the GHA testing schema.

@jGaboardi jGaboardi added the CI label Dec 23, 2021
@jGaboardi jGaboardi self-assigned this Dec 23, 2021
@martinfleis
Copy link
Member

CI change is fine. We now need to fix this line

iterable_values = isinstance(dct[sorted_keys[0]], collections.Iterable)

I think that it needs to be collections.abc.Iterable now. That should work for 3.3+.

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #208 (8afd43e) into main (e231ce0) will increase coverage by 0.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #208     +/-   ##
=======================================
+ Coverage   65.1%   65.4%   +0.3%     
=======================================
  Files         23      23             
  Lines       2461    2462      +1     
  Branches     534     535      +1     
=======================================
+ Hits        1602    1610      +8     
+ Misses       786     774     -12     
- Partials      73      78      +5     
Impacted Files Coverage Δ
spopt/region/util.py 57.5% <100.0%> (+0.2%) ⬆️
spopt/region/azp.py 34.2% <0.0%> (ø)
spopt/region/maxp.py 96.0% <0.0%> (+0.8%) ⬆️
spopt/_version.py 33.8% <0.0%> (+1.5%) ⬆️

@martinfleis martinfleis merged commit 1abfc56 into pysal:main Dec 24, 2021
@martinfleis
Copy link
Member

Thanks @jGaboardi!

@jGaboardi jGaboardi deleted the ci310 branch December 24, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants