BUG: fix enclosed tessellation index allocation when threshold eliminates buildings #568
+43
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
=======================================
+ Coverage 97.4% 97.7% +0.4%
=======================================
Files 26 32 +6
Lines 4328 4996 +668
=======================================
+ Hits 4214 4882 +668
Misses 114 114
|
Co-authored-by: James Gaboardi <[email protected]>
jGaboardi
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That uncovered line @jGaboardi noticed actually contained a bug...
It is a corner case but when there are at least two intersecting buildings in an enclosure but both of them are eliminated by the intersection threshold, we were getting multiple rows indexed -1. Fixed.