Rotation flag and options to restrict height/width using source format #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/width using source format, soft fail on listner dispatch
viralauraframes
commented
Dec 8, 2023
| @@ -140,7 +140,7 @@ public void handleMessage(@NonNull Message message) { | |||
| Bundle data = message.getData(); | |||
| String jobId = data.getString(KEY_JOB_ID); | |||
| if (jobId == null) { | |||
| throw new IllegalArgumentException("Handler message doesn't contain an id!"); | |||
| Log.e(TAG, "Handler message doesn't contain an id!"); | |||
There was a problem hiding this comment.
to avoid a crash and to still forward the callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in #1 we did the copy of rotation flag from source to target video using a MediaMetadataRetriever but had ssl problems for some reason.
This PR does the same using the source format that is retrieved by doing a range request by the MediaExtractor.