(MODULES-1576) Fix symlink support for older Puppet versions #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iristyle
changed the title
- In commit dc4e8ae, a change was introduced to enable the 'spec_prep' task to work properly on Windows. Unfortunately this was done without appropriate consideration for the versions of Puppet that spec_helper need to support, and Puppet::FileSystem symlink support was added in Puppet 3.5, via puppetlabs/puppet@938b4e7 While it's true that the symlink code was initially added to Puppet in 3.4, we'll not take that into consideration and just rely on the existence of Puppet::FileSystem as our heuristic for Windows symlink support (given the code was structured differently in prior versions) Additionally emit an upgrade failure on Windows when symlinks are not supported. The is_windows check is equivalent to how Puppet and Ruby itself test for Windows.
Iristyle
force-pushed
the
restore-symlink-support-for-puppets-earlier-than-3.5
branch
from
b725831 to
a7facc4
Compare
hunner
added a commit
that referenced
this pull request
Dec 12, 2014
…ets-earlier-than-3.5 (MODULES-1576) Fix symlink support for older Puppet versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit dc4e8ae, a change was
introduced to enable the 'spec_prep' task to work properly on
Windows. Unfortunately this was done without appropriate
consideration for the versions of Puppet that spec_helper need to
support, and Puppet::FileSystem symlink support was added in Puppet
3.5, via puppetlabs/puppet@938b4e7
While it's true that the symlink code was initially added to Puppet
in 3.4, we'll not take that into consideration and just rely
on the existence of Puppet::FileSystem as our heuristic for
Windows symlink support (given the code was structured differently
in prior versions)
Additionally emit an upgrade failure on Windows when symlinks are not
supported.
The is_windows check is equivalent to how Puppet and Ruby itself
test for Windows.