Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-1576) Fix symlink support for older Puppet versions #85

Conversation

Iristyle
Copy link
Contributor

  • In commit dc4e8ae, a change was
    introduced to enable the 'spec_prep' task to work properly on
    Windows. Unfortunately this was done without appropriate
    consideration for the versions of Puppet that spec_helper need to
    support, and Puppet::FileSystem symlink support was added in Puppet
    3.5, via puppetlabs/puppet@938b4e7

    While it's true that the symlink code was initially added to Puppet
    in 3.4, we'll not take that into consideration and just rely
    on the existence of Puppet::FileSystem as our heuristic for
    Windows symlink support (given the code was structured differently
    in prior versions)

    Additionally emit an upgrade failure on Windows when symlinks are not
    supported.

    The is_windows check is equivalent to how Puppet and Ruby itself
    test for Windows.

@Iristyle Iristyle changed the title Fix symlink support for older Puppet versions (MODULES-1576) Fix symlink support for older Puppet versions Dec 12, 2014
 - In commit dc4e8ae, a change was
   introduced to enable the 'spec_prep' task to work properly on
   Windows.  Unfortunately this was done without appropriate
   consideration for the versions of Puppet that spec_helper need to
   support, and Puppet::FileSystem symlink support was added in Puppet
   3.5, via puppetlabs/puppet@938b4e7

   While it's true that the symlink code was initially added to Puppet
   in 3.4, we'll not take that into consideration and just rely
   on the existence of Puppet::FileSystem as our heuristic for
   Windows symlink support (given the code was structured differently
   in prior versions)

   Additionally emit an upgrade failure on Windows when symlinks are not
   supported.

   The is_windows check is equivalent to how Puppet and Ruby itself
   test for Windows.
@Iristyle Iristyle force-pushed the restore-symlink-support-for-puppets-earlier-than-3.5 branch from b725831 to a7facc4 Compare December 12, 2014 22:10
hunner added a commit that referenced this pull request Dec 12, 2014
…ets-earlier-than-3.5

(MODULES-1576) Fix symlink support for older Puppet versions
@hunner hunner merged commit 73c2f12 into puppetlabs:master Dec 12, 2014
@chelnak chelnak added the bug label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants