Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement a CLI to run multiple JSON files #66

Merged
merged 1 commit into from
Mar 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "Replay is a library which provides an API to replay and stringify recordings created using Chrome DevTools Recorder](https://developer.chrome.com/docs/devtools/recorder/)",
"main": "lib/main.js",
"types": "lib/main.d.ts",
"bin": "./lib/cli.js",
"repository": "github:puppeteer/replay",
"directories": {
"doc": "docs"
Expand Down Expand Up @@ -58,5 +59,13 @@
"typedoc": "0.22.13",
"typedoc-plugin-markdown": "3.11.14",
"typescript": "4.6.2"
},
"peerDependencies": {
"puppeteer": "^13.5.1"
},
"peerDependenciesMeta": {
"puppeteer": {
"optional": true
}
}
}
43 changes: 43 additions & 0 deletions src/CLIUtils.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/**
Copyright 2022 Google LLC

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

https://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

import { parse, createRunner } from './main.js';
import { readFileSync } from 'fs';

export function getFilenames(argv: string[]) {
return argv.slice(2);
}

export async function runFiles(
files: string[],
opts = { log: false }
): Promise<boolean> {
for (const file of files) {
opts.log && console.log(`Running ${file}...`);
try {
const content = readFileSync(file, 'utf-8');
const object = JSON.parse(content);
const recording = parse(object);
const runner = await createRunner(recording);
await runner.run();
opts.log && console.log(`Finished running ${file}`);
} catch (err) {
opts.log && console.error(`Error running ${file}`, err);
return false;
}
}
return true;
}
27 changes: 27 additions & 0 deletions src/cli.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
#!/usr/bin/env node

/**
Copyright 2022 Google LLC

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

https://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

import { getFilenames, runFiles } from './CLIUtils.js';

const recordings = getFilenames(process.argv);
if (!recordings.length) {
console.log(`Usage: replay filename [filename...]`);
}
await runFiles(recordings, {
log: true,
});
45 changes: 45 additions & 0 deletions test/cli_test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
/**
Copyright 2022 Google LLC

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

https://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

import { getFilenames, runFiles } from '../src/CLIUtils.js';
import { assert } from 'chai';
import path from 'path';
import url from 'url';

const __dirname = path.dirname(url.fileURLToPath(import.meta.url));

describe('cli', () => {
describe('getFilenames', () => {
it('extracts filenames from process.argv', () => {
assert.deepStrictEqual(getFilenames(['node', 'script.js']), []);
assert.deepStrictEqual(getFilenames(['node', 'script.js', 'file1']), [
'file1',
]);
assert.deepStrictEqual(
getFilenames(['node', 'script.js', 'file1', 'file2', 'file3']),
['file1', 'file2', 'file3']
);
});
});

describe('runFiles', () => {
it('is able to run successfully', async () => {
assert.isTrue(
await runFiles([path.join(__dirname, 'resources', 'replay.json')])
);
});
});
});
9 changes: 9 additions & 0 deletions test/resources/replay.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"title": "wiki",
"steps": [
{
"type": "navigate",
"url": "https://www.wikipedia.org/"
}
]
}