Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Lighthouse types #307

Merged
merged 2 commits into from
Sep 20, 2022
Merged

fix: remove Lighthouse types #307

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7c16a6
fix: remove Lighthouse types
adamraine Sep 20, 2022
cb178a0
Merge branch 'main' into rm-lh-types
adamraine Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/lighthouse/LighthouseRunnerExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,13 @@ import { PuppeteerRunnerExtension } from '../PuppeteerRunnerExtension.js';
import type { Step, UserFlow } from '../Schema.js';
import { isMobileFlow, isNavigationStep } from './helpers.js';

import type FlowResult from 'lighthouse/types/lhr/flow';

export class LighthouseRunnerExtension extends PuppeteerRunnerExtension {
#isTimespanRunning = false;
#isNavigationRunning = false;
#lhFlow?: any;

async createFlowResult(): Promise<FlowResult> {
// TODO: Use Lighthouse types once the peer dependency is defined.
async createFlowResult(): Promise<any> {
if (!this.#lhFlow) {
throw new Error('Cannot get flow result before running the flow');
}
Expand Down