fix: use count for double click (#524)

__snapshots__/LighthouseStringifyExtension.test.ts.js

@@ -1,6 +1,6 @@
 exports['LighthouseStringifyExtension handles ending timespan 1'] = `
 const fs = require('fs');
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -61,7 +61,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 
 exports['LighthouseStringifyExtension handles ending navigation 1'] = `
 const fs = require('fs');
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -133,7 +133,7 @@ exports[
   'LighthouseStringifyExtension handles multiple sequential navigations 1'
 ] = `
 const fs = require('fs');
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});

__snapshots__/lighthouse.test.ts.js

@@ -2,7 +2,7 @@ exports[
   'Lighthouse user flow run via stringify produces a valid desktop flow report 1'
 ] = `
 const fs = require('fs');
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});

__snapshots__/stringify.test.ts.js

@@ -1,5 +1,5 @@
 exports['stringify should print the correct script for a navigate step 1'] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -259,7 +259,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 exports[
   'stringify should print the correct script for a emulateNetworkCondition step 1'
 ] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -524,7 +524,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 exports[
   'stringify should print the correct script if the target is not the main page 1'
 ] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -795,7 +795,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 `;
 
 exports['stringify should use step and flow timeouts 1'] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -1069,7 +1069,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 exports[
   'stringify should print the correct script if the step is within an iframe 1'
 ] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -1341,7 +1341,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 `;
 
 exports['stringify should print the correct script for a keydown step 1'] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -1599,7 +1599,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 `;
 
 exports['stringify should print the correct script for a keyup step 1'] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -1857,7 +1857,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 `;
 
 exports['stringify should print the correct script for scroll events 1'] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -2127,7 +2127,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 exports[
   'stringify should print the correct script for waitForElement steps 1'
 ] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});
@@ -2392,7 +2392,7 @@ const puppeteer = require('puppeteer'); // v13.0.0 or later
 exports[
   'stringify should print the correct script for waitForExpression steps 1'
 ] = `
-const puppeteer = require('puppeteer'); // v13.0.0 or later
+const puppeteer = require('puppeteer'); // v19.11.1 or later
 
 (async () => {
   const browser = await puppeteer.launch({headless: 'new'});

package.json

@@ -86,7 +86,7 @@
     "typescript": "4.8.4"
   },
   "peerDependencies": {
-    "puppeteer": ">=19.11.0",
+    "puppeteer": ">=19.11.1",
     "lighthouse": ">=10.0.0"
   },
   "peerDependenciesMeta": {

src/PuppeteerRunnerExtension.ts

@@ -129,14 +129,7 @@ export class PuppeteerRunnerExtension extends RunnerExtension {
           }
           startWaitingForEvents();
           await element.click({
-            button: step.button && mouseButtonMap.get(step.button),
-            offset: {
-              x: step.offsetX,
-              y: step.offsetY,
-            },
-          });
-          await element.click({
-            clickCount: 2,
+            count: 2,
             button: step.button && mouseButtonMap.get(step.button),
             delay: step.duration,
             offset: {

src/PuppeteerStringifyExtension.ts

@@ -47,7 +47,7 @@ import { formatJSONAsJS } from './JSONUtils.js';
 export class PuppeteerStringifyExtension extends StringifyExtension {
   override async beforeAllSteps(out: LineWriter, flow: UserFlow) {
     out.appendLine(
-      "const puppeteer = require('puppeteer'); // v13.0.0 or later"
+      "const puppeteer = require('puppeteer'); // v19.11.1 or later"
     );
     out.appendLine('');
     out.appendLine('(async () => {').startBlock();
@@ -171,16 +171,7 @@ export class PuppeteerStringifyExtension extends StringifyExtension {
   #appendDoubleClickStep(out: LineWriter, step: DoubleClickStep): void {
     this.#appendWaitForSelector(out, step);
     out.appendLine('await element.click({');
-    if (step.button) {
-      out.appendLine(`  button: '${mouseButtonMap.get(step.button)}',`);
-    }
-    out.appendLine('  offset: {');
-    out.appendLine(`    x: ${step.offsetX},`);
-    out.appendLine(`    y: ${step.offsetY},`);
-    out.appendLine('  },');
-    out.appendLine('});');
-    out.appendLine('await element.click({');
-    out.appendLine(`  clickCount: 2,`);
+    out.appendLine(`  count: 2,`);
     if (step.duration) {
       out.appendLine(`  delay: ${step.duration},`);
     }