fix: add parsing for visible, attributes, and properties

puppeteer · Dec 22, 2022 · 29e10db · 29e10db
1 parent 67a1ee8
commit 29e10db
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/SchemaUtils.ts b/src/SchemaUtils.ts
@@ -178,6 +178,13 @@ function parseOptionalString(step: object, prop: string): string | undefined {
   return undefined;
 }
 
+function parseOptionalBoolean(step: object, prop: string): boolean | undefined {
+  if (hasProperty(step, prop)) {
+    return parseBoolean(step, prop);
+  }
+  return undefined;
+}
+
 function parseString(step: object, prop: string): string {
   if (hasProperty(step, prop)) {
     const maybeString = step[prop];
@@ -429,6 +436,13 @@ function parseWaitForElementStep(step: object): WaitForElementStep {
     type: StepType.WaitForElement,
     operator: operator as '>=' | '==' | '<=' | undefined,
     count: parseOptionalNumber(step, 'count'),
+    visible: parseOptionalBoolean(step, 'visible'),
+    attributes: hasProperty(step, 'attributes')
+      ? (step.attributes as { [name: string]: string })
+      : undefined,
+    properties: hasProperty(step, 'properties')
+      ? (step.properties as { [name: string]: string })
+      : undefined,
   };
 }
 

diff --git a/test/SchemaUtils.test.ts b/test/SchemaUtils.test.ts
@@ -322,6 +322,9 @@ describe('SchemaUtils', () => {
               selectors: [['aria/Test']],
               operator: '==',
               count: 1,
+              properties: {},
+              attributes: {},
+              visible: true,
             },
           ],
         }),
@@ -333,6 +336,9 @@ describe('SchemaUtils', () => {
               selectors: [['aria/Test']],
               operator: '==',
               count: 1,
+              properties: {},
+              attributes: {},
+              visible: true,
             },
           ],
         }