Release v4.7.4

defines.php

@@ -12,7 +12,7 @@
 defined('ABSPATH') or die('No direct script access allowed.');
 
 if (!defined('PP_AUTHORS_LOADED')) {
-    define('PP_AUTHORS_VERSION', '4.7.3');
+    define('PP_AUTHORS_VERSION', '4.7.4');
     define('PP_AUTHORS_FILE', 'publishpress-authors/publishpress-authors.php');
     define('PP_AUTHORS_BASE_PATH', plugin_dir_path(__DIR__ . '/publishpress-authors.php'));
     define('PP_AUTHORS_MODULES_PATH', PP_AUTHORS_BASE_PATH . 'src/modules/');

publishpress-authors.php

@@ -5,7 +5,7 @@
  * Description: PublishPress Authors allows you to add multiple authors and guest authors to WordPress posts
  * Author:      PublishPress
  * Author URI:  https://publishpress.com
- * Version: 4.7.3
+ * Version: 4.7.4
  * Text Domain: publishpress-authors
  * Domain Path: /languages
  * Requires at least: 5.5

readme.txt

@@ -7,7 +7,7 @@ Tags: multiple authors, authors, guest authors, author bio, author layouts
 Requires at least: 5.5
 Requires PHP: 7.2.5
 Tested up to: 6.7
-Stable tag: 4.7.3
+Stable tag: 4.7.4
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
 
@@ -105,7 +105,7 @@ PublishPress Authors Pro enables you to create author fields and enhance your au
 
 The Pro versions of the PublishPress plugins are well worth your investment. The Pro versions have extra features and faster support. [Click here to join PublishPress](https://publishpress.com/pricing/).
 
-Join PublishPress and you'll get access to these Pro plugins:
+Join PublishPress and you'll get access to these ten Pro plugins:
 
 * [PublishPress Authors Pro](https://publishpress.com/authors) allows you to add multiple authors and guest authors to WordPress posts.
 * [PublishPress Blocks Pro](https://publishpress.com/blocks) has everything you need to build professional websites with the WordPress block editor.
@@ -115,7 +115,8 @@ Join PublishPress and you'll get access to these Pro plugins:
 * [PublishPress Permissions Pro](https://publishpress.com/permissions)  is the plugin for advanced WordPress permissions.
 * [PublishPress Planner Pro](https://publishpress.com/publishpress) is the plugin for managing and scheduling WordPress content.
 * [PublishPress Revisions Pro](https://publishpress.com/revisions) allows you to update your published pages with teamwork and precision.
-* [PublishPress Series Pro](https://publishpress.com/series) enables you to group content together into a series
+* [PublishPress Series Pro](https://publishpress.com/series) enables you to group content together into a series.
+* [PublishPress Statuses Pro](https://publishpress.com/series) enables you to create additional publishing steps for your posts.
 
 Together, these plugins are a suite of powerful publishing tools for WordPress. If you need to create a professional workflow in WordPress, with moderation, revisions, permissions and more... then you should try PublishPress.
 
@@ -246,6 +247,26 @@ There are two ways to install the PublishPress Authors plugin:
 
 == Changelog ==
 
+= [4.7.4] - 20 Feb 2025 =
+
+* Fixed: Fix data sanitization on author categories
+* Fixed: PHP Warning with Rank Math, #1970
+* Fixed: Conflict between Polylang and Authors, #1931
+* Update: Add sub headings to Author Boxes > Author Fields, #1889
+* Update: Allow Display Name Author Categories to be in front, #1894
+* Fixed: PHP Fatal error: Uncaught Error: Call to a member function get_user_object() on bool, #1997
+* Update: Add settings to show Author profile above the content, #1929
+* Fixed: Post Filter Not Working when filtering on Author and Category together, #1933
+* Fixed: Admin "Mine" tab count is incorrect, and also including post from all post types instead of current post type, #1989
+* Fixed: "Mine" not showing when author is a secondary author on posts, #1939
+* Fixed: Undefined property: WP_Error::$count, #1974
+* Fixed: Author Categories Errors on installs, #1972
+* Fixed: Redundant repeated CSS and move Author box styling from content to footer(filtereable), #1976
+* Fixed: Fatal error: "Class "MultipleAuthors\WP_Error" not found", #1971
+* Update: Update "Twitter" for "X" on new installation, #1955
+* Update: Update text for bulk edit, #1978
+* Update: Authors Translation Updates v.4.7.3, #1966
+
 = [4.7.3] - 16 Dec 2024 =
 
 * Fixed: Can't change the layout for new Author Lists, #1892

src/assets/css/multiple-authors-widget.css

@@ -70,7 +70,9 @@
 }
 
 .pp-multiple-authors-layout-boxed .multiple-authors-name a,
-.pp-multiple-authors-layout-centered .multiple-authors-name a {
+.pp-multiple-authors-layout-centered .multiple-authors-name a,
+.pp-multiple-authors-layout-boxed .name-author-category,
+.pp-multiple-authors-layout-centered .name-author-category {
     margin-bottom: 10px;
     font-size: 1.2em;
 }

src/core/Classes/Author_Editor.php

@@ -836,7 +836,7 @@ public static function filter_author_bulk_actions($bulk_actions)
             'publishpress-authors'
         );
         $bulk_actions['convert_into_guest_author'] = __(
-            'Convert to Registered Author With User Account',
+            'Convert to Guest Author With User Account',
             'publishpress-authors'
         );
         $bulk_actions['update_post_count'] = __(

src/core/Classes/Post_Editor.php

@@ -302,7 +302,7 @@ public static function group_category_authors($author_categories, $author_relati
             $authors_data[] = [
                 'title'             => $author_category['plural_name'],
                 'singular_title'    => $author_category['category_name'],
-                'description'       => sprintf('Drag-and-drop Authors to add them to the %s category', $author_category['category_name']),
+                'description'       => sprintf(esc_html__('Drag-and-drop Authors to add them to the %s category', 'publishpress-authors'), $author_category['category_name']),
                 'slug'              => $author_category['slug'],
                 'id'                => $author_category['id'],
                 'authors'           => array_values($selected_authors)

src/core/Classes/Query.php

@@ -211,7 +211,7 @@ public static function filter_author_posts_where($where, $query)
         }
         $where = preg_replace(
             '/\(?\b(?:' . $wpdb->posts . '\.)?post_author\s*(?:=|IN)\s*\(?(\d+)\)? AND (?:' . $wpdb->posts . '\.)?post_status = \'(\w+)\'/',
-            '(' . $maybe_both_query . ' ' . $wpdb->term_taxonomy . '.term_id = \'' . (int)$current_user_term_id . '\' AND ' . $wpdb->posts . '.post_status = \'$2\'',
+            '(' . $maybe_both_query . ' ' . 'ppmaq1.term_taxonomy_id IN (' . (int)$current_user_term_id . ') AND ' . $wpdb->posts . '.post_status = \'$2\'',
             $where,
             -1
         );
@@ -221,12 +221,15 @@ public static function filter_author_posts_where($where, $query)
          */
         $where = preg_replace(
             '/\(?\b(?:' . $wpdb->posts . '\.)?post_author\s*(?:=|IN)\s*\(?(\d+)\)?/',
-            '(' . $maybe_both_query . ' ' . '(' . $wpdb->term_taxonomy . '.term_id = \'' . (int)$term->term_id . '\') ' . ')',
+            '(' . $maybe_both_query . ' ' . '(ppmaq1.term_taxonomy_id IN (' . (int)$term->term_id . ')) ' . ')',
             $where,
             -1
         );
-
-        $where = static::add_custom_post_types_to_query($where);
+
+        // Add post type only if it's not an admin main query
+        if ( ! ( is_admin() && $query->is_main_query() ) ) {
+            $where = static::add_custom_post_types_to_query($where);
+        }
 
         return apply_filters('publishpress_authors_filter_posts_list_where', $where, $query, $term);
     }
@@ -249,8 +252,8 @@ public static function filter_posts_join($join, $query)
 
         // Check to see that JOIN hasn't already been added. Props michaelingp and nbaxley.
         $term_relationship_inner_join = " INNER JOIN {$wpdb->term_relationships} ON ({$wpdb->posts}.ID = {$wpdb->term_relationships}.object_id)";
-        $term_relationship_left_join  = " LEFT JOIN {$wpdb->term_relationships} ON ({$wpdb->posts}.ID = {$wpdb->term_relationships}.object_id)";
-        $term_taxonomy_join           = " INNER JOIN {$wpdb->term_taxonomy} ON ( {$wpdb->term_relationships}.term_taxonomy_id = {$wpdb->term_taxonomy}.term_taxonomy_id )";
+        $term_relationship_left_join  = " LEFT JOIN {$wpdb->term_relationships} AS ppmaq1 ON ({$wpdb->posts}.ID = ppmaq1.object_id)";
+        $term_taxonomy_join           = " INNER JOIN {$wpdb->term_taxonomy} ON ( ppmaq1.term_taxonomy_id = {$wpdb->term_taxonomy}.term_taxonomy_id )";
 
         // 4.6+ uses a LEFT JOIN for tax queries so we need to check for both.
         if (false === strpos($join, trim($term_relationship_inner_join))
@@ -259,7 +262,7 @@ public static function filter_posts_join($join, $query)
         }
 
         if (false === strpos($join, trim($term_taxonomy_join))) {
-            $join .= str_replace('INNER JOIN', 'LEFT JOIN', $term_taxonomy_join);
+           $join .= str_replace('INNER JOIN', 'LEFT JOIN', $term_taxonomy_join);
         }
 
         return $join;
@@ -330,7 +333,7 @@ public static function filter_admin_posts_list_where($where, $query)
             return $where;
         }
 
-        $terms_implode = '(' . $wpdb->term_taxonomy . '.term_id = \'' . (int)$author->getTerm()->term_id . '\') ';
+        $terms_implode = '(' . 'ppmaq1.term_taxonomy_id IN (' . (int)$author->getTerm()->term_id . ')) ';
 
         /**
          * Regex for Post Author + Post Status solution for private and custom post status
@@ -348,9 +351,10 @@ public static function filter_admin_posts_list_where($where, $query)
         } else {
             $current_user_term_id = 0;
         }
+
         $where = preg_replace(
             '/\(?\b(?:' . $wpdb->posts . '\.)?post_author\s*(?:=|IN)\s*\(?(\d+)\)? AND (?:' . $wpdb->posts . '\.)?post_status = \'(\w+)\'/',
-            '(' . $wpdb->term_taxonomy . '.term_id = \'' . (int)$current_user_term_id . '\' AND ' . $wpdb->posts . '.post_status = \'$2\'',
+            '(' . 'ppmaq1.term_taxonomy_id IN (' . (int)$current_user_term_id . ') AND ' . $wpdb->posts . '.post_status = \'$2\'',
             $where,
             -1
         );
@@ -451,8 +455,8 @@ public static function filter_posts_list_join($join, $query)
 
         // Check to see that JOIN hasn't already been added. Props michaelingp and nbaxley.
         $term_relationship_inner_join = " INNER JOIN {$wpdb->term_relationships} ON ({$wpdb->posts}.ID = {$wpdb->term_relationships}.object_id)";
-        $term_relationship_left_join  = " LEFT JOIN {$wpdb->term_relationships} ON ({$wpdb->posts}.ID = {$wpdb->term_relationships}.object_id)";
-        $term_taxonomy_join           = " INNER JOIN {$wpdb->term_taxonomy} ON ( {$wpdb->term_relationships}.term_taxonomy_id = {$wpdb->term_taxonomy}.term_taxonomy_id )";
+        $term_relationship_left_join  = " LEFT JOIN {$wpdb->term_relationships} AS ppmaq1 ON ({$wpdb->posts}.ID = ppmaq1.object_id)";
+        $term_taxonomy_join           = " INNER JOIN {$wpdb->term_taxonomy} ON ( ppmaq1.term_taxonomy_id = {$wpdb->term_taxonomy}.term_taxonomy_id )";
 
         // 4.6+ uses a LEFT JOIN for tax queries so we need to check for both.
         if (false === strpos($join, trim($term_relationship_inner_join))

src/core/Plugin.php

@@ -18,6 +18,7 @@
 use MultipleAuthors\Classes\Utils;
 use MultipleAuthors\Traits\Author_box;
 use WP_Query;
+use WP_Error;
 
 defined('ABSPATH') or die('No direct script access allowed.');
 
@@ -1146,7 +1147,14 @@ public function filter_count_author_posts($count, $author)
             return 0;
         }
 
-        return $author->getTerm()->count;
+        $term = $author->getTerm();
+
+        // Ensure $term is a valid object before accessing properties incase of legacy data
+        if (!is_object($term) || is_wp_error($term)) {
+            return 0;
+        }
+
+        return $term->count ?? 0;
     }
 
     /**
@@ -1491,7 +1499,7 @@ public function enqueue_scripts($hook_suffix)
         $js_strings = [
             'edit_label'                    => esc_html__('Edit', 'publishpress-authors'),
             'new_button'                    => esc_html__('Add Author', 'publishpress-authors'),
-            'new_name_label'                => esc_html__('Author Name'),
+            'new_name_label'                => esc_html__('Author Name', 'publishpress-authors'),
             'confirm_delete'                => __(
                 'Are you sure you want to remove this author?',
                 'publishpress-authors'
@@ -1612,7 +1620,7 @@ public function filter_views($views)
         }
 
         $author     = Author::get_by_user_id(get_current_user_id());
-        if (!$author || !is_object(!$author)) {
+        if (!$author || !is_object($author)) {
             return $default_views;
         }
 
@@ -1804,11 +1812,19 @@ public function filter_the_content($content)
     {
         $legacyPlugin = Factory::getLegacyPlugin();
 
-        // Check if it is configured to append to the content
-        $append_to_content = 'yes' === $legacyPlugin->modules->multiple_authors->options->append_to_content;
+        if ($this->should_display_author_box()) {
 
-        if ($this->should_display_author_box() && $append_to_content) {
-            $content .= $this->get_author_box_markup('the_content');
+            // Check if it is configured to prepend and/or append to the content
+            $preppend_to_content = 'yes' === $legacyPlugin->modules->multiple_authors->options->preppend_to_content;
+            $append_to_content = 'yes' === $legacyPlugin->modules->multiple_authors->options->append_to_content;
+
+            if ($preppend_to_content) {
+                $content = $this->get_author_box_markup('the_content') . $content;
+            }
+
+            if ($append_to_content) {
+                $content .= $this->get_author_box_markup('the_content');
+            }
         }
 
         return $content;

src/functions/template-tags.php

@@ -428,6 +428,13 @@ function publishpress_authors_get_all_authors($args = [], $instance = [])
          */
         $args = apply_filters('pp_multiple_authors_get_all_authors_args', $args, $instance);
 
+        $args['orderby'] = sanitize_sql_orderby($args['orderby'] ?? 'name');
+        if (empty($args['orderby'])) {
+            $args['orderby'] = 'name';
+        }
+
+        $args['order'] = strtoupper($args['order'] ?? 'ASC') === 'DESC' ? 'DESC' : 'ASC';
+
         if (!empty($args['orderby']) && !in_array($args['orderby'], ['name', 'count'])) {
             $meta_order = true;
         } else {
@@ -566,7 +573,9 @@ function publishpress_authors_get_all_authors($args = [], $instance = [])
             } else {
                 $sql_order_by = "tm.meta_value";
             }
-            $term_query .= "ORDER BY {$sql_order_by} {$args['order']}";
+            $sql_order_by = $sql_order_by . ' ' . $args['order'];
+
+            $term_query .= "ORDER BY {$sql_order_by}";
             //add limit if it's a paginated request
             if ($paged) {
                 $term_query .= " LIMIT {$offset}, {$per_page}";
@@ -1484,12 +1493,15 @@ function get_ppma_author_categories($args = []) {
         $slug            = sanitize_text_field($args['slug']);
         $category_name   = sanitize_text_field($args['category_name']);
         $plural_name     = sanitize_text_field($args['plural_name']);
-        $orderby         = sanitize_text_field($args['orderby']);
         $search          = sanitize_text_field($args['search']);
-        $order           = strtoupper(sanitize_text_field($args['order']));
+        $orderby         = sanitize_sql_orderby($args['orderby'] . ' ' . strtoupper($args['order']));
         $category_status = sanitize_text_field($args['category_status']);
         $count_only      = boolval($args['count_only']);
 
+        if (empty($orderby)) {
+            $orderby = 'category_order ASC';
+        }
+
         $field_search = $field_value = false;
         if (!empty($id)) {
             $field_search = 'id';
@@ -1517,7 +1529,7 @@ function get_ppma_author_categories($args = []) {
                     FROM {$table_name}
                     LEFT JOIN {$meta_table_name} ON {$table_name}.id = {$meta_table_name}.category_id
                     WHERE {$table_name}.{$field_search} = %s
-                    ORDER BY {$orderby} {$order}
+                    ORDER BY {$orderby}
                     LIMIT 1",
                     $field_value
                 );
@@ -1558,7 +1570,7 @@ function get_ppma_author_categories($args = []) {
                 }
 
                 $query .= $wpdb->prepare(
-                    " ORDER BY {$orderby} {$order} LIMIT %d OFFSET %d",
+                    " ORDER BY {$orderby} LIMIT %d OFFSET %d",
                     $limit,
                     $offset
                 );