Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeclKind in z3-sys for new values #337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twizmwazin
Copy link

This adds all of the existing DeclKinds defined in the C API to the DeclKind enum. I did not add comments as they seemed inconsistent in the original. Let me know if I can improve this, I intend to add higher level bindings to various ops here for my use case.

Future work: This feels like it should be done as a macro.

@twizmwazin
Copy link
Author

I believe the ubuntu CI failure is due to Ubuntu 24.04 packaging z3 4.8.12, released in 2021, before some of these DeclKinds were added... I would advocate for bumping the minimum to something more recent. I don't know if that is palatable or conflicts with other goals though.

@toolCHAINZ
Copy link
Contributor

I ran into this same z3 issue on a project of mine. In my case, I re-targeted my docker setup on debian trixie. That distro is still unstable, but has an up-to-date z3 and has worked well (so far 🤞) for testing software using z3.rs.

@twizmwazin
Copy link
Author

In my case I will be statically linking z3, so I'm basically always using the bundled option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants